Compose Dialog Destination lost on orientation change [207386169]

Fixed

Bug

adexe s nau

Status Update

No update yet.

Description

le...@gmail.com

created issue #1

Nov 23, 2021 03:13PM

Component used: Navigation
Version used: 2.4.0-beta02
Devices/Android versions reproduced on: Emulator API 23 and 31

Describe the problem:

When navigating to a composable dialog destination, the dialog destination is lost after an orientation change.

Observed Results:

The composable dialog destination is lost after an orientation change

Expected Results:

The composable dialog destination should still be visible after an orientation change

Steps to reproduce:

Clone the reproduction project https://github.com/leinardi/Forlago/tree/dialog and checkout the branch dialog
Run the app
Tap on the button "Show Dialog"
Trigger an orientation change rotating the device

Relevant Code:

The composable dialog is defined here: https://github.com/leinardi/Forlago/blob/dialog/modules/feature-foo/src/main/kotlin/com/leinardi/forlago/feature/foo/ui/foodialog/FooDialogScreen.kt#L36

The Dialog destination route is defined here: https://github.com/leinardi/Forlago/blob/dialog/modules/core-navigation/src/main/kotlin/com/leinardi/forlago/core/navigation/destination/foo/FooDialogDestination.kt#L22

The Dialog destinations are added to the NavHost here: https://github.com/leinardi/Forlago/blob/dialog/app/src/main/kotlin/com/leinardi/forlago/ui/MainActivity.kt#L109

Attached there is a short video showing the issue.

device-2021-11-23-160305.mp4

775 KB

Download

Comments

il...@google.com <il...@google.com> Nov 29, 2021 05:38PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Dec 6, 2021 08:44PM

since these are in public API (:/) we need to do this in 1.2

jb...@google.com <jb...@google.com> #3Dec 6, 2021 09:13PM

Marked as fixed.

since it is already marked as deprecated, we can probably do it by now.

le...@gmail.com <le...@gmail.com> #4Dec 6, 2021 09:17PM

Opening diff shortly

or...@gmail.com <or...@gmail.com> #5Feb 11, 2022 05:28AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827