Fixed
Status Update
Comments
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #2
Nested scrolling works partially (as per http://b/122818889 ). Let's discuss if we need full support and if so make sure it works.
jb...@google.com <jb...@google.com> #3
Hi!
What is 'partially' exactly?
How do I see it?
Thanks!
What is 'partially' exactly?
How do I see it?
Thanks!
le...@gmail.com <le...@gmail.com> #4
As of now:
- Nesting scroll views with a scroll direction perpendicular to the ViewPager2's orientation inside ViewPager2 works
- Nesting scroll views with a scroll direction parallel to the ViewPager2's orientation inside ViewPager2 does not work
- Nesting scroll views with a scroll direction perpendicular to the ViewPager2's orientation inside ViewPager2 works
- Nesting scroll views with a scroll direction parallel to the ViewPager2's orientation inside ViewPager2 does not work
or...@gmail.com <or...@gmail.com> #5
Horizontal ViewPager2 not correctly working into a vertical RecyclerView
Set a setNestedScrollingEnabled to the RecyclerView into the ViewPager2 (across reflection) resolves the problem
Set a setNestedScrollingEnabled to the RecyclerView into the ViewPager2 (across reflection) resolves the problem
Description
Component used: Navigation
Version used: 2.4.0-beta02
Devices/Android versions reproduced on: Emulator API 23 and 31
Describe the problem:
When navigating to a composable dialog destination, the dialog destination is lost after an orientation change.
Observed Results:
The composable dialog destination is lost after an orientation change
Expected Results:
The composable dialog destination should still be visible after an orientation change
Steps to reproduce:
dialog
Relevant Code:
The composable dialog is defined here:https://github.com/leinardi/Forlago/blob/dialog/modules/feature-foo/src/main/kotlin/com/leinardi/forlago/feature/foo/ui/foodialog/FooDialogScreen.kt#L36
The Dialog destination route is defined here:https://github.com/leinardi/Forlago/blob/dialog/modules/core-navigation/src/main/kotlin/com/leinardi/forlago/core/navigation/destination/foo/FooDialogDestination.kt#L22
The Dialog destinations are added to the NavHost here:https://github.com/leinardi/Forlago/blob/dialog/app/src/main/kotlin/com/leinardi/forlago/ui/MainActivity.kt#L109
Attached there is a short video showing the issue.