Support gaps in lines of lazy grids when the current line does not fit the desired span [207462103]

Fixed

Feature Request

Status Update

No update yet.

Description

po...@google.com

created issue #1

Nov 23, 2021 10:45AM

No description yet.

Comments

sj...@gmail.com <sj...@gmail.com> #2Jan 31, 2022 03:32PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

sj...@gmail.com <sj...@gmail.com> #3Jan 31, 2022 03:56PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

ap...@google.com <ap...@google.com> #4Feb 9, 2022 12:32PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 0cdb26cb2a13f377cc2a9f1b55c0ddccc98c0470
Author: Mihai Popa <popam@google.com>
Date: Mon Feb 07 14:52:37 2022

Support "line breaking" in lazy grids with spans

Relnote: LazyVerticalGrid now supports `line breaking` before items with span not fitting inside the current line.
Fixes: 207462103
Test: LazyGridSpanTest
Change-Id: I05c405c9ccf81fb1682a8f84eb36481d3b13ceea

M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGridSpanLayoutProvider.kt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyGridSpanTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyGridTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyGridSpan.kt

https://android-review.googlesource.com/1974461

io...@gmail.com <io...@gmail.com> #5Jul 16, 2022 11:25AM

starting from which version of compose can I check the fix?

an...@google.com <an...@google.com> #6Jul 18, 2022 11:08AM

It should be available in Compose 1.2

Issue 207462103