AGP 7.2.0-alpha05 breaks builds that use the Navigation Safe Args plugin [207670704]

Fixed

Bug

Status Update

No update yet.

Description

fr...@gmail.com

created issue #1

Nov 25, 2021 03:45AM

Build: AI-212.5457.46.2112.7905983, 202111111328,

AI-212.5457.46.2112.7905983, JRE 11.0.12+0-b1504.28-7817840x64 JetBrains s.r.o., OS Linux(amd64) v5.13.0-21-generic, screens 2560.0x1440.0, 1080.0x1920.0

AS: Chipmunk | 2021.2.1 Canary 5; Kotlin plugin: 212-1.5.31-release-556-AS4638.7; Android Gradle Plugin: 7.0.3; Gradle: 7.2; Gradle JDK: version 13.0.2; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)

Updating Android Gradle Plug-in from 7.2.0-alpha04 to 7.2.0-alpha05 breaks the build as the Safe Args plug-in no longer works.

This project uses AGP 7.2.0-alpha04 and after changing to 7.2.0-alpha05 it fails to build:

https://github.com/fvilarino/Weather-Sample

Stack trace attached.

build_error.txt

21 KB

View

Download

Comments

lu...@google.com <lu...@google.com> Nov 26, 2021 11:06AM

Assigned to an...@google.com.

je...@google.com <je...@google.com> #2Nov 29, 2021 05:37PM

Reassigned to da...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

jb...@google.com <jb...@google.com> #3Nov 30, 2021 05:21PM

Reassigned to je...@google.com.

Safeargs still needs AndroidComponentsExtension to get the applicationID from the variants (https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt;l=73). Did AGP 7.2.0-alpha05 remove the extension?

je...@google.com <je...@google.com> #4Nov 30, 2021 05:24PM

Reassigned to jb...@google.com.

it moved to a different package : com.android.build.api.variant

jb...@google.com <jb...@google.com> #5Nov 30, 2021 08:34PM

Reassigned to je...@google.com.

Safeargs still relies on AGP 4.2. We need some of the BaseVariant APIs to have replacements before we can upgrade to 7.0+ (https://issuetracker.google.com/203557189).

je...@google.com <je...@google.com> #6Dec 1, 2021 05:00PM

Reassigned to jb...@google.com.

The BaseVariant API are deprecated but still available in 7.x, so you should be able to release a newer version that uses the new package and still relies on the old API you require. Or am I missing something ?

jb...@google.com <jb...@google.com> #7Dec 1, 2021 05:53PM

I'll try updating to the latest stable to see if we run into any issues. I can check to make sure changing the package name in 7.2.0-alpha05 works, but we would need it to be stable before we could do a release with this change.

cj...@gmail.com <cj...@gmail.com> #8Dec 14, 2021 04:28AM

FYI this also breaks the latest Studio (2021.1.1 Beta 5)/AGP (7.1.0-beta05) beta where com.android.build.api.extension.AndroidComponentsExtension has been removed.

Is there a particular reason why https://issuetracker.google.com/203557189 and this issues don't have a higher priority?

As it stands, no one can upgrade either AGP/Studio Beta or Canary and take advantage of fixes in the latest versions because Navigation still uses the old AGP APIs.

Message last modified on Dec 14, 2021 01:14PM

ti...@gmail.com <ti...@gmail.com> #9Jan 4, 2022 09:26PM

Was this fixed in Studio 2021.1.1 RC 1?

cj...@gmail.com <cj...@gmail.com> #10Jan 4, 2022 11:35PM

I do not think so https://developer.android.com/studio/releases/fixed-bugs/studio/2021.1.1#android-studio-bumblebee-rc-01-2021.1.1.19.

Pretty disappointing though.

jb...@google.com <jb...@google.com> #11Jan 10, 2022 04:17PM

This will be fixed in the Navigation Safe Args 2.5.0-alpha01 and 2.4.1 versions. You can follow the snapshot instructions and try this out with build id #8054565.

cj...@gmail.com <cj...@gmail.com> #12Jan 10, 2022 04:27PM

Thank you! 2.4.1 is at least two weeks out (possibly 4, if I'm not mistaken).

I applaud the AGPs team decision to stick to the new APIs though. Hopefully its not too long before Navigation fixes this.

ro...@gmail.com <ro...@gmail.com> #13Jan 10, 2022 05:31PM

So we are talking mid february ?

jb...@google.com <jb...@google.com> Jan 11, 2022 10:44PM

Marked as fixed.

de...@google.com <de...@google.com> #14Mar 3, 2022 11:09PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Dolphin Canary 5 (2021.3.1.5)
Android Gradle Plugin 7.3.0-alpha05

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

zo...@gmail.com <zo...@gmail.com> #15May 12, 2022 03:34AM

Is this included in the Dolphin Beta 1 build? 7.3.0-beta01?

I'm able to consistent reproduce this when having the namespace field setup in my gradle file. Removing it (and adding the value back to the Manifest files) does not cause the issue. Not sure if the same case here, or a new one.

ro...@gmail.com <ro...@gmail.com> #16May 12, 2022 04:53AM

May be related to this one ? https://issuetracker.google.com/231704909

xo...@google.com <xo...@google.com> #17May 12, 2022 07:43AM

Right, the direct incompatibility between AGP and Safe Args is fixed, I believe, but there's another issue related to the use of applicationId vs namespace, tracking at http://issuetracker.google.com/232107688. Thanks!