AGP 7.2.0-alpha05 breaks builds that use the Navigation Safe Args plugin [207670704]

Fixed

Bug

Status Update

No update yet.

Description

fr...@gmail.com

created issue #1

Nov 25, 2021 03:45AM

Build: AI-212.5457.46.2112.7905983, 202111111328,

AI-212.5457.46.2112.7905983, JRE 11.0.12+0-b1504.28-7817840x64 JetBrains s.r.o., OS Linux(amd64) v5.13.0-21-generic, screens 2560.0x1440.0, 1080.0x1920.0

AS: Chipmunk | 2021.2.1 Canary 5; Kotlin plugin: 212-1.5.31-release-556-AS4638.7; Android Gradle Plugin: 7.0.3; Gradle: 7.2; Gradle JDK: version 13.0.2; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)

Updating Android Gradle Plug-in from 7.2.0-alpha04 to 7.2.0-alpha05 breaks the build as the Safe Args plug-in no longer works.

This project uses AGP 7.2.0-alpha04 and after changing to 7.2.0-alpha05 it fails to build:

https://github.com/fvilarino/Weather-Sample

Stack trace attached.

build_error.txt

21 KB

View

Download

Comments

lu...@google.com <lu...@google.com> Nov 26, 2021 11:06AM

Assigned to an...@google.com.

je...@google.com <je...@google.com> #2Nov 29, 2021 05:37PM

Reassigned to da...@google.com.

Yigit, do you have time to fix it?

reemission of the same liveData is racy

jb...@google.com <jb...@google.com> #3Nov 30, 2021 05:21PM

Reassigned to je...@google.com.

yea i'll take it.

je...@google.com <je...@google.com> #4Nov 30, 2021 05:24PM

Reassigned to jb...@google.com.

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

jb...@google.com <jb...@google.com> #5Nov 30, 2021 08:34PM

Reassigned to je...@google.com.

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}

je...@google.com <je...@google.com> #6Dec 1, 2021 05:00PM

Reassigned to jb...@google.com.

With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)

jb...@google.com <jb...@google.com> #7Dec 1, 2021 05:53PM

yea sorry immediate does not fix it.
I actually have a WIP fix for it:

https://android-review.googlesource.com/c/platform/frameworks/support/+/1112186

if your case is the one i found (emitting same LiveData multiple times, as shown in #5) you can work around it by adding a dummy transformation.

val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData.map {it })
emitSource(subLiveData.map {it} )
}

cj...@gmail.com <cj...@gmail.com> #8Dec 14, 2021 04:28AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit af12e75e6b4110f48e44ca121466943909de8f06
Author: Yigit Boyar <yboyar@google.com>
Date: Tue Sep 03 12:58:11 2019

Fix coroutine livedata race condition

This CL fixes a bug in liveData builder where emitting same
LiveData source twice would make it crash because the second
emission registry could possibly happen before first one is
removed as source.

We fix it by using a suspending dispose function. It does feel
a bit hacky but we cannot make DisposableHandle.dispose async
and we do not want to block there. This does not mean that there
is a problem if developer disposes it manually since our emit
functions take care of making sure it disposes (and there is
no other way to add source to the underlying MediatorLiveData)

Bug: 140249349
Test: BuildLiveDataTest#raceTest_*

Change-Id: I0b464c242a583da4669af195cf2504e2adc4de40

M lifecycle/lifecycle-livedata-ktx/api/2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-ktx/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata-ktx/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt

https://android-review.googlesource.com/1112186

https://goto.google.com/android-sha1/af12e75e6b4110f48e44ca121466943909de8f06

Message last modified on Dec 14, 2021 01:14PM

ti...@gmail.com <ti...@gmail.com> #9Jan 4, 2022 09:26PM

Was this fixed in Studio 2021.1.1 RC 1?

cj...@gmail.com <cj...@gmail.com> #10Jan 4, 2022 11:35PM

I do not think so https://developer.android.com/studio/releases/fixed-bugs/studio/2021.1.1#android-studio-bumblebee-rc-01-2021.1.1.19.

Pretty disappointing though.

jb...@google.com <jb...@google.com> #11Jan 10, 2022 04:17PM

This will be fixed in the Navigation Safe Args 2.5.0-alpha01 and 2.4.1 versions. You can follow the snapshot instructions and try this out with build id #8054565.

cj...@gmail.com <cj...@gmail.com> #12Jan 10, 2022 04:27PM

Thank you! 2.4.1 is at least two weeks out (possibly 4, if I'm not mistaken).

I applaud the AGPs team decision to stick to the new APIs though. Hopefully its not too long before Navigation fixes this.

ro...@gmail.com <ro...@gmail.com> #13Jan 10, 2022 05:31PM

So we are talking mid february ?

jb...@google.com <jb...@google.com> Jan 11, 2022 10:44PM

Marked as fixed.

de...@google.com <de...@google.com> #14Mar 3, 2022 11:09PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Dolphin Canary 5 (2021.3.1.5)
Android Gradle Plugin 7.3.0-alpha05

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

zo...@gmail.com <zo...@gmail.com> #15May 12, 2022 03:34AM

Is this included in the Dolphin Beta 1 build? 7.3.0-beta01?

I'm able to consistent reproduce this when having the namespace field setup in my gradle file. Removing it (and adding the value back to the Manifest files) does not cause the issue. Not sure if the same case here, or a new one.

ro...@gmail.com <ro...@gmail.com> #16May 12, 2022 04:53AM

May be related to this one ? https://issuetracker.google.com/231704909

xo...@google.com <xo...@google.com> #17May 12, 2022 07:43AM

Right, the direct incompatibility between AGP and Safe Args is fixed, I believe, but there's another issue related to the use of applicationId vs namespace, tracking at http://issuetracker.google.com/232107688. Thanks!