call `getTheme().applyStyle(themeId, true)` after `ResourcesCompat.getColorStateList(...)` return old value [207739887]

Fixed

Bug

adexe s nau

Status Update

No update yet.

Description

Ar...@qq.com

created issue #1

Nov 26, 2021 12:33PM

ResourcesCompat cached ColorStateList( sColorStateCaches ), but do not handle the case of changing the theme.

Comments

al...@google.com <al...@google.com> #2Nov 30, 2021 04:06PM

Reassigned to bu...@google.com.

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

bu...@google.com <bu...@google.com> #3Nov 30, 2021 04:07PM

Accepted by bu...@google.com.

Thanks for the report!

Ar...@qq.com <Ar...@qq.com> #4Dec 1, 2021 01:15AM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

al...@google.com <al...@google.com> #5Dec 1, 2021 02:25PM

Assigned to al...@google.com.

deleted

al...@google.com <al...@google.com> Dec 16, 2021 08:29PM

Accepted by al...@google.com.

al...@google.com <al...@google.com> #6Jan 6, 2022 08:49PM

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

ap...@google.com <ap...@google.com> #7Jan 10, 2022 09:19PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 4f66c0ca1f324426a862a707597573d6bd8c0f01
Author: Alan Viverette <alanv@google.com>
Date: Thu Dec 16 15:28:48 2021

Add workaround method for addressing cache invalidation on SDK < 33

This method is not very discoverable, but it's also pretty niche. Those
who need it will probably find it via StackOverflow or Buganizer.

Relnote: """Added method for working around ColorStateList issues
resulting from Theme-keyed caching and Theme.applyStyle"""
Test: ResourcesCompatTest
Fixes: 207739887
Change-Id: I9188bbf6b182111b3d6d302b81b9a000058687bd

M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/content/res/ResourcesCompat.java
M core/core/api/public_plus_experimental_current.txt
M core/core/src/androidTest/java/androidx/core/content/res/ResourcesCompatTest.java
M core/core/api/current.txt

https://android-review.googlesource.com/1927081