scrollBehavior makes scroll very slow and leggy - SmallTopAppBar - Material Design 3 [207957336]

Fixed

Bug

Status Update

No update yet.

Description

vi...@gmail.com

created issue #1

Nov 28, 2021 11:01PM

val scrollBehavior = remember { TopAppBarDefaults.enterAlwaysScrollBehavior() }

Scaffold(
modifier = Modifier.nestedScroll(scrollBehavior.nestedScrollConnection) // this makes scroll very slow and leggy
){

LazyColumn(
content = {}
)

}

Comments

ro...@gmail.com <ro...@gmail.com> #2Nov 29, 2021 10:39AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ma...@google.com <ma...@google.com> Nov 29, 2021 02:13PM

Assigned to sg...@google.com.

on...@aol.com <on...@aol.com> #3Jul 25, 2022 07:42AM

Is this a LazyColumn/LazyVerticalGrid performance issue?

We've ported the behavior to material (not material3) and whenever LazyColumn's size and position were being adjusted during a scroll, the scrolling was laggy.

We've also tried to make LazyColumn fill the whole screen and adjust its contentPadding instead, but we got the same result. The scrolling was laggy while contentPadding was being adjusted.

Once the bar is collapsed, the performance seems okay again.

We use ExitUntilCollapsedScrollBehavior.

sg...@google.com <sg...@google.com> #4Jul 25, 2022 02:28PM

Are you testing on a debug or a release version of your APK?

on...@aol.com <on...@aol.com> #5Jul 25, 2022 02:34PM

We tried both. It's a bit better in release version but not good enough for production use.

We tested on physical Pixel 3a with API 32.

sg...@google.com <sg...@google.com> #6Jul 25, 2022 03:08PM

Could you provide us with a minimal code that showcase this issue. It can be very helpful!

sg...@google.com <sg...@google.com> #7Mar 19, 2024 11:51PM

Might be related to b/330410290 that I filed for too many recompositions when scrolling content behind single-line app bars.

Will keep this one open for now until the fix is merged and pushed for the next alpha.

ma...@google.com <ma...@google.com> #8Jun 20, 2024 02:25PM

Possibly fixed/duplicated by b/297208851

sg...@google.com <sg...@google.com> #9Nov 15, 2024 01:36AM

Status: Duplicate of

297208851

Agree. This looks like the issue that Mariano resolved there (we had a missing remember at the enterAlwaysScrollBehavior()).

Closing as a duplicate.

The fix should be available at 1.4.0-alpha01.

Message last modified on Nov 15, 2024 01:37AM

sg...@google.com <sg...@google.com> #10Nov 15, 2024 01:39AM

Status: Assigned (reopened)

Oh.. Actually the fix was for exitUntilCollapsedScrollBehavior. Reopening.

sg...@google.com <sg...@google.com> Nov 15, 2024 10:13PM

Accepted by sg...@google.com.

ap...@google.com <ap...@google.com> #11Nov 18, 2024 08:55PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Shalom Gibly <sgibly@google.com>
Link: https://android-review.googlesource.com/3349335

Remember top and bottom app bar behaviors

Expand for full commit details

Remember top and bottom app bar behaviors 
 
Update the exitAlwaysScrollBehavior and pinnedScrollBehavior to be 
remembered across compositions. 
This follows that was previously done at the enterAlwaysScrollBehavior. 
 
Bug: 207957336 
Test: Manual 
Relnote: "Scroll behavior functions for top and bottom app bars now 
return a remembered behavior to perform better across recompositions." 
 
Change-Id: I0fdbe6e2ffb01d97b4c57d3a41a76f8531a2d72a

Files:

M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt

Hash: c41d112fa72e1a0dc445a90cfc83306868c6aa31
Date: Fri Nov 15 14:02:50 2024

sg...@google.com <sg...@google.com> Nov 18, 2024 08:57PM

Marked as fixed.