Fixed

Bug

Status Update

No update yet.

Description

bl...@gmail.com

created issue #1

Dec 2, 2021 11:18AM

Make selection
Clear text
Selection is remembered, but applied on empty string, causing an out of bounds exception

For reproduction, see applied project and demo video screen-20211202-121335.mp4

2021-12-02 12:13:31.581 7566-7566/? E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.example.textfieldapplication, PID: 7566
    java.lang.IllegalArgumentException: offset(6) is out of bounds [0, 0]
        at androidx.compose.ui.text.MultiParagraph.requireIndexInRangeInclusiveEnd(MultiParagraph.kt:593)
        at androidx.compose.ui.text.MultiParagraph.getBidiRunDirection(MultiParagraph.kt:406)
        at androidx.compose.ui.text.TextLayoutResult.getBidiRunDirection(TextLayoutResult.kt:353)
        at androidx.compose.foundation.text.CoreTextFieldKt.SelectionToolbarAndHandles(CoreTextField.kt:817)
        at androidx.compose.foundation.text.CoreTextFieldKt.access$SelectionToolbarAndHandles(CoreTextField.kt:1)
        at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$4$1$1.invoke(CoreTextField.kt:565)
        at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$4$1$1.invoke(CoreTextField.kt:527)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:107)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)
        at androidx.compose.foundation.text.selection.SimpleLayoutKt.SimpleLayout(SimpleLayout.kt:79)
        at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$4$1.invoke(CoreTextField.kt:527)
        at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$4$1.invoke(CoreTextField.kt:510)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:107)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)
        at androidx.compose.material.TextFieldKt.IconsWithTextFieldLayout-SxpAMN0(TextField.kt:443)
        at androidx.compose.material.TextFieldKt.access$IconsWithTextFieldLayout-SxpAMN0(TextField.kt:1)
        at androidx.compose.material.TextFieldKt$TextFieldLayout$1.invoke(TextField.kt:369)
        at androidx.compose.material.TextFieldKt$TextFieldLayout$1.invoke(TextField.kt:367)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:116)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)
        at androidx.compose.foundation.text.CoreTextFieldKt.CoreTextField(CoreTextField.kt:510)
        at androidx.compose.foundation.text.BasicTextFieldKt.BasicTextField(BasicTextField.kt:262)
        at androidx.compose.material.TextFieldKt.TextFieldLayout-uBqXD2s(TextField.kt:347)
        at androidx.compose.material.TextFieldImplKt$TextFieldImpl$3.invoke-h1eT-Ww(TextFieldImpl.kt:178)
        at androidx.compose.material.TextFieldImplKt$TextFieldImpl$3.invoke(TextFieldImpl.kt:129)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:214)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)
        at androidx.compose.material.TextFieldTransitionScope.Transition-DTcfvLk(TextFieldImpl.kt:357)
        at androidx.compose.material.TextFieldImplKt.TextFieldImpl(TextFieldImpl.kt:119)
        at androidx.compose.material.TextFieldKt.TextField(TextField.kt:295)
        at androidx.compose.material.TextFieldKt.TextField(TextField.kt:180)
        at com.example.textfieldapplication.MainActivityKt.MyTextField(MainActivity.kt:77)
        at com.example.textfieldapplication.MainActivityKt.TxtField(MainActivity.kt:48)
        at com.example.textfieldapplication.MainActivityKt.access$TxtField(MainActivity.kt:1)
        at com.example.textfieldapplication.ComposableSingletons$MainActivityKt$lambda-1$1.invoke(MainActivity.kt:34)
        at com.example.textfieldapplication.ComposableSingletons$MainActivityKt$lambda-1$1.invoke(MainActivity.kt:31)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:107)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)
        at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.kt:140)
        at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:2158)
        at androidx.compose.runtime.ComposerImpl.skipCurrentGroup(Composer.kt:2404)
        at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:2585)
2021-12-02 12:13:31.584 7566-7566/? E/AndroidRuntime:     at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:2571)
        at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:247)
        at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
        at androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:2571)
        at androidx.compose.runtime.ComposerImpl.recompose$runtime_release(Composer.kt:2547)
        at androidx.compose.runtime.CompositionImpl.recompose(Composition.kt:620)
        at androidx.compose.runtime.Recomposer.performRecompose(Recomposer.kt:786)
        at androidx.compose.runtime.Recomposer.access$performRecompose(Recomposer.kt:105)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:456)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:425)
        at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:34)
        at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:109)
        at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
        at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:972)
        at android.view.Choreographer.doCallbacks(Choreographer.java:797)
        at android.view.Choreographer.doFrame(Choreographer.java:728)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:959)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:223)
        at android.app.ActivityThread.main(ActivityThread.java:7700)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:612)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:997)

screen-20211202-121335.mp4

1.4 MB

Download

crashing-text-view-project.zip

54 KB

Download

Comments

ch...@google.com <ch...@google.com> Dec 3, 2021 05:59PM

Assigned to si...@google.com.

si...@google.com <si...@google.com> Dec 3, 2021 06:02PM

Reassigned to an...@google.com.

so...@google.com <so...@google.com> Feb 3, 2022 04:38PM

Reassigned to so...@google.com.

si...@google.com <si...@google.com> #2Feb 9, 2022 09:12AM

Some new information? This issue is already over a year old, it was just shifted, and the new ticket here seems to be ignored. This should have a higher Priority then P3.

I feel like this is a serious issue that should get more attention. When working with RecyclerViews you had the possibility of setting up if a ViewHolder is able the be recycled.

All the solutions to circumvent this problem here are either hacks in regards to how the Keyboard is opened, or you ditch LazyColumn completely and use a Column, which is not a solution for complex layouts.

so...@google.com <so...@google.com> #3Mar 18, 2022 03:59PM

Reassigned to an...@google.com.

1.2.0-beta02 it still remains

ha...@google.com <ha...@google.com> Jun 21, 2022 04:18PM

Reassigned to ha...@google.com.

kl...@google.com <kl...@google.com> #4Jun 21, 2022 04:26PM

and cause the other focusable element could not access touch

ha...@google.com <ha...@google.com> #5Jun 23, 2022 12:49PM

We should have some API to pin an item to indicate that we want to keep it around and not dispose it.

Please don't make this API internal, make it public for everyone to use and also allow this API to be used with any kind of items inside of LazyLayout's (not only focusable items). I have described why I need it in this issue https://issuetracker.google.com/issues/236279213 Thanks.

ap...@google.com <ap...@google.com> #6Jun 27, 2022 11:21AM

Marked as fixed.

Related in spirit:

STOP MAKING ALL USEFUL APIS INTERNAL

IssueTracker

Crash when text is cleared while selection is active

Status Update

Description

Comments

ch...@google.com <ch...@google.com> Dec 3, 2021 05:59PM

si...@google.com <si...@google.com> Dec 3, 2021 06:02PM

so...@google.com <so...@google.com> Feb 3, 2022 04:38PM

si...@google.com <si...@google.com> #2Feb 9, 2022 09:12AM

so...@google.com <so...@google.com> #3Mar 18, 2022 03:59PM

ha...@google.com <ha...@google.com> Jun 21, 2022 04:18PM

kl...@google.com <kl...@google.com> #4Jun 21, 2022 04:26PM

ha...@google.com <ha...@google.com> #5Jun 23, 2022 12:49PM

ap...@google.com <ap...@google.com> #6Jun 27, 2022 11:21AM

STOP MAKING ALL USEFUL APIS INTERNAL

Issue 208655565

Description

Issue summary

Comments

ch...@google.com <ch...@google.com> Dec 3, 2021 05:59PM

si...@google.com <si...@google.com> Dec 3, 2021 06:02PM

so...@google.com <so...@google.com> Feb 3, 2022 04:38PM

si...@google.com <si...@google.com> #2Feb 9, 2022 09:12AM

so...@google.com <so...@google.com> #3Mar 18, 2022 03:59PM

ha...@google.com <ha...@google.com> Jun 21, 2022 04:18PM

kl...@google.com <kl...@google.com> #4Jun 21, 2022 04:26PM

ha...@google.com <ha...@google.com> #5Jun 23, 2022 12:49PM

ap...@google.com <ap...@google.com> #6Jun 27, 2022 11:21AM

STOP MAKING ALL USEFUL APIS INTERNAL

Add comment

Issue metadata