WorkManager Kotlinification [209145335]

Feature Request

Status Update

No update yet.

Description

se...@google.com

created issue #1

Dec 4, 2021 04:51PM

No description yet.

Comments

ap...@google.com <ap...@google.com> #2Dec 6, 2021 06:36PM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

ap...@google.com <ap...@google.com> #3Dec 6, 2021 06:55PM

yea i'll take it.

ap...@google.com <ap...@google.com> #4Dec 6, 2021 11:29PM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

ap...@google.com <ap...@google.com> #5Dec 6, 2021 11:29PM

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}

ap...@google.com <ap...@google.com> #6Dec 7, 2021 12:04AM

With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)

ap...@google.com <ap...@google.com> #7Dec 7, 2021 12:04AM

yea sorry immediate does not fix it.
I actually have a WIP fix for it:

https://android-review.googlesource.com/c/platform/frameworks/support/+/1112186

if your case is the one i found (emitting same LiveData multiple times, as shown in #5) you can work around it by adding a dummy transformation.

val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData.map {it })
emitSource(subLiveData.map {it} )
}

ap...@google.com <ap...@google.com> #8Dec 7, 2021 12:04AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit af12e75e6b4110f48e44ca121466943909de8f06
Author: Yigit Boyar <yboyar@google.com>
Date: Tue Sep 03 12:58:11 2019

Fix coroutine livedata race condition

This CL fixes a bug in liveData builder where emitting same
LiveData source twice would make it crash because the second
emission registry could possibly happen before first one is
removed as source.

We fix it by using a suspending dispose function. It does feel
a bit hacky but we cannot make DisposableHandle.dispose async
and we do not want to block there. This does not mean that there
is a problem if developer disposes it manually since our emit
functions take care of making sure it disposes (and there is
no other way to add source to the underlying MediatorLiveData)

Bug: 140249349
Test: BuildLiveDataTest#raceTest_*

Change-Id: I0b464c242a583da4669af195cf2504e2adc4de40

M lifecycle/lifecycle-livedata-ktx/api/2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-ktx/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata-ktx/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt

https://android-review.googlesource.com/1112186

https://goto.google.com/android-sha1/af12e75e6b4110f48e44ca121466943909de8f06

ap...@google.com <ap...@google.com> #9Dec 7, 2021 12:04AM

Project: platform/frameworks/support
Branch: androidx-main

commit 744c74c4609d854c3286264bda8a9645815073f7
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 17:07:28 2021

Rename *Dao.java to *Dao.kt

bug: 209145335
Test: NA
Change-Id: I9a712fa0c0ffbe2a09b5faed9f39737f47106d1d

M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTagDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkNameDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/DependencyDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/PreferenceDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfoDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/RawWorkInfoDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkProgressDao.kt

https://android-review.googlesource.com/1910056

ap...@google.com <ap...@google.com> #10Dec 7, 2021 02:41AM

Project: platform/frameworks/support
Branch: androidx-main

commit eb75eadc68ba555ca18e1ccdf6c576dcbcdc1cfa
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Dec 06 18:27:24 2021

Scope Trackers to WorkManagerImpl

It removes singleton, so we don't need
getInstance() / setInstance for testing purposes.

bug: 209145335
Test: refactoring
Change-Id: Ic9410f9679ff20d9c89bf4e01204f6c9d4de29cb

M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkConnectedController.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/Trackers.java
M work/work-testing/src/main/java/androidx/work/testing/TestWorkManagerImpl.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkMeteredController.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/ConstraintsCommandHandler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkNotRoamingController.java
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/BatteryChargingController.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/StorageNotLowController.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplLargeExecutorTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/workers/ConstraintTrackingWorker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/BatteryNotLowController.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkUnmeteredController.java

https://android-review.googlesource.com/1911870

ap...@google.com <ap...@google.com> #11Dec 9, 2021 12:37AM

Project: platform/frameworks/support
Branch: androidx-main

commit 4799ddb8ec61f4b67c0f6915417d74ed5fb86d6e
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Wed Dec 08 16:32:58 2021

Migrate constrain controllers to kotlin

Had to rewrite WorkConstraintsTrackerTest, because
it didn't work well with kotlin: mocking final methods,
passing nulls where non-null types are required etc.

bug: 209145335
Test: refactoring
Change-Id: I4099251a521294b51e332620124167b0ef5f1e31

A work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ContraintControllers.kt
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkConnectedController.java
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkMeteredController.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/controllers/ConstraintControllerTest.java
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkNotRoamingController.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/ConstraintTracker.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.kt
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/BatteryChargingController.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.kt
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/StorageNotLowController.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/BatteryNotLowController.java
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkUnmeteredController.java

https://android-review.googlesource.com/1914848

ap...@google.com <ap...@google.com> #12Dec 9, 2021 12:37AM

Project: platform/frameworks/support
Branch: androidx-main

commit 73b240acd36c20d0d4fc7ed884608c422d5a186a
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Tue Dec 07 12:18:53 2021

Rename ConstraintController.java to ConstraintController.kt

bug: 209145335
Test: NA
Change-Id: Iaa777fb5788040a7005b1eaa898192c76ba56038

M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.kt

https://android-review.googlesource.com/1914847

ap...@google.com <ap...@google.com> #13Dec 9, 2021 12:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit 856d077b335d38bec5edf93d1c54aa8fa6d9456d
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Tue Dec 07 02:26:53 2021

Migrate WorkDatabase and related classes to Kotlin

bug: 209145335
Test: refactoring
Change-Id: Ibf78b03ee78e01f2c5921a6a3844cb62d05b41f1

M work/work-runtime/build.gradle
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerInitializationTest.kt
A work/work-runtime/src/main/java/androidx/work/impl/package-info.java
M work/work-runtime/src/main/java/androidx/work/impl/utils/IdGenerator.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabase.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTypeConverters.kt
M work/work-runtime/src/androidTest/java/androidx/work/WorkDatabasePathHelperTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabasePathHelper.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/PreferenceUtils.java
M work/work-runtime/src/androidTest/java/androidx/work/WorkDatabaseMigrationTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabaseMigrations.kt

https://android-review.googlesource.com/1911876

ap...@google.com <ap...@google.com> #14Dec 9, 2021 12:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0abc512e24adb1b637f9b9d2215b588b6bbd8bd3
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Dec 06 22:37:34 2021

Rename WorkDatabase and related classes from *.java to *.kt

bug: 209145335
Test: NA
Change-Id: I903fb03852bfe1815ec06f2ad2062c2827a354f1

M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabaseMigrations.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabase.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTypeConverters.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabasePathHelper.kt

https://android-review.googlesource.com/1911875

ap...@google.com <ap...@google.com> #15Dec 14, 2021 12:02PM

Project: platform/frameworks/support
Branch: androidx-main

commit 47cb7829960ffc9e81d725bf543a01bd9cb4d4f3
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Dec 09 01:25:41 2021

Remove unused TaskExecutor.postToMainThread method

bug: 209145335
Test: refactoring. test passes
Change-Id: I8fd0c81b160fabd11800fdfcb0151d947ec02329

M work/work-testing/src/main/java/androidx/work/testing/TestWorkManagerImpl.java
M work/work-rxjava2/src/test/java/androidx/work/RxWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/utils/taskexecutor/InstantWorkTaskExecutor.java
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/RxWorkerTest.kt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/ParcelableWorkContinuationImplTest.kt
M work/work-runtime-ktx/src/androidTest/java/androidx/work/CoroutineWorkerTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/taskexecutor/WorkManagerTaskExecutor.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ControlledWorkerWrapperTest.kt
M work/work-gcm/src/androidTest/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcherTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/WorkerWrapperForegroundTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/taskexecutor/TaskExecutor.java
M work/work-testing/src/main/java/androidx/work/testing/InstantWorkTaskExecutor.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTests.kt
M work/work-benchmark/src/androidTest/java/androidx/work/benchmark/InitializeBenchmark.kt

https://android-review.googlesource.com/1914854

ap...@google.com <ap...@google.com> #16Dec 18, 2021 01:11PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6cc495a6e4c4cf55bfdde2bca636b3f70122a00b
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Wed Dec 08 21:02:10 2021

Migrate Trackers to Kotlin

bug: 209145335
Test: refactoring. test passes
Change-Id: I991fbdf52ebb26fdaeb9f4077da1456fa9442a6d

M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ContraintControllers.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryChargingTrackerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryNotLowTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/ConstraintTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/NetworkStateTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryChargingTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BroadcastReceiverConstraintTracker.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/StorageNotLowTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/StorageNotLowTracker.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/controllers/ConstraintControllerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/NetworkStateTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryNotLowTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/Trackers.kt

https://android-review.googlesource.com/1914853

ap...@google.com <ap...@google.com> #17Dec 18, 2021 01:11PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5f7696d770c157aa50966b15cf0aa8abc1645cb6
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Wed Dec 08 19:09:23 2021

Rename top-level *.java to *.kt in androidx.work.impl.constraints.trackers

bug: 209145335
Test: NA
Change-Id: I4eb47369a0eab03ea248fcd143c037f8e8bf973d

M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/StorageNotLowTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/ConstraintTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/NetworkStateTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryChargingTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BroadcastReceiverConstraintTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryNotLowTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/Trackers.kt

https://android-review.googlesource.com/1914852

ap...@google.com <ap...@google.com> #18Jan 7, 2022 06:52PM

Project: platform/frameworks/support
Branch: androidx-main

commit 223a4c0ae815f9a17cde65025662fb61e94e4c93
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Jan 06 18:55:05 2022

Clean up lint-baseline for files that were migrated to Kotlin

bug: 209145335
Test: NA
Change-Id: Ic7eb4592ce803880ae888df208811876e6116cf0
Merged-In: Ic2cd6b2bfafbd704e0b0adc5f25477ac566d6b82

M work/work-runtime/lint-baseline.xml

https://android-review.googlesource.com/1938783

ap...@google.com <ap...@google.com> #19Mar 28, 2022 06:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit 61aca7b33219167a7976251f9db6a7cff6b5c3e0
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Mar 28 00:55:03 2022

Migrate IdGenerator to Kotlin

bug: 209145335
Test: N/A
Change-Id: If56685618430df3c0b923aa439cf5c45acf66e1a

M work/work-runtime/build.gradle
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemjob/SystemJobSchedulerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabaseMigrations.kt
M work/work-runtime/src/main/java/androidx/work/Configuration.java
M work/work-runtime/src/main/java/androidx/work/impl/utils/IdGenerator.kt
M work/work-runtime/src/androidTest/java/androidx/work/WorkDatabaseMigrationTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/utils/IdGeneratorTest.java

https://android-review.googlesource.com/2046226

ap...@google.com <ap...@google.com> #20Mar 28, 2022 06:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit 63850bba5f6f19cf6a64b207b770eeac41fd4df7
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sun Mar 27 22:34:44 2022

Rename IdGenerator.java to IdGenerator.kt

bug: 209145335
Test: N/A
Change-Id: Idc5b65dbbf27f1d004942019dc6ef68bbc8775b0

M work/work-runtime/src/main/java/androidx/work/impl/utils/IdGenerator.kt

https://android-review.googlesource.com/2046225

ap...@google.com <ap...@google.com> #21Mar 28, 2022 06:42PM

Project: platform/frameworks/support
Branch: androidx-main

commit 68f7ab6507dc62dcb10b9c834729a0303ab754ad
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sun Mar 27 22:23:15 2022

Migrate RawQueries to Kotlin

bug: 209145335
Test: refactoring
Change-Id: Id17aee5dff51a61125a9ac58137d57787da582ee

M work/work-runtime/src/main/java/androidx/work/impl/utils/StatusRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/androidTest/java/androidx/work/RawWorkInfoDaoTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/RawQueries.kt

https://android-review.googlesource.com/2046224

ap...@google.com <ap...@google.com> #22Mar 28, 2022 06:42PM

Project: platform/frameworks/support
Branch: androidx-main

commit 75488088de77563bfa4c6b87b2892836b3677e71
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sun Mar 27 21:45:25 2022

Rename RawQueries.java -> RawQueries.kt

bug: 209145335
Test: N/A
Change-Id: Ie0de07b50025666125dbc76bb9494c7837099083

M work/work-runtime/src/main/java/androidx/work/impl/utils/RawQueries.kt

https://android-review.googlesource.com/2046223

ap...@google.com <ap...@google.com> #23Apr 4, 2022 04:37PM

Project: platform/frameworks/support
Branch: androidx-main

commit 1c3934aedfbb9042647a23bcfebd10ffd0fb4e87
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sun Apr 03 15:26:16 2022

Migrate WakeLocks to Kotlin

bug: 209145335
Test: N/A
Change-Id: I70f530d8ca6a7e6cb6e3edbf17fdf61122dd2230

M work/work-runtime/src/main/java/androidx/work/impl/utils/WakeLocks.kt

https://android-review.googlesource.com/2051398

ap...@google.com <ap...@google.com> #24Apr 4, 2022 04:37PM

Project: platform/frameworks/support
Branch: androidx-main

commit c53166d074705ac2550c86f3b76b458c4c65e9e7
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sun Apr 03 14:39:28 2022

Rename WakeLocks.java to WakeLocks.kt

bug: 209145335
Test: N/A
Change-Id: I3b6e5fd5b6f447a6e16bc6258e32ea15bb7a36a9

M work/work-runtime/src/main/java/androidx/work/impl/utils/WakeLocks.kt

https://android-review.googlesource.com/2051397

ap...@google.com <ap...@google.com> #25Apr 4, 2022 04:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2a18c0310f30aab5e749ddfb03cd00a38fc16a54
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Apr 01 23:24:31 2022

Move inline helpers for OneTimeWorkRequest & PeriodicWorkRequest

work-runtime-ktx -> work-runtime

bug: 209145335
Test: refactoring
Relnote: "Inline helpers for OneTimeWorkRequest & PeriodicWorkRequest were
moved from `androidx.work:work-runtime-ktx` to `androidx.work:work-runtime`"

Change-Id: I0010f0bc806318ad840550458d872c12ee60eae7

M work/work-runtime-ktx/api/current.txt
M work/work-runtime-ktx/api/restricted_current.txt
M work/work-runtime-ktx/api/current.ignore
M work/work-runtime-ktx/api/public_plus_experimental_current.txt
D work/work-runtime-ktx/src/main/java/androidx/work/PeriodicWorkRequest.kt
M work/work-runtime-ktx/api/api_lint.ignore
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/api/current.txt
M work/work-runtime/api/restricted_current.txt
M work/work-runtime/src/main/java/androidx/work/OneTimeWorkRequest.kt
M work/work-runtime-ktx/api/restricted_current.ignore
M work/work-runtime/src/main/java/androidx/work/PeriodicWorkRequest.kt
D work/work-runtime-ktx/src/main/java/androidx/work/OneTimeWorkRequest.kt
M work/work-runtime/api/api_lint.ignore

https://android-review.googlesource.com/2052910

ap...@google.com <ap...@google.com> #26Apr 4, 2022 04:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit 79a471d7d4788be5c5e73929daf02a5736f26f43
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Apr 01 23:00:59 2022

Migrate WorkRequest to Kotlin

Relnote: N/A
bug: 209145335
Test: refactoring
Change-Id: If78a3dc9007ca6b84c3f954c54fb14a2de58ddf7

M work/work-runtime/api/restricted_current.txt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
M work/work-runtime/src/main/java/androidx/work/OneTimeWorkRequest.kt
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/api/restricted_current.ignore
M work/work-runtime/src/main/java/androidx/work/PeriodicWorkRequest.kt
M work/work-runtime/api/current.ignore
M work/work-runtime/api/current.txt
M work/work-runtime/src/main/java/androidx/work/WorkRequest.kt

https://android-review.googlesource.com/2052909

ap...@google.com <ap...@google.com> #27Apr 4, 2022 04:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit a5ab3d2c4682bc7d40d618c60b7962509e4dde52
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Apr 01 18:16:03 2022

Rename *Request.java -> *Request.kt

bug: 209145335
Test: refactoring
Change-Id: Idff67d592f5252d8707c51561377d4fabfff45d8

M work/work-runtime/src/main/java/androidx/work/OneTimeWorkRequest.kt
M work/work-runtime/src/main/java/androidx/work/PeriodicWorkRequest.kt
M work/work-runtime/src/main/java/androidx/work/WorkRequest.kt

https://android-review.googlesource.com/2052908

ap...@google.com <ap...@google.com> #28Apr 4, 2022 04:57PM

Project: platform/frameworks/support
Branch: androidx-main

commit a4d9af457492b81e038923dc224de465d5050946
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Apr 02 11:55:40 2022

Migrate ProcessUtils to kotlin

bug: 209145335
Test: refactoring
Change-Id: If2d46362ab20338230e4ace5680d354e2677b00f

M work/work-runtime/src/main/java/androidx/work/impl/utils/ProcessUtils.kt

https://android-review.googlesource.com/2053546

ap...@google.com <ap...@google.com> #29Apr 4, 2022 04:57PM

Project: platform/frameworks/support
Branch: androidx-main

commit f63f7fac9dda108333cf515b3fbc6889e7ef01df
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Apr 02 01:18:44 2022

Rename ProcessUtils.java to ProcessUtils.kt

bug: 209145335
Test: refactoring
Change-Id: I2472414bb76a8b00a820b6a5762b18d20607bba0

M work/work-runtime/src/main/java/androidx/work/impl/utils/ProcessUtils.kt

https://android-review.googlesource.com/2053545

ap...@google.com <ap...@google.com> #30Apr 4, 2022 05:41PM

Project: platform/frameworks/support
Branch: androidx-main

commit 913bf47276f789914bb04fde4cb2fd4fe5886d8a
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sun Apr 03 14:15:49 2022

Migrate *Worker to Kotlin

bug: 209145335
Test: N/A
Change-Id: I26be62e34a7eb0558573c827368efd068fe12265

M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/MainActivity.java
M work/work-runtime/src/main/java/androidx/work/impl/workers/CombineContinuationsWorker.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/workers/ConstraintTrackingWorker.kt
M work/work-runtime/src/main/java/androidx/work/impl/workers/DiagnosticsWorker.kt

https://android-review.googlesource.com/2051396

ap...@google.com <ap...@google.com> #31Apr 4, 2022 05:41PM

Project: platform/frameworks/support
Branch: androidx-main

commit e369a7b6f545d4cc88e6d215124d6629e404d91d
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Apr 02 15:20:18 2022

Rename *Worker.java to *Worker.kt

bug: 209145335
Test: N/A
Change-Id: I2db19d9c049c13af79faf5954be41f453c1e0575

M work/work-runtime/src/main/java/androidx/work/impl/workers/CombineContinuationsWorker.kt
M work/work-runtime/src/main/java/androidx/work/impl/workers/ConstraintTrackingWorker.kt
M work/work-runtime/src/main/java/androidx/work/impl/workers/DiagnosticsWorker.kt

https://android-review.googlesource.com/2051395

ap...@google.com <ap...@google.com> #32Nov 17, 2022 11:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit e35e0843068e2e2058eb96570aa867cac0853afa
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Oct 17 15:12:50 2022

Migrate WorkInfo to Kotlin

bug: 209145335
Test: refactoring
Relnote: N/A
Change-Id: I1832d68d2f415bf0051904a31785a892cc872fde

M libraryversions.toml
A work/work-runtime/api/current.ignore
M work/work-runtime/api/current.txt
M work/work-runtime/api/public_plus_experimental_current.txt
A work/work-runtime/api/restricted_current.ignore
M work/work-runtime/api/restricted_current.txt
M work/work-runtime/src/main/java/androidx/work/WorkInfo.kt

https://android-review.googlesource.com/2257284

ap...@google.com <ap...@google.com> #33Nov 17, 2022 11:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit f328aaebd16d13e533e2866b6f2f51cdf4488360
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Oct 17 14:49:07 2022

Move WorkInfo.java to .Kt

bug: 209145335
Test: NA
Change-Id: Idff216c9b296edd8eaf7639dc7ef04ef3fa3606c

M work/work-runtime/src/main/java/androidx/work/WorkInfo.kt

https://android-review.googlesource.com/2257283

ap...@google.com <ap...@google.com> #34Nov 29, 2022 03:08PM

Project: platform/frameworks/support
Branch: androidx-main

commit 16046a2181271f9727126e17ab55ee634bf633a6
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Nov 25 22:09:48 2022

Move InputMerger related code to Kotlin

Relnote: N/A
bug: 209145335
Test: refactoring
Change-Id: I31f80efa33fe1d1eead027bc01a805f5365f9524

M work/work-runtime/api/current.txt
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/api/restricted_current.txt
M work/work-runtime/src/main/java/androidx/work/Configuration.java
M work/work-runtime/src/main/java/androidx/work/InputMerger.kt
M work/work-runtime/src/main/java/androidx/work/InputMergerFactory.kt
M work/work-runtime/src/main/java/androidx/work/OneTimeWorkRequest.kt
M work/work-runtime/src/main/java/androidx/work/OverwritingInputMerger.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabase.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
A work/work-runtime/src/schemas/androidx.work.impl.WorkDatabase/17.json
M work/work-testing/src/androidTest/java/androidx/work/testing/WorkManagerInitHelperTest.java

https://android-review.googlesource.com/2319090

ap...@google.com <ap...@google.com> #35Nov 29, 2022 03:08PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3f1aad9c6869839b7b0b8caba8d9d6ac6d85115b
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Nov 25 21:24:53 2022

Move InputMerger related classes to *.kt

bug: 209145335
Test: NA
Change-Id: I7e27178402b28ba543cd0c752c4aec179a5d7f49

M work/work-runtime/src/main/java/androidx/work/InputMerger.kt
M work/work-runtime/src/main/java/androidx/work/InputMergerFactory.kt
M work/work-runtime/src/main/java/androidx/work/OverwritingInputMerger.kt

https://android-review.googlesource.com/2319089

ap...@google.com <ap...@google.com> #36Nov 29, 2022 03:09PM

Project: platform/frameworks/support
Branch: androidx-main

commit cb73f5d95e0531a419d2bc14d075c3eb35e9bb8c
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Oct 17 16:10:28 2022

Make WorkInfo constructor public

bug: 209145335
Test: refactoring
Relnote: "WorkInfo's constructor is public now,
that can useful in testing."

Change-Id: Ia00b6beffca0b0b2dff5cdae67020bbd4b068579

M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/ParcelableWorkInfoTest.kt
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/parcelable/ParcelableWorkInfo.java
M work/work-runtime/api/current.txt
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/api/restricted_current.txt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/main/java/androidx/work/WorkInfo.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
M work/work-runtime/src/test/java/androidx/work/WorkInfoTest.kt

https://android-review.googlesource.com/2257230

ap...@google.com <ap...@google.com> #37Feb 3, 2023 12:20PM

Project: platform/frameworks/support
Branch: androidx-main

commit f20e994d97815fa9f2310d99d84f6f2bd039d0a3
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Nov 26 00:51:36 2022

Move Configuration to kotlin

bug: 209145335
Test: refactoring
Relnote: N/A
Change-Id: I640fc5e07460ee3504f2243e689187e43d52c42b

M work/work-inspection/src/androidTest/java/androidx/work/inspection/InspectorApp.kt
M work/work-runtime/api/current.ignore
M work/work-runtime/api/current.txt
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/api/restricted_current.ignore
M work/work-runtime/api/restricted_current.txt
M work/work-runtime/src/androidTest/java/androidx/work/WorkForegroundRunnableTest.kt
M work/work-runtime/src/main/java/androidx/work/Configuration.kt
M work/work-runtime/src/main/java/androidx/work/InputMergerFactory.kt

https://android-review.googlesource.com/2318794

ap...@google.com <ap...@google.com> #38Feb 3, 2023 12:20PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0704c05f12bd248d59b5db9f78638bc78739881a
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Nov 25 23:56:45 2022

Move Configuration.java to Configuration.kt

bug: 209145335
Test: NA
Change-Id: If7413a874f286f1d1488336e7011d42188342a0b

M work/work-runtime/src/main/java/androidx/work/Configuration.kt

https://android-review.googlesource.com/2318793

ap...@google.com <ap...@google.com> #39Feb 3, 2023 03:38PM

Project: platform/frameworks/support
Branch: androidx-main

commit fcf6647776e53ef7c97339bc388b1d70336f51a9
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Feb 03 14:56:22 2023

Migrate StartWorkRunnable & StopWorkRunnable to Kotlin

As a drive by use Processor directly in those runnables.

bug: 209145335
Test: ./gradlew :work:work-runtime:cC
Change-Id: I44d6dca55298c98026e1bdd75faf214ee7bacddb

M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/impl/utils/StartWorkRunnable.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/StopWorkRunnable.kt

https://android-review.googlesource.com/2419666

ap...@google.com <ap...@google.com> #40Feb 3, 2023 03:38PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9651c996b5689c1b1ed1267447759bd816f878bc
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Feb 03 14:41:21 2023

Move StartWorkRunnable & StopWorkRunnable from .java to .kt

bug: 209145335
Test: NA
Change-Id: I41f0e9b82c786bfa4118f92564ab7f3c17307dd5

M work/work-runtime/src/main/java/androidx/work/impl/utils/StartWorkRunnable.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/StopWorkRunnable.kt

https://android-review.googlesource.com/2419665

is...@google.com <is...@google.com> Oct 7, 2024 09:05AM

Status: New