Add Compose-observable State<Lifecycle.State> for current Lifecycle state [209684871]

Fixed

Feature Request

Status Update

No update yet.

Description

va...@google.com

created issue #1

Dec 7, 2021 11:27PM

We can observe Lifecycle changes in a few different ways, but with Compose the most natural way would be via a State<Lifecycle.State>, which would make the current Lifecycle.State automatically observable to Compose.

Comments

il...@google.com <il...@google.com> #2Dec 7, 2021 11:42PM

The only currently supported strategy for adding Fragments to compose is via AndroidViewBinding. Are you familiar with this approach?

va...@google.com <va...@google.com> #3Dec 8, 2021 12:34AM

Yes, I am familiar with AndroidViewBinding, however, as far as I know it has some limitations, like, I can't decide at runtime what fragment to commit.

il...@google.com <il...@google.com> #4Dec 9, 2021 12:15AM

I also can't give parameters to the fragment being inflated.

ra...@gmail.com <ra...@gmail.com> #5Dec 24, 2021 04:23AM

Project: platform/frameworks/support
Branch: androidx-main

commit ffe9335a155bf0dea9c3558e50da01d526579040
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Mar 26 20:24:54 2024

Create AndroidFragment to allow adding fragments in Compose

Adding new AndroidFragment API that creates the given Fragment class and
adds it to the enclosing FragmentManager, within Compose.

It handles setting the ViewCompositionStrategy and saving the state of
the fragment across recompositions.

RelNote: "The new AndroidFragment Composable allows adding fragments
into the Compose hierarchy via the fragment class name."
Test: added AndroidFragmentTest
Bug: 230126482
Bug: 312895363

Change-Id: Icf84199bbe487b2a2b6a95d2b6e09415f810e77a

M docs-tip-of-tree/build.gradle
M fragment/fragment-compose/api/current.txt
M fragment/fragment-compose/api/restricted_current.txt
M fragment/fragment-compose/build.gradle
A fragment/fragment-compose/samples/build.gradle
A fragment/fragment-compose/samples/src/main/java/androidx/fragment/compose/samples/FragmentComposeSamples.kt
M fragment/fragment-compose/src/androidTest/AndroidManifest.xml
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/AndroidFragmentTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/FragmentRecreateTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/FragmentRemoveTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/SimpleEditTextFragment.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/test/EmptyTestActivity.kt
A fragment/fragment-compose/src/androidTest/res/layout/content.xml
A fragment/fragment-compose/src/androidTest/res/layout/sample_edit_test_layout.xml
A fragment/fragment-compose/src/main/java/androidx/fragment/compose/AndroidFragment.kt
A fragment/fragment-compose/src/main/java/androidx/fragment/compose/FragmentState.kt
M fragment/fragment/api/current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransaction.java
M settings.gradle

https://android-review.googlesource.com/2989182

il...@google.com <il...@google.com> Sep 12, 2022 11:53PM

Assigned to sa...@google.com.

sa...@google.com <sa...@google.com> Mar 14, 2023 08:18PM

Accepted by sa...@google.com.

ap...@google.com <ap...@google.com> #6Mar 15, 2023 11:08PM

Marked as fixed.

Hey, Thanks to checking this out, I just checked this sample in the the repository, but this does not solve my issue.

I don't have access to the actual fragment class, we use an abstraction that just returns me a instance of Fragment with the arguments set, so this won't solve the issue for me, would it be possible to allow passing the Fragment instance ?

na...@google.com <na...@google.com> #7Jul 26, 2023 05:21PM

Re comment#6 - no. AndroidFragment uses the FragmentFactory you've set on your FragmentManager to instantiate fragment instances, ensuring that every construction of the fragment, from the initial one to the one after process death and recreation all go through the same route.

This aligns with other fragment based APIs like FragmentScenario and NavHostFragment. You'll want to adjust your own abstraction to use those APIs and separate the creation of the fragment instance from the arguments.