Fixed
Status Update
Comments
il...@google.com <il...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
va...@google.com <va...@google.com> #3
il...@google.com <il...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ra...@gmail.com <ra...@gmail.com> #5
Todo bien
il...@google.com <il...@google.com>
sa...@google.com <sa...@google.com>
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit b75b447af3d27aed4b4bc5a826e6e92cd0aaff34
Author: sanura <sanura@google.com>
Date: Tue Mar 07 00:37:35 2023
Add Compose-observable StateFlow<Lifecycle.State> for current Lifecycle state
When trying to observe Lifecycle.State changes in Compose,
the most natural way is to use Compose State functionality,
so we want to add a new property to Lifecycle that will
expose its Lifecycle.State as a Compose State.
RelNote: "`Lifecycle.State` is now Compose-observable via
`Lifecycle.currentStateFlow`, which returns a `StateFlow`
where the `value` is the current `Lifecycle.State`."
Fixes: 209684871
Test: getCurrentStateFlow()
Change-Id: Ib212d9b84307e0397306e521ceaae41e2c76d532
M lifecycle/lifecycle-common/api/current.txt
M lifecycle/lifecycle-common/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-common/api/restricted_current.txt
M lifecycle/lifecycle-common/src/main/java/androidx/lifecycle/Lifecycle.kt
M lifecycle/lifecycle-runtime-testing/src/test/java/androidx/lifecycle/testing/LifecycleRegistryTest.kt
M lifecycle/lifecycle-runtime/api/current.txt
M lifecycle/lifecycle-runtime/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-runtime/api/restricted_current.txt
M lifecycle/lifecycle-runtime/src/main/java/androidx/lifecycle/LifecycleRegistry.kt
https://android-review.googlesource.com/2472957
Branch: androidx-main
commit b75b447af3d27aed4b4bc5a826e6e92cd0aaff34
Author: sanura <sanura@google.com>
Date: Tue Mar 07 00:37:35 2023
Add Compose-observable StateFlow<Lifecycle.State> for current Lifecycle state
When trying to observe Lifecycle.State changes in Compose,
the most natural way is to use Compose State functionality,
so we want to add a new property to Lifecycle that will
expose its Lifecycle.State as a Compose State.
RelNote: "`Lifecycle.State` is now Compose-observable via
`Lifecycle.currentStateFlow`, which returns a `StateFlow`
where the `value` is the current `Lifecycle.State`."
Fixes: 209684871
Test: getCurrentStateFlow()
Change-Id: Ib212d9b84307e0397306e521ceaae41e2c76d532
M lifecycle/lifecycle-common/api/current.txt
M lifecycle/lifecycle-common/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-common/api/restricted_current.txt
M lifecycle/lifecycle-common/src/main/java/androidx/lifecycle/Lifecycle.kt
M lifecycle/lifecycle-runtime-testing/src/test/java/androidx/lifecycle/testing/LifecycleRegistryTest.kt
M lifecycle/lifecycle-runtime/api/current.txt
M lifecycle/lifecycle-runtime/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-runtime/api/restricted_current.txt
M lifecycle/lifecycle-runtime/src/main/java/androidx/lifecycle/LifecycleRegistry.kt
na...@google.com <na...@google.com> #7
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.lifecycle:lifecycle-common:2.7.0-alpha01
androidx.lifecycle:lifecycle-runtime:2.7.0-alpha01
androidx.lifecycle:lifecycle-runtime-testing:2.7.0-alpha01
Description
We can observe Lifecycle changes in a few different ways, but with Compose the most natural way would be via a
State<Lifecycle.State>
, which would make the currentLifecycle.State
automatically observable to Compose.