Status Update
Comments
ca...@google.com <ca...@google.com> #2
I have updated androidx.room:room-paging 2.5.0-alpha02 and androidx-paging to 3.2.0-alpha01 respectively but seems the cause is androidx.room:room-paging is adding the transitive dependency for paging-common 3.1.1.
[33m| +--- [39mandroidx.room:room-paging:2.5.0-alpha02
[33m| | +--- [39mandroidx.paging:paging-common:3.1.1
The lib or some lib has marked paging-common to be strictly 3.1.1 instead of 3.2.0-alpha02.
androidx.paging:paging-common:{strictly 3.1.1} -> 3.1.1
This caused the app to be always using paging-common 3.1.1 which PagingDataDiffer class does not have the updated constructor yet.
ro...@google.com <ro...@google.com> #3
Please include a sample project that reproduces your issue. None of the room-paging
artifacts have any strict dependencies on Paging.
ro...@google.com <ro...@google.com> #4
There shouldn't be a strict version requirement, room-paging depending on paging-common:3.1.1 should be able to get upgraded to 3.2.0-alpha01.
By any chance are you hitting this while running an instrumented test? The version of paging should resolve the same between for both the main apk and test apk, but the way this is exposed is unfortunately as a version requirement.
Otherwise, if you can share your build.gradle
it would help us reproduce the issue, it's possible we're missing a version constraint that could better guide how Gradle resolves the paging-common version.
ap...@google.com <ap...@google.com> #5
Hi, no we are not using during instrumented test but just a normal run from AS will encounter the crash.
Not sure what went wrong but excluding the transitive dependency group androidx.paging from room-paging seems to work and androidx.paging:paging-common:3.1.1 no longer shown as strictly in the app:dependencies task.
Description
Requiring a Window instance when constructing WindowInsetsControllerCompat hinders composability, and requires unfortunate hacks like casting the Context to Activity to obtain a Window (which won't return the right instance in all cases, e.g. with
Dialog
s).We should look into removing this dependency, or making it optional.