WindowInsetsControllerCompat: Remove the dependency on Window [210121779]

Fixed

Bug

Status Update

No update yet.

Description

ro...@google.com

created issue #1

Dec 10, 2021 04:30PM

Requiring a Window instance when constructing WindowInsetsControllerCompat hinders composability, and requires unfortunate hacks like casting the Context to Activity to obtain a Window (which won't return the right instance in all cases, e.g. with Dialogs).

We should look into removing this dependency, or making it optional.

Comments

ca...@google.com <ca...@google.com> #2Dec 10, 2021 05:20PM

Reassigned to ro...@google.com.

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

ro...@google.com <ro...@google.com> #3Dec 10, 2021 05:43PM

Thanks for the report!

ro...@google.com <ro...@google.com> #4Dec 10, 2021 05:56PM

Reassigned to ca...@google.com.

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

Message last modified on Dec 10, 2021 07:46PM

ap...@google.com <ap...@google.com> #5Jan 18, 2022 04:31PM

deleted

va...@google.com <va...@google.com> Jan 18, 2022 06:14PM

Marked as fixed, reassigned to va...@google.com.

Issue 210121779