rememberSwipeDismissableNavController() does not support back buttton by default [210205624]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Dec 12, 2021 09:23AM

Version used: 1.0.0-alpha12
Devices/Android versions reproduced on: Galaxy Watch 4 Classic

By default, rememberSwipeDismissableNavController() does not seem to support back button on watches that have it (for example Galaxy Watch 4). When user presses back button, whole activity will exit.

Workaround is to manually add BackHandler after creating the nav controller:

val navController = rememberSwipeDismissableNavController()
BackHandler {
   navController.popBackStack()
}

Comments

st...@google.com <st...@google.com> #2Dec 13, 2021 03:02PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6ebe664e0db444d2602f67a75a4deada37d0a72f
Author: stevebower <stevebower@google.com>
Date: Wed Oct 13 15:26:27 2021

Update transition handling in SwipeDismissableNavHost.

Transitions should reach Lifecycle.State.RESUMED
when animations are complete.

Test: androidx.wear.compose.navigation.

Bug: 202863359

Relnote: "Update transition handling in
SwipeDismissableNavHost"

Change-Id: I1cbe09cd902f785dcb68f11f098b340e4da1e55a

M wear/compose/compose-navigation/build.gradle
M wear/compose/compose-navigation/src/main/java/androidx/wear/compose/navigation/SwipeDismissableNavHost.kt
M wear/compose/compose-navigation/src/androidTest/kotlin/androidx/wear/compose/navigation/SwipeDismissableNavHostTest.kt
M wear/compose/compose-navigation/src/main/java/androidx/wear/compose/navigation/WearNavigator.kt

https://android-review.googlesource.com/1857639

st...@google.com <st...@google.com> #3Dec 14, 2021 01:44PM

Project: platform/frameworks/support
Branch: androidx-main

commit d65ce67f974132fad4f26a3f72de6a3b3be2ec0d
Author: stevebower <stevebower@google.com>
Date: Fri Oct 15 09:48:16 2021

Wrap transition handling in SideEffect.

State outside this composable should be
updated in one of the Effect APIs
(as per late comments in aosp/1857639).

Test: androidx.wear.compose.navigation.

Bug: 202863359

Relnote: "Update transition handling in
SwipeDismissableNavHost in a SideEffect"
Change-Id: I04994074e7d024dcf857c156c8c265b57e3769f8

M wear/compose/compose-navigation/src/main/java/androidx/wear/compose/navigation/SwipeDismissableNavHost.kt

https://android-review.googlesource.com/1859213

ap...@google.com <ap...@google.com> #4Dec 15, 2021 03:14PM

Heads up - I ended up using repeatOnLifecycle(state = Lifecycle.State.STARTED) in some code because repeatOnLifecycle(state = Lifecycle.State.RESUMED) wasn't firing, and Alex mentioned this one.

Will provide a repro offline.

jn...@google.com <jn...@google.com> Dec 31, 2021 11:17AM

Assigned to st...@google.com.

st...@google.com <st...@google.com> Jan 5, 2022 10:01AM

Marked as fixed.

Issue 210205624