Fixed
Status Update
Comments
sc...@google.com <sc...@google.com>
sc...@google.com <sc...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit e7140e22015bbfabe71794989dc9ba3713e6380a
Author: Scott Nien <scottnien@google.com>
Date: Mon Jan 10 17:33:25 2022
Fixed incorrect Af region issue on Samsung device front camera
The Af regions passed to HAL seems to be flipped by the OEM on
front cameras in Samsung devices.
Added a quirk/workaround to fix that.
Relnote: "Fixed the incorrect AF region issue on front lens-facing
camera in Samsung devices"
Bug: 210548792
Test: AfRegionFlipHorizontallyQuirkTest, FocusMeteringControlTest
Change-Id: Ifbf590152fa5740a2ca4ef5eee32ba424bc70f3e
A camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/compat/quirk/AfRegionFlipHorizontallyQuirkTest.kt
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/AfRegionFlipHorizontallyQuirk.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/FocusMeteringControlTest.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/CameraQuirks.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/compat/quirk/YuvImageOnePixelShiftQuirkTest.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2CameraControlImpl.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/workaround/MeteringRegionCorrection.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/FocusMeteringControl.java
https://android-review.googlesource.com/1941957
Branch: androidx-main
commit e7140e22015bbfabe71794989dc9ba3713e6380a
Author: Scott Nien <scottnien@google.com>
Date: Mon Jan 10 17:33:25 2022
Fixed incorrect Af region issue on Samsung device front camera
The Af regions passed to HAL seems to be flipped by the OEM on
front cameras in Samsung devices.
Added a quirk/workaround to fix that.
Relnote: "Fixed the incorrect AF region issue on front lens-facing
camera in Samsung devices"
Bug: 210548792
Test: AfRegionFlipHorizontallyQuirkTest, FocusMeteringControlTest
Change-Id: Ifbf590152fa5740a2ca4ef5eee32ba424bc70f3e
A camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/compat/quirk/AfRegionFlipHorizontallyQuirkTest.kt
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/AfRegionFlipHorizontallyQuirk.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/FocusMeteringControlTest.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/CameraQuirks.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/compat/quirk/YuvImageOnePixelShiftQuirkTest.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2CameraControlImpl.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/workaround/MeteringRegionCorrection.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/FocusMeteringControl.java
Description
One developer reported a tap-to-focus CameraX issues of front cameras in Galaxy Note 8 (see the discussion herehttps://groups.google.com/a/android.com/g/camerax-developers/c/-tNR0rQx3tk/m/BMEcWqHpBQAJ?utm_medium=email&utm_source=footer ).
It seems that the focused object is wrong. When focusing on the bottom object, it is still blurred but if we focus the area in the top, it will focus the object correctly. Does Samsung have any other treatment related to the mirroring to the 3A metering regions ? If removing the horizontal mirroring in the sensor coordinates, it seems to fix the issue.
The issue can be reproduced on Meta messenger app as well. (see attached video). I can also reproduce it on Galaxy S10e. For other Samsung devices, most doesn't support AF on front cameras and the AE region doesn't make much differences, so it is difficult to tell if the issue exists or not.