Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 252671fa4de2fd651636d91fc8e99997e933b5a5
Author: Chris Craik <ccraik@google.com>
Date: Tue Dec 14 12:27:23 2021
Fix profilers not starting
Fixes: 210619998
Test: ./gradlew benchmark:benchmark-common:cC
Test: TrivialKotlinBenchmark + ls ../../out/androidx/benchmark/benchmark-benchmark/build/outputs/connected_android_test_additional_output/releaseAndroidTest/connected/*/
Relnote: Fixes profiler argument enable being ignored.
Profiler argument was only set up in one of the BenchmarkState
constructors in a previous refactor.
Change-Id: I373734dfa19f8afb3d0a963c597f8351eb74af36
M benchmark/benchmark-common/src/main/java/androidx/benchmark/BenchmarkState.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Arguments.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Profiler.kt
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/BenchmarkStateTest.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Errors.kt
https://android-review.googlesource.com/1923188
Branch: androidx-main
commit 252671fa4de2fd651636d91fc8e99997e933b5a5
Author: Chris Craik <ccraik@google.com>
Date: Tue Dec 14 12:27:23 2021
Fix profilers not starting
Fixes: 210619998
Test: ./gradlew benchmark:benchmark-common:cC
Test: TrivialKotlinBenchmark + ls ../../out/androidx/benchmark/benchmark-benchmark/build/outputs/connected_android_test_additional_output/releaseAndroidTest/connected/*/
Relnote: Fixes profiler argument enable being ignored.
Profiler argument was only set up in one of the BenchmarkState
constructors in a previous refactor.
Change-Id: I373734dfa19f8afb3d0a963c597f8351eb74af36
M benchmark/benchmark-common/src/main/java/androidx/benchmark/BenchmarkState.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Arguments.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Profiler.kt
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/BenchmarkStateTest.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Errors.kt
Description
Version used: 1.1.0-alpha12
Devices/Android versions reproduced on: Pixel 6 (API 31), Pixel 3 (API 31), Emulator (API 27)
When running micro benchmarks with profiling set (e.g
StackSampling), no traces are actually produced.It almost looks like the profiling isn't started at all?
I was checking the source code and it should print this message
Benchmark: Profiling output file: ...which it doesn't.When the same tested on 1.1.0-alpha11, it works, creates the trace (and prints the output).