Navigation Query parameters are decoded twice, decoding already decoded value [210711399]

Fixed

Bug

Status Update

No update yet.

Description

al...@mercari.com

created issue #1

Dec 15, 2021 07:21AM

Component used: Navigation Version used: 2.4.0-beta02

Query parameters are being decoded twice,

The first one via Uri.getQueryParameter call in: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt;l=181

and for the second time in : https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt;l=193

This results to wrong incorrect final decoded value provided to the SavedStateHandle.

This leads to encoded special characters such as % to be decoded incorrectly. For example, the raw value being %555 gets encoded correctly to %25555, Then on the first decode it gets correctly decoded back into %555, but due to decoding an already decoded string, the final decoded argument value becomes U5.

It is easily replicable with common use case. For example, for routes with search query like search?query=%555, the argument transforms into U5 and is searched instead.

Comments

il...@google.com <il...@google.com> #2Dec 15, 2021 06:20PM

Oh I forgot to mention that I thought it might be connected to this issue: https://issuetracker.google.com/issues/243778589. But after trying 2.5.2 I can say that the issue persists.

al...@mercari.com <al...@mercari.com> #3Dec 15, 2021 07:11PM

Please provide a minimal sample project along with the minimal steps to recreate the issue in the project.

ComposeSandbox 3.zip

49 MB

Download

al...@mercari.com <al...@mercari.com> #4Dec 15, 2021 07:12PM

Sorry for the delay. I got a working example here: https://github.com/Del-S/issues. The project is set up to crash when navigating to ThirdFragment (nested nav graph) with poping the graph.

I poked into it a little bit and it seems to be connected to SafeArgs gradle plugin. When safe args is used to navigate to ThirdFragment (with nested graph poped) it will try to recreate te parent but there were no arguments passed so it crashes.

Steps to reproduce:

Navigate from Second Fragment to Child nav graph (with non-nullable parameters).
Navigate to Third fragment using SafeArgs and the app crashes.

Crash log:

Process: cz.dels.issues, PID: 1743
java.lang.NullPointerException: null cannot be cast to non-null type kotlin.Long
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:352)
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:342)
at androidx.navigation.NavArgument.verify(NavArgument.kt:76)
at androidx.navigation.NavDestination.addInDefaultArgs(NavDestination.kt:502)
at androidx.navigation.NavController.addEntryToBackStack(NavController.kt:1865)
at androidx.navigation.NavController.addEntryToBackStack$default(NavController.kt:1813)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1721)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1719)
at androidx.navigation.NavController$NavControllerNavigatorState.push(NavController.kt:287)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:246)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:162)
at androidx.navigation.NavController.navigateInternal(NavController.kt:260)
at androidx.navigation.NavController.navigate(NavController.kt:1719)
at androidx.navigation.NavController.navigate(NavController.kt:1545)
at androidx.navigation.NavController.navigate(NavController.kt:1472)
at androidx.navigation.NavController.navigate(NavController.kt:1930)
at cz.dels.issues.SecondFragment.onViewCreated$lambda-0(SecondFragment.kt:38)
at cz.dels.issues.SecondFragment.$r8$lambda$XDYnOS_cYrafiNQ5rcCu1WCn0IE(Unknown Source:0)
at cz.dels.issues.SecondFragment$$ExternalSyntheticLambda0.onClick(Unknown Source:2)

Note: If in step 2 SaveArgs is not used then navigation works correctly. More information is here: https://github.com/Del-S/issues/blob/master/app/src/main/java/cz/dels/issues/SecondFragment.kt#L37.

jb...@google.com <jb...@google.com> Jan 7, 2022 12:02AM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #5Jan 19, 2022 03:02AM

Ups a typo: Navigate from ~~Second~~ First Fragment to Child nav graph (with non-nullable parameters).

Note: sorry for the spam but I am not able to edit my own comment.

jb...@google.com <jb...@google.com> #6Jan 19, 2022 06:12AM

Marked as fixed.

This has been fixed and will be available in navigation 2.6.0-alpha08

Issue 210711399