Scaffold with TimeText prevents content from being interacted with in Talkback mode [210721259]

Fixed

Bug

adexe s nau

Status Update

No update yet.

Description

va...@google.com

created issue #1

Dec 14, 2021 10:01PM

The standard setup of the Wear Scaffold is to include the TimeText() Composable in the timeText slot of the Scaffold.

When Talkback is enabled, this prevents the underlying content from being interactable entirely, I think because the TimeText() is an overlay that is placed on top of all content. I'm not sure of an easy workaround either, apart from removing the TimeText entirely.

Comments

jn...@google.com <jn...@google.com> Dec 31, 2021 11:17AM

Assigned to mk...@google.com.

ys...@google.com <ys...@google.com> #2Jan 14, 2022 10:14AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

ys...@google.com <ys...@google.com> #3Jan 14, 2022 10:16AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

ss...@google.com <ss...@google.com> #4Mar 23, 2022 03:02PM

CurvedText (used inside TimeText) had a semantic annotation so talkback could read the text to the user.
In the last patch (going out as alpha19) we removed that, since CurvedText is not a compose-ui node anymore, but we will look into adding it back again (with better bounds).

st...@google.com <st...@google.com> May 13, 2022 02:11PM

Reassigned to ss...@google.com.

ss...@google.com <ss...@google.com> Oct 3, 2022 10:55AM

Accepted by ss...@google.com.

ap...@google.com <ap...@google.com> #5Oct 4, 2022 12:07PM

Project: platform/frameworks/support
Branch: androidx-main

commit 29737ba91ffe21e7b3132693094b5484c5cecbe1
Author: Sergio Sancho <ssancho@google.com>
Date: Mon Oct 03 14:18:01 2022

Create compose-ui nodes for curved text elements.

For each curvedText/basicCurvedText we create a compose-ui node that has
as content description the text of the (basic)curved text, and we size
and place it appropiatelly. This enables talkback to work properly with
curved text elements.
Minor change to the internal API for CurvedChild.initializeMeasure
Test: Manual, with and withouth talkback. + ./gradlew :wear:compose:compose-foundation:connectedCheck
Relnote: "curveText and basicCurvedText will now have a properly sized
and placed (but empty) compose-ui node associated with them, using the text as
content description, to properly work with talkback"
Bug: 210721259

Change-Id: I7af7ced923180839eee782fe2e45a1976c7e8ab4

M wear/compose/compose-foundation/samples/src/main/java/androidx/wear/compose/foundation/samples/CurvedWorldSample.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedLayout.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedContainer.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedSize.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/BasicCurvedText.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedPadding.kt
M wear/compose/compose-foundation/src/androidAndroidTest/kotlin/androidx/wear/compose/foundation/SpyModifier.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedComposable.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/FoundationDemos.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/CurvedModifier.kt

https://android-review.googlesource.com/2238417

ss...@google.com <ss...@google.com> Oct 4, 2022 12:07PM

Marked as fixed.

na...@google.com <na...@google.com> #6Oct 24, 2022 01:38PM

The following release(s) address this bug:

androidx.wear.compose:compose-foundation:1.1.0-beta01