lint.xml in modules is not considered for UP-TO-DATE check of lint tasks [211012777]

Fixed

Bug

Status Update

No update yet.

Description

pa...@gmail.com

created issue #1

Dec 18, 2021 02:49PM

DESCRIBE THE ISSUE IN DETAIL:

It is possible to put lint.xmls in the rootProject and in every module individually. These will be considered together to set up configuration for each module. In the attach project the structure is:

app
- lint.xml missing, will use ../lint.xml
- uses :lib
- has 1 unused resource
lib
- lint.xml exists, but empty (will be modified by step 6)
- has 1 unused resource
- has 1 used resource that appears unused due to not checking dependencies
lint.xml exists, and suppresses the clear unused resources by pattern.

STEPS TO REPRODUCE:

Download project from https://github.com/TWiStErRob/repros/tree/master/agp/lint-xml-up-to-date
gradlew lint
Observe :lib:lintDebug telling us there's an unused resource called "unused" in lib/build/reports/lint-results-debug.html
gradlew lint
Observe nothing was executed, everything up-to-date.
Go to lib/lint.xml and uncomment <ignore>
gradlew lint

Actual: Observe nothing was executed, everything up-to-date.

Expected: lint analysis re-executes and updates the HTML report with the findings based on the newly changed config file.

Bonus steps to prove that the uncommenting should have an effect:

gradlew clean lint --no-build-cache
Observe no lint warnings.

Workaround

polyfill missing setup

allprojects {
	val project = this
	project.plugins.withId("com.android.base") {
		project.tasks.withType<com.android.build.gradle.internal.lint.AndroidLintTask>().configureEach {
			this.inputs.files(project.rootProject.file("lint.xml")).withPathSensitivity(PathSensitivity.RELATIVE)
			this.inputs.files(project.file("lint.xml")).withPathSensitivity(PathSensitivity.RELATIVE)
		}
	}
}

Studio Build: N/A
Version of Gradle Plugin: 7.0.4
Version of Gradle: 7.3.2
Version of Java: 11
OS: Windows 10

Comments

uc...@google.com <uc...@google.com> Dec 22, 2021 04:06AM

Assigned to an...@google.com.

ga...@google.com <ga...@google.com> Sep 12, 2022 03:11PM

Reassigned to sp...@google.com.

sp...@google.com <sp...@google.com> #2Sep 12, 2022 07:47PM

As I understand it, we need to migrate namespace definitions both from AndroidManifest.xml and from implicit definitions from applicationId / testApplicationId? Is that right? So an 8.0 project would have a

namespace <n>
testNamespace <tn>

where <n> is taken from AndroidManifest.xml package definitions if present, and applicationId if not, and <tn> is testApplicationId if present and <n>.test if not?

pa...@gmail.com <pa...@gmail.com> #3Sep 12, 2022 08:18PM

Sorry for the confusion. AGP would change how it computes the namespace for the androidTest variant. All the Upgrade assistant would need to do is update the source code for the import of the R class.

da...@gmail.com <da...@gmail.com> #4Sep 13, 2022 12:38PM

OK! And, I think, this should happen at the same time as the namespace declaration is migrated from AndroidManifest.xml?

Message last modified on Sep 13, 2022 01:15PM

ts...@vewd.com <ts...@vewd.com> #5Sep 20, 2022 07:11AM

It's unrelated, but it is possible that we move 8.0 to also only declare the namespace into the DSL. I would make it a separate refactoring because they are not tied at all.

pa...@gmail.com <pa...@gmail.com> #6Sep 20, 2022 07:33AM

I would consider first adding the right new value to models (as a new property) and then, to avoid Studio interpreting manifests and build configurations, just update to whatever the synced value of this new property is.

sp...@google.com <sp...@google.com> #7Nov 11, 2022 06:11PM

Marked as fixed.

Updated version of this in #16 below

~~Currently, AUA removes the package attribute from the main manifest and instead specifies that value via the namespace DSL.~~

~~In addition to that, AUA should:~~

(1) Check for a package attribute in the (possibly non-existent) androidTest AndroidManifest.xml. If there's a value there, it should be removed from that manifest, and if it's not equal to namespace + ".test", it should be specified via the testNamespace DSL.
- If namespace == testNamespace, this is problematic because the androidTest and regular R classes will have the same namespace. Not sure what the best behavior is here? Maybe an error explaining that the user should first reset the androidTest AndroidManifest's package attribute and change the androidTest source code package accordingly?
(2) Compare the new testNamespace with the old AndroidProject.androidTestNamespace from the model. If they are different, search the androidTest source code for references to an R class namespaced with AndroidProejct.androidTestNamespace, and change the namespace to testNamespace.