lint.xml in modules is not considered for UP-TO-DATE check of lint tasks [211012777]

Fixed

Bug

Status Update

No update yet.

Description

pa...@gmail.com

created issue #1

Dec 18, 2021 02:49PM

DESCRIBE THE ISSUE IN DETAIL:

It is possible to put lint.xmls in the rootProject and in every module individually. These will be considered together to set up configuration for each module. In the attach project the structure is:

app
- lint.xml missing, will use ../lint.xml
- uses :lib
- has 1 unused resource
lib
- lint.xml exists, but empty (will be modified by step 6)
- has 1 unused resource
- has 1 used resource that appears unused due to not checking dependencies
lint.xml exists, and suppresses the clear unused resources by pattern.

STEPS TO REPRODUCE:

Download project from https://github.com/TWiStErRob/repros/tree/master/agp/lint-xml-up-to-date
gradlew lint
Observe :lib:lintDebug telling us there's an unused resource called "unused" in lib/build/reports/lint-results-debug.html
gradlew lint
Observe nothing was executed, everything up-to-date.
Go to lib/lint.xml and uncomment <ignore>
gradlew lint

Actual: Observe nothing was executed, everything up-to-date.

Expected: lint analysis re-executes and updates the HTML report with the findings based on the newly changed config file.

Bonus steps to prove that the uncommenting should have an effect:

gradlew clean lint --no-build-cache
Observe no lint warnings.

Workaround

polyfill missing setup

allprojects {
	val project = this
	project.plugins.withId("com.android.base") {
		project.tasks.withType<com.android.build.gradle.internal.lint.AndroidLintTask>().configureEach {
			this.inputs.files(project.rootProject.file("lint.xml")).withPathSensitivity(PathSensitivity.RELATIVE)
			this.inputs.files(project.file("lint.xml")).withPathSensitivity(PathSensitivity.RELATIVE)
		}
	}
}

Studio Build: N/A
Version of Gradle Plugin: 7.0.4
Version of Gradle: 7.3.2
Version of Java: 11
OS: Windows 10

Comments

uc...@google.com <uc...@google.com> Dec 22, 2021 04:06AM

Assigned to an...@google.com.

ga...@google.com <ga...@google.com> Sep 12, 2022 03:11PM

Reassigned to sp...@google.com.

sp...@google.com <sp...@google.com> #2Sep 12, 2022 07:47PM

Lint options:

    lintOptions {
        lintConfig = file('lint.xml')

        abortOnError true
        xmlReport true
        htmlReport true
        checkDependencies true
    }

Also, our project has custom lint rules. Failure happens with a dependency of 26.6.3 and 27.0.0.

Is any way to downgrade lint runner? This problem is keeping us from using AGP 4.0

pa...@gmail.com <pa...@gmail.com> #3Sep 12, 2022 08:18PM

Attached slightly different stacktrace for the same problem.

Wonder if disabling some lint rules could help to "fix" this problem, as it is also blocking for us 4.0 AGP upgrade.

da...@gmail.com <da...@gmail.com> #4Sep 13, 2022 12:38PM

Notes:

I suspect the exceptions are happening now because JetBrains recently changed an assert statement into a hard failure (see 3260e41111).

I.e., it's possible that Lint has been hitting this code path all along, and only now it is causing a problem.

This has been difficult to investigate so far because the failure is nondeterministic and also deep inside the Kotlin compiler. Plus, JetBrains seems to be hitting this code path occasionally too (hence why they changed the assert into a hard failure), so I'm not even sure whether Lint is implicated or not.

Message last modified on Sep 13, 2022 01:15PM

ts...@vewd.com <ts...@vewd.com> #5Sep 20, 2022 07:11AM

It could also explain why not all lint rules were working from time to time (https://issuetracker.google.com/issues/149554597). According to Github, this change was done for 1.4-M2, which is considered unstable. Maybe lint runner could use an older but stable version? What else options do I have?

Is any public issue created I could follow?

pa...@gmail.com <pa...@gmail.com> #6Sep 20, 2022 07:33AM

Has anyone tried this with 4.1.0-beta2? We're using a more recent version of UAST and the Kotlin compiler there. It's not clear that it's fixed but -- there's a chance :-)

sp...@google.com <sp...@google.com> #7Nov 11, 2022 06:11PM

Marked as fixed.

I tried. The same error. I am wondering, is any way to know which lint checks cause failure? I have a few custom lint checks. Or, is any way downgrade compiler for lint checks?