Bug P3
Status Update
Comments
ba...@google.com <ba...@google.com> #2
pa...@google.com <pa...@google.com> #3
Low-hanging fruit. Shalom, mind taking a look during your work for PIs and loaders?
ba...@gmail.com <ba...@gmail.com> #4
We can check for NaN
, but what is the expected behavior here if a NaN
is passed in?
- We can throw an exception, but that would end in the same result you are experiencing now (i.e. a crash if you don't handle it)
- We can just set the progress to zero in cases of
NaN
s, but then you would not be able to tell that you have a problem in your implementation and you are passing in illegal values. - We can document it that we only expect a non
NaN
values, but that seems a bit redundant and we don't usually adding these to the docs as it's implicit in most cases.
ba...@gmail.com <ba...@gmail.com> #5
On my end, I discovered it was caused by division by zero and just set the bar to indeterminate in that case.
Description