[Question] Expected behaviour when using TextView.setTextFuture [211231958]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Dec 20, 2021 10:20AM

Component used: Emoji2 Version used: 1.0.0, 1.0.1 Devices/Android versions reproduced on: API 30 Emulator with Google apis

What is the expected behaviour when using TextView.setTextFuture with text which contains emojis?

At the moment we're seeing plain text that contains emojis be replaced with EmojiSpans which are not compatible with TextView.setTextFuture.

Thread: main, Exception: java.lang.IllegalArgumentException: MetricAffectingSpan can not be set to PrecomputedText.
at androidx.core.text.PrecomputedTextCompat.setSpan(PrecomputedTextCompat.java:5)
at androidx.emoji2.text.EmojiCompat$CompatInternal19.process(EmojiCompat.java:51)
at androidx.emoji2.text.EmojiCompat.process(EmojiCompat.java:12)
at androidx.emoji2.viewsintegration.EmojiInputFilter.filter(EmojiInputFilter.java:8)
at android.widget.TextView.setText(TextView.java:4996)
at android.widget.TextView.setText(TextView.java:4962)
at android.widget.TextView.setText(TextView.java:4937)
at androidx.core.widget.TextViewCompat.setPrecomputedText(TextViewCompat.java:8)
at androidx.appcompat.widget.AppCompatTextView.consumeTextFutureAndSetBlocking(AppCompatTextView.java:3)
at androidx.appcompat.widget.AppCompatTextView.onMeasure(AppCompatTextView.java:1)

Our workaround is to process all text and check for instances of MetricAffectingSpan, if an instance is found we replace setTextFuture with setText

Comments

ig...@irl.com <ig...@irl.com> #2Dec 23, 2021 08:57AM

https://android-review.googlesource.com/c/platform/frameworks/support/+/1092870

se...@google.com <se...@google.com> #3Jan 4, 2022 08:33PM

Reassigned to se...@google.com.

Thank you for the quick fix.
Is there an ETA for the next release?

se...@google.com <se...@google.com> #4Mar 14, 2022 10:47PM

2.2.0-rc01 should be out this week.

ap...@google.com <ap...@google.com> #5Mar 17, 2022 12:10AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a1957df3709a06f4e6482fb0e4d39ded4f230a70
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Jul 29 09:48:05 2019

Workaround NPE in PersistableBundle.getExtras().

Test: Existing unit tests pass. Ran integration test app.
Fixes:

b/138441699

Change-Id: I0b48e0009a7d83c343a3d26112b94c057470c281

M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java

https://android-review.googlesource.com/1092870

https://goto.google.com/android-sha1/a1957df3709a06f4e6482fb0e4d39ded4f230a70

x3...@gmail.com <x3...@gmail.com> #6Jun 27, 2022 03:41PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6206758647365632/#/cherrypickHistory/all)
Created: 2019-07-29 19:41:55.445144+00:00
Changes: aosp/1092870

se...@google.com <se...@google.com> #7Jun 27, 2022 03:50PM

This fix will be in the next stable release.

kc...@gmail.com <kc...@gmail.com> #8Nov 10, 2023 07:05PM

Hi someone is using my device for a business, Google ads, and a YouTube channel. The YouTube is mashup and I found a name in my Facebook where it should have only been my name. Now when I go to look up the emoji comments from the above I'll get a page saying I can't access and it won't let me go.

kc...@gmail.com <kc...@gmail.com> #9Nov 10, 2023 07:06PM

I'd like to know if you can look into this or how will it go?