Room: "Parameter specified as non-null is null" for right part of multimap with LEFT JOIN [212279118]

Fixed

Bug

Status Update

No update yet.

Description

el...@gmail.com

created issue #1

Dec 28, 2021 08:43PM

Component used: Room. Version used: 2.4. Devices/Android versions reproduced on: Android 11.

I am trying to get data with LEFT JOIN using a multimap. This is a very simple LEFT JOIN request such as in the documentation.

But both my tables have the non-null field named "identifier". When you call LEFT JOIN query in SQLite, but there is no row in the second table, you will get NULL for ALL values of the second table (see screenshot). So, it seems Room just try to verify for null these null values. It is a bug. Room should return an empty list for List<PostEntity>.

DB schema:

CREATE TABLE IF NOT EXISTS `categories` (
    `id` INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL,
    `identifier` TEXT NOT NULL
);

CREATE TABLE IF NOT EXISTS `posts` (
    `id` INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL,
    `category_id` INTEGER NOT NULL,
    `identifier` TEXT NOT NULL,
    
    FOREIGN KEY(`category_id`) REFERENCES `categories`(`id`)
);

INSERT INTO `categories` VALUES (null, "test-1");
INSERT INTO `categories` VALUES (null, "test-2");
INSERT INTO `categories` VALUES (null, "test-3");

SELECT * FROM `categories` LEFT JOIN `posts` ON `posts`.`category_id` = `categories`.`id`;

Dao:

@Dao
interface CategoryDao {
    @Query("SELECT * FROM `categories` LEFT JOIN `posts` ON `posts`.`category_id` = `categories`.`id`")
    fun getCategoryAndPostsLiveDataTest(): LiveData<Map<CategoryEntity, List<PostEntity>>>
}

Error:

java.lang.RuntimeException: Exception while computing database live data.

Caused by: java.lang.NullPointerException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkNotNullParameter, parameter identifier

Screenshot_20211228_232903.png

11 KB

View

Download

Comments

el...@google.com <el...@google.com> Dec 29, 2021 03:07PM

Reassigned to el...@google.com.

el...@google.com <el...@google.com> #2Jan 6, 2022 06:55PM

Another instance:

https://android-build.googleplex.com/builds/pending/P10986006/androidx_host_tests_max_dep_versions/latest/view/logs/build_error.log

which says:

The message received from the daemon indicates that the daemon has disappeared.
Build request sent: Build{id=0aba0dd6-d140-4723-8ae6-1c8cecbfba77, currentDir=/buildbot/src/android/androidx-master-dev}
Attempting to read last messages from the daemon log...
Daemon pid: 15649
log file: /buildbot/src/android/androidx-master-dev/out/.gradle/daemon/6.0/daemon-15649.out.log
----- Last 20 lines from daemon log file - daemon-15649.out.log -----
I/MonitoringInstr: Setting context classloader to 'org.robolectric.internal.AndroidSandbox$SdkSandboxClassLoader@18f946ad', Original: 'org.robolectric.internal.AndroidSandbox$SdkSandboxClassLoader@18f946ad'

androidx.camera.camera2.impl.Camera2CameraInfoImplTest > cameraInfo_canCalculateCorrectRelativeRotation_forBackCamera[22] STANDARD_OUT
[Robolectric] androidx.camera.camera2.impl.Camera2CameraInfoImplTest.cameraInfo_canCalculateCorrectRelativeRotation_forBackCamera: sdk=22; resources=BINARY
Gradle Test Executor 109 started executing tests.
Note: /buildbot/src/android/androidx-master-dev/frameworks/support/work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/sherlockholmes/TextReducingWorker.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Stream closed

androidx.camera.camera2.impl.Camera2CameraInfoImplTest > cameraInfo_canCalculateCorrectRelativeRotation_forBackCamera[23] STANDARD_OUT
[Robolectric] androidx.camera.camera2.impl.Camera2CameraInfoImplTest.cameraInfo_canCalculateCorrectRelativeRotation_forBackCamera: sdk=23; resources=BINARY

androidx.camera.core.CameraCaptureResultsTest > canRetrieveCameraCaptureResult[27] STANDARD_OUT
androidx.enterprise.feedback.KeyedAppStatesServiceTest STANDARD_ERROR
[Robolectric] androidx.camera.core.CameraCaptureResultsTest.canRetrieveCameraCaptureResult: sdk=27; resources=BINARY
[Robolectric] WARN: Android SDK 10000 requires Java 9 (have Java 8). Tests won't be run on SDK 10000 unless explicitly requested.
I/MonitoringInstr: Instrumentation started!
I/MonitoringInstr: Setting context classloader to 'org.robolectric.internal.AndroidSandbox$SdkSandboxClassLoader@215389e1', Original: 'org.robolectric.internal.AndroidSandbox$SdkSandboxClassLoader@215389e1'
Created classpath snapshot for incremental compilation in 0.439 secs. 253 duplicate classes found in classpath (see all with --debug).
----- End of the daemon log -----

ap...@google.com <ap...@google.com> #3May 13, 2022 12:06PM

Hmm, it doesn't seem to be specific to the androidx_host_tests_max_dep_versions target though because these failed (in postsubmit) too:

https://android-build.googleplex.com/builds/submitted/6068752/androidx_max_dep_versions/latest/view/logs/build_error.log

https://android-build.googleplex.com/builds/submitted/6068534/androidx_test_dependent_apks/latest/view/logs/build_error.log

https://android-build.googleplex.com/builds/submitted/6068188/androidx_test_changed_apks/latest/view/logs/build_error.log

Each of these three seems to say the same thing, but it's different from the two above:

The message received from the daemon indicates that the daemon has disappeared.
Build request sent: Build{id=52088053-6fbd-4436-8aab-5e305f8428aa, currentDir=/usr/local/google/buildbot/src/android/androidx-master-dev}
Attempting to read last messages from the daemon log...
Daemon pid: 28679
log file: /usr/local/google/buildbot/src/android/androidx-master-dev/out/.gradle/daemon/6.0/daemon-28679.out.log
----- Last 20 lines from daemon log file - daemon-28679.out.log -----
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /usr/local/google/buildbot/src/android/androidx-master-dev/frameworks/support/lifecycle/integration-tests/testapp/src/main/java/androidx/lifecycle/testapp/FrameworkLifecycleRegistryActivity.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /usr/local/google/buildbot/src/android/androidx-master-dev/frameworks/support/lifecycle/integration-tests/testapp/src/androidTest/java/androidx/lifecycle/SynchronousActivityLifecycleTest.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
/usr/local/google/buildbot/src/android/androidx-master-dev/frameworks/support/room/integration-tests/noappcompattestapp/src/androidTest/java/androidx/room/integration/noappcompat/BareRelationDatabaseTest.java:95: warning: The return value includes a POJO with a @Relation. It is usually desired to annotate this method with @Transaction to avoid possibility of inconsistent results between the POJO and its relations. See

https://developer.android.com/reference/android/arch/persistence/room/Transaction.html for details.
UserAndPets getUserWithPets(long id);
^
/usr/local/google/buildbot/src/android/androidx-master-dev/frameworks/support/room/integration-tests/noappcompattestapp/src/androidTest/java/androidx/room/integration/noappcompat/BareRelationDatabaseTest.java:98: warning: The return value includes a POJO with a @Relation. It is usually desired to annotate this method with @Transaction to avoid possibility of inconsistent results between the POJO and its relations. See

https://developer.android.com/reference/android/arch/persistence/room/Transaction.html for details.
List<UserAndPet> getUsersWithPet();
^
2 warnings
Stream closed
----- End of the daemon log -----

da...@google.com <da...@google.com> May 13, 2022 12:41PM

Marked as fixed.

Issue 212279118

Description

Issue summary

Comments

el...@google.com <el...@google.com> Dec 29, 2021 03:07PM

el...@google.com <el...@google.com> #2Jan 6, 2022 06:55PM

ap...@google.com <ap...@google.com> #3May 13, 2022 12:06PM

da...@google.com <da...@google.com> May 13, 2022 12:41PM

Add comment

Issue metadata