currentBackStackEntryAsState() missing from Wear's NavHostController [212739653]

Fixed

Feature Request

Status Update

No update yet.

Description

je...@google.com

created issue #1

Dec 30, 2021 10:28PM

Component used: Navigation (Wear/Compose)

Version used: implementation "androidx.wear.compose:compose-navigation:1.0.0-alpha13"

Devices/Android versions reproduced on: N/A

Description:

A common pattern when using Compose + Compose Navigation to build a mobile app is to observe the current back stack entry (NavHostController.currentBackStackEntryAsState()) to determine what parts of the scaffold should be visible for certain screens.

You can see an example of this with the bottom navigation in this guide.

However, this method doesn't exist in Wear's Navigation version of the library. Can we add it?

I specifically want to only show the vignette in my scaffold when one of the destinations -> routes is a scrollable screen.

This is what I want to do:

Scaffold(
    timeText = {},
    vignette = {
        // Coming from rememberSwipeDismissableNavController()
        val currentRoute: String? =
            swipeDismissableNavController.currentBackStackEntryAsState()?.destination?.route
        
        // Only show vignette for screens with scrollable content.
        if (currentRoute == Screen.WatchList.route) {
            CustomVignette(
                visible = vignetteVisiblePreference,
                vignettePosition = VignettePosition.TopAndBottom
            )
        }
    },
    positionIndicator = {}
) { }

Let me know if you need any more information. I was hoping to add this code to the advanced sample. Thanks!

Comments

je...@google.com <je...@google.com> #2Dec 30, 2021 10:51PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

je...@google.com <je...@google.com> #3Dec 31, 2021 12:38AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

jn...@google.com <jn...@google.com> Dec 31, 2021 11:16AM

Assigned to st...@google.com.

st...@google.com <st...@google.com> Jan 5, 2022 03:06PM

Accepted by st...@google.com.

ap...@google.com <ap...@google.com> #4Jan 11, 2022 01:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit 804463f3f416212296133fe53e30b5d5cbc2fba9
Author: stevebower <stevebower@google.com>
Date: Wed Jan 05 15:04:02 2022

Add currentBackStackEntryAsState to Wear Compose Navigation.

Test: Run tests for wear.compose.navigation.

Bug: 212739653

Relnote: "We have added NavController.currentBackStackEntryAsState()
to the Wear.Compose.Navigation library."
Change-Id: If90286c7debe623df926a091f15766abf04f2ecc

M wear/compose/compose-navigation/api/restricted_current.txt
M wear/compose/compose-navigation/api/current.txt
M wear/compose/compose-navigation/src/androidTest/kotlin/androidx/wear/compose/navigation/SwipeDismissableNavHostTest.kt
M wear/compose/compose-navigation/api/public_plus_experimental_current.txt
M wear/compose/compose-navigation/src/main/java/androidx/wear/compose/navigation/SwipeDismissableNavHostController.kt

https://android-review.googlesource.com/1926189

st...@google.com <st...@google.com> Feb 2, 2022 04:42PM

Marked as fixed.

je...@google.com <je...@google.com> #5Feb 4, 2022 07:48PM

Hi Steve, which version of the library will this be released in?

je...@google.com <je...@google.com> #6Feb 4, 2022 08:00PM

Never mind, it's in alpha15, missed that. Thanks!