FAILED BINDER TRANSACTION with LazyColumn, large lists and complex keys [212982463]

Fixed

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

Jan 3, 2022 06:22PM

Jetpack Compose release version: 1.1.0-RC01 Kotlin version: 1.6.10

Steps to Reproduce:

Have a LazyColumn with a large list of large complex items
Use items(playlistItems, { it }) { ... (Anything even a Spacer()) } (so using large items as keys)
Scrolldown the list a lot
Put the application in the background.

Application crash

E/JavaBinder: !!! FAILED BINDER TRANSACTION !!!  (parcel size = 885244)
    java.lang.RuntimeException: android.os.TransactionTooLargeException: data parcel size 885244 bytes
        at android.app.ActivityClient.activityStopped(ActivityClient.java:86)
        at android.app.servertransaction.PendingTransactionActions$StopInfo.run(PendingTransactionActions.java:143)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7839)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
     Caused by: android.os.TransactionTooLargeException: data parcel size 885244 bytes
        at android.os.BinderProxy.transactNative(Native Method)
        at android.os.BinderProxy.transact(BinderProxy.java:571)
        at android.app.IActivityClientController$Stub$Proxy.activityStopped(IActivityClientController.java:1297)
        at android.app.ActivityClient.activityStopped(ActivityClient.java:83)
        at android.app.servertransaction.PendingTransactionActions$StopInfo.run(PendingTransactionActions.java:143) 
        at android.os.Handler.handleCallback(Handler.java:938) 
        at android.os.Handler.dispatchMessage(Handler.java:99) 
        at android.os.Looper.loopOnce(Looper.java:201) 
        at android.os.Looper.loop(Looper.java:288) 
        at android.app.ActivityThread.main(ActivityThread.java:7839) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

The crash is not tied to savestates as I log them and they are small in that cases too.

Using smaller keys like System.identityHashCode does workaround the issue, but I suppose this could still happens on even larger lists.

Was quite hard to figure out the cause as 0 information from the crash and nothing in the normal savestates, so fully internal to something happening internally to Compose.

Comments

je...@google.com <je...@google.com> Jan 5, 2022 04:20PM

Assigned to an...@google.com.

to...@gmail.com <to...@gmail.com> #2Apr 19, 2022 12:53PM

I proposed this which I think it is better than the actual behavior, and could let the developers work with more room to be creative.

https://code.google.com/p/android/issues/detail?id=58318

an...@google.com <an...@google.com> #3Apr 19, 2022 04:39PM

The presentation link doesn't work.

to...@gmail.com <to...@gmail.com> #4Apr 19, 2022 04:49PM

In Custom Notification Layouts section of the Notification API Guides, it states: "The height available for a custom notification layout depends on the notification view. Normal view layouts are limited to 64 dp, and expanded view layouts are limited to 256 dp". I guess it means the width is 512 dp and the height is 256 dp (if following the 2:1 aspect ratio)?

http://developer.android.com/guide/topics/ui/notifiers/notifications.html#CustomNotification

an...@google.com <an...@google.com> #5Apr 19, 2022 06:06PM

Here is the presentation:

http://commondatastorage.googleapis.com/io2012/presentations/live%20to%20website/105.pdf

to...@gmail.com <to...@gmail.com> #6Apr 19, 2022 06:25PM

https://code.google.com/p/android/issues/detail?id=58318http://developer.android.com/reference/android/app/Notification.BigPictureStyle.html#bigPicture(android.graphics.Bitmap)

ap...@google.com <ap...@google.com> #7Apr 22, 2022 02:47PM

Any update on this?

an...@google.com <an...@google.com> #8Apr 22, 2022 03:12PM

Thank you for your feedback. We assure you that we are doing our best to address all issues reported. For now, we will be closing the issue as won't fix obsolete. If this issue currently still exists, we request that you log a new issue along with the bug report here

https://goo.gl/TbMiIO and reference this bug for context.

to...@gmail.com <to...@gmail.com> #9Apr 22, 2022 03:18PM

Thanks a lot this solve my issue as nothing to save in this case.

For the cases where there's something to save, maybe a first step would be to measure the size and log something when > 500kb or so, to help people figure out the issue and start thinking about the amount of data that can be saved. (I hard an hard time to find the root cause). In all cases crash or data dropping they will need to do something.

to...@gmail.com <to...@gmail.com> #10May 6, 2022 08:02AM

So now that I'm playing with the snapshots for the mem leak issue I tested again this and it still crash

java.lang.RuntimeException: android.os.TransactionTooLargeException: data parcel size 1738696 bytes

How can I debug what's inside the bundle?

al...@mercari.com <al...@mercari.com> #11Aug 10, 2022 03:09PM

Is it solved for you?

How can I debug what's inside the bundle?

You can try https://github.com/guardian/toolargetool and breakpoint on the resulting outState after super.onSavedInstanceStance(outState). You can see the LazyColumn data putting an entry to each item.

to...@gmail.com <to...@gmail.com> #12Aug 10, 2022 04:27PM

It's not fixed, I generate UUiD for playlist entries now to workaround.

And no unfortunately this does not show up in the normal save states so can't use the normal tools.

ap...@google.com <ap...@google.com> #13Aug 26, 2022 03:13PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit f6318bc2d7aa08b8b840be7a94c36143d8b74840
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Wed Aug 24 20:04:21 2022

Save the states only for the currently visible items of lazy layouts

When we save the state of the screen in cases like navigation to other screen or activity rotation we were saving the state for all items which were ever visible in the lazy layouts like LazyColumn. We want to save state while user is scrolling so they not lose it when they scroll back, however when this screen is not active anymore keeping the states for all items is not efficient as we easily can fill up the whole available limit provided by the Bundle. Instead it could be reasonable to only save states for the items which were visible when the screen state save happens.

Relnote: N/A
Fixes: 240837359
Fixes: 242589959
Fixes: 212982463
Test: added LazyLayoutStateRestorationTest. Removed list and grid specific tests as this logic is specific to LazyLayout and should be tested there
Change-Id: Ic04e855cdaa8d25846c55b5671afe7e8e7337b13

M compose/foundation/foundation/api/restricted_current.txt
D tv/tv-foundation/src/androidTest/java/androidx/tv/foundation/lazy/list/LazyItemStateRestoration.kt
D compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/list/LazyItemStateRestoration.kt
M compose/foundation/foundation/api/1.3.0-beta02.txt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/layout/LazySaveableStateHolder.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/layout/LazyLayoutStateRestorationTest.kt
M compose/foundation/foundation/api/public_plus_experimental_1.3.0-beta02.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_1.3.0-beta02.txt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/layout/LazyLayout.kt
D tv/tv-foundation/src/androidTest/java/androidx/tv/foundation/lazy/grid/LazyItemStateRestoration.kt
D compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyItemStateRestoration.kt

https://android-review.googlesource.com/2194857

na...@google.com <na...@google.com> #14Sep 12, 2022 05:51PM

This bug was linked in a change in the following release(s):

androidx.compose.foundation:foundation:1.3.0-beta02

cr...@punct.ro <cr...@punct.ro> #15Nov 16, 2022 01:47PM

I'm still seeing this type of crash with Caused by android.os.TransactionTooLargeException data parcel size ... with compose 1.4.0-alpha01 but only on android 9.

Since we have a single activity app, it only occurs in background (probably when the user minimizes the app). Most of them are in BinderProxy

android.os.BinderProxy.transactNative (BinderProxy.java)
android.os.BinderProxy.transact (BinderProxy.java:1145)
android.app.IActivityManager$Stub$Proxy.activityStopped (IActivityManager.java:3891)
android.app.servertransaction.PendingTransactionActions$StopInfo.run (PendingTransactionActions.java:144)
android.os.Handler.handleCallback (Handler.java:873)
android.os.Handler.dispatchMessage (Handler.java:99)
android.os.Looper.loop (Looper.java:214)
android.app.ActivityThread.main (ActivityThread.java:7050)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:494)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:965)

and a few occurences with various traces from ActivityThread like:

android.app.ActivityThread.handleSleeping (ActivityThread.java:4540)
android.app.ActivityThread.access$2400 (ActivityThread.java:240)
android.app.ActivityThread$H.handleMessage (ActivityThread.java:1896)
android.os.Handler.dispatchMessage (Handler.java:106)
android.os.Looper.loop (Looper.java:214)
android.app.ActivityThread.main (ActivityThread.java:7094)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:494)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:975)

Message last modified on Nov 16, 2022 01:47PM

th...@gmail.com <th...@gmail.com> #16Dec 1, 2022 04:24PM

We also see crashes on Android 9 only. I guess this is because of this bug describes over here: https://issuetracker.google.com/issues/260322832

We are actually using BoxWithConstraints in Lazy Layouts in our app a lot.

zo...@gmail.com <zo...@gmail.com> #17Dec 9, 2022 09:06AM

Also seeing this exclusively on Android 9. I am not using any BoxWithConstraints directly though!

mi...@lite.tech <mi...@lite.tech> #18Dec 12, 2022 03:48PM

I'm also having the same issue without any BoxWithConstraints

ka...@mercari.com <ka...@mercari.com> #19Dec 19, 2022 02:51AM

Looks like the issue is being handled here https://issuetracker.google.com/issues/260322832#comment5