Add API for focus clusters [213508274]

Fixed

Feature Request

adexe s nau

Status Update

No update yet.

Description

ra...@google.com

created issue #1

Jan 6, 2022 11:23PM

Add an API to specify groups of composables that should be treated as a focus group. ie, we give priority to the items within the group before we move focus to items outside the group.

Usecases:

Adjacent lists When we have two scrollable lists next to each other, we want to move focus among all the items of the first list before jumping to the next list. If we don't group all the items in a list into a focus cluster, then from the focus system's perspective the elements in both the lists are treated as siblings, and we move focus purely based on the location of the elements. This can lead to focus search to jump from the first list to the other one list to another before visiting all the items in a given list.
LazyLists When we reach the end of the lazylist, we need to ask the list to compose more items. However, if all the items in the LazyList are not treated as a group, after we visit all the visible items, we could potentially jump out of the list and move focus to another item because the focus system can't distinguish between items in a lazylist and items that are outside it.

Comments

ap...@google.com <ap...@google.com> #2Jan 13, 2022 07:00PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2e60aef4d56a64a8d8732c543b644ff0b4b78734
Author: Sean McQuillan <seanmcq@google.com>
Date: Mon Dec 19 13:45:45 2022

Flesh out MultiParagraphPlaceholderLayoutCache

It's now a layout cache.

TextInlineContentLayoutDrawModifier now does similar debouncing
on input, and defers all cache behaviors to the cache.

Bug:

b/246960758

Test: ./gradlew :com:found:found-d-n-s-newtext:cAT
Change-Id: If104398da705747c6cdcaffe95ff9d2badd20324

M compose/foundation/foundation-newtext/src/androidAndroidTest/kotlin/androidx/compose/foundation/newtext/text/modifiers/MultiParagraphLayoutCacheTest.kt
M compose/foundation/foundation-newtext/src/androidAndroidTest/kotlin/androidx/compose/foundation/newtext/text/modifiers/MultiParagraphLayoutCacheWidthWithLetterSpacingTest.kt
M compose/foundation/foundation-newtext/src/androidAndroidTest/kotlin/androidx/compose/foundation/newtext/text/modifiers/TextLayoutResultIntegrationTest.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/TextUsingModifier.kt
D compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/InlineContentLayoutDrawModifier.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/MultiParagraphLayoutCache.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/TextInlineContentLayoutDrawModifier.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/TextInlineContentLayoutDrawParams.kt
M compose/foundation/foundation-newtext/src/test/kotlin/androidx/compose/foundation/newtext/text/modifiers/MultiParagraphLayoutCacheTest.kt

https://android-review.googlesource.com/2362353

ap...@google.com <ap...@google.com> #3Feb 18, 2022 10:47PM

Project: platform/frameworks/support
Branch: androidx-main

commit 968e10f6319d6e22d035191fa863e5b41c5ce957
Author: Sean McQuillan <seanmcq@google.com>
Date: Mon Dec 19 14:20:48 2022

Add semantics to static text modifier

Draws static text and adds appropriate semantics for non-editable text

This adds semantics to text modifier rewrite.

Bug:

b/246960758

Test: ./gradlew :com:found--d-n-s-newtext:cAT
Change-Id: I05c30a3ba21b4b409f15b15e06c271b2d759de0a

M compose/foundation/foundation-newtext/src/androidAndroidTest/kotlin/androidx/compose/foundation/newtext/text/TextLayoutTest.kt
M compose/foundation/foundation-newtext/src/androidAndroidTest/kotlin/androidx/compose/foundation/newtext/text/modifiers/BasicTextSemanticsTest.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/TextUsingModifier.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/MultiParagraphLayoutCache.kt
A compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/StaticTextModifier.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/TextInlineContentLayoutDrawModifier.kt

https://android-review.googlesource.com/2363663

ra...@google.com <ra...@google.com> Feb 23, 2022 05:46AM

Marked as fixed.

ab...@gmail.com <ab...@gmail.com> #4Oct 23, 2022 11:44AM

Project: platform/frameworks/support
Branch: androidx-main

commit 56d766d1f2e2735425cf9cd20ed802c203223f56
Author: Sean McQuillan <seanmcq@google.com>
Date: Tue Dec 20 11:25:08 2022

Code cleanup for text modifiers

- Semantics allocation caching
- various logic cleanup
- cache added more invalidation branches

Bug:

b/246960758

Test: ./gradlew :com:found--d-n-s-newtext:cAT
Change-Id: Ice59bdee908cedb2ad7a5756a1c5810de3823bb2

M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/TextUsingModifier.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/MultiParagraphLayoutCache.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/StaticTextModifier.kt
M compose/foundation/foundation-newtext/src/commonMain/kotlin/androidx/compose/foundation/newtext/text/modifiers/TextInlineContentLayoutDrawModifier.kt

https://android-review.googlesource.com/2361967

Issue 213508274

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Jan 13, 2022 07:00PM

ap...@google.com <ap...@google.com> #3Feb 18, 2022 10:47PM

ra...@google.com <ra...@google.com> Feb 23, 2022 05:46AM

ab...@gmail.com <ab...@gmail.com> #4Oct 23, 2022 11:44AM

Add comment

Issue metadata