Deep linking with multiple nested nav graphs doesn't correctly create the full backstack [214383060]

Fixed

Bug

Status Update

No update yet.

Description

el...@atomicmedia.co.uk

created issue #1

Jan 13, 2022 06:12PM

Component used: Navigation
Version used: 2.4.0-rc01
Devices/Android versions reproduced on:
Pixel 6 / Android 12

In the example project I have the following nested nav graph structure:

nav_graph{ startDestination=home
home {...}
list { startDestination=leaderboard
leaderboard
exampleNestedGraph { startDestination=exampleFragment
exampleFragment - deepLink="

example.com/user/{userName}"
userProfile - deepLink="

example.com/user/{userName}/details"
}
}
form {...}
}

Following the deep link:

example.com/user/Profile%202/details deep links to the userProfile Fragment as expected.

Then clicking back pops to the exampleFragment

Expected: Clicking back again takes the user to the leaderboard fragment, then clicking back a final time takes the user back to the home fragment.

Actual: Clicking back takes the user to the home fragment, skipping the leaderboard fragment.

I've also updated the bottomNavView_DeepLink_HandlesIntent_BackGoesToList test to test this case

It looks like this was introduced with

https://cs.android.com/androidx/platform/frameworks/support/+/9fc6ccd6e1759d75a8b72f49cedd359e87ba2f99

screen-20220113-175001.mp4

19 MB

Download

NavigationAdvancedSample.zip

366 KB

Download

Comments

jb...@google.com <jb...@google.com> Jan 21, 2022 01:23AM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Jan 25, 2022 09:19PM

This happens when fragments use animation whereby it doesn't wait for animations to complete and moves directly to RESUMED state.

The entry's listener to Fragment state does not get attached because it was attaching only if Fragment was in CREATED / STARTED state.

jb...@google.com <jb...@google.com> #3Jan 25, 2022 09:20PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 16afaea63fc18ca7cc298e6650e0463083ba8ad7
Author: Clara Fok <clarafok@google.com>
Date: Mon Feb 27 17:27:15 2023

Fix FragmentNavigator resume states

Entries previously were not attaching fragment lifecycle observers because it would do so only if Fragment was STARTED or CREATED. But when using animations, Fragments would jump straight to RESUME and no observers would be attached.

Observers are now attached as long as Fragment is atleast STARTED. Since initial entry is not added to backStack, we store its entry to later attach an observer when its fragment is attached.

This CL also lays the foundation for attaching observers upon configuration changes / recreates.

Test: ./gradlew navigation:navigation-fragment:cC
Bug: 269646882
Relnote: "Fixes regression in navigation 2.6.0-alpha06 where NavBackStackEntry is not moved to RESUMED state"
Change-Id: Ib35896636c187da5bd11ea06234a3ea815fdeb68

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
A navigation/navigation-fragment/src/androidTest/res/anim/fade_enter.xml
A navigation/navigation-fragment/src/androidTest/res/anim/fade_exit.xml
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt

https://android-review.googlesource.com/2442040

wb...@gmail.com <wb...@gmail.com> #4Feb 2, 2022 09:13AM

This has been fixed internally and will be available in navigation 2.6.0-alpha07

jb...@google.com <jb...@google.com> #5Feb 2, 2022 04:59PM

Project: platform/frameworks/support
Branch: androidx-main

commit c73552953192ba60a879f5e51218f6e157a24beb
Author: Clara Fok <clarafok@google.com>
Date: Tue Feb 28 14:47:30 2023

Add FragmentNavigator test

Ensure initial fragments and their entries are correctly replaced and destroyed when navigate and popping consecutively

Test: ./gradlew navigation:navigation-fragment:cC
Bug: 269646882
Change-Id: I552ddd3d74f20612c4c91336eb4af9e6aa99c146

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/androidTest/res/navigation/nav_simple.xml

https://android-review.googlesource.com/2461555

wb...@gmail.com <wb...@gmail.com> #6Feb 3, 2022 07:40AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.6.0-alpha07

Issue 214383060