Deep linking with multiple nested nav graphs doesn't correctly create the full backstack [214383060]

Fixed

Bug

Status Update

No update yet.

Description

el...@atomicmedia.co.uk

created issue #1

Jan 13, 2022 06:12PM

Component used: Navigation
Version used: 2.4.0-rc01
Devices/Android versions reproduced on:
Pixel 6 / Android 12

In the example project I have the following nested nav graph structure:

nav_graph{ startDestination=home
home {...}
list { startDestination=leaderboard
leaderboard
exampleNestedGraph { startDestination=exampleFragment
exampleFragment - deepLink="

example.com/user/{userName}"
userProfile - deepLink="

example.com/user/{userName}/details"
}
}
form {...}
}

Following the deep link:

example.com/user/Profile%202/details deep links to the userProfile Fragment as expected.

Then clicking back pops to the exampleFragment

Expected: Clicking back again takes the user to the leaderboard fragment, then clicking back a final time takes the user back to the home fragment.

Actual: Clicking back takes the user to the home fragment, skipping the leaderboard fragment.

I've also updated the bottomNavView_DeepLink_HandlesIntent_BackGoesToList test to test this case

It looks like this was introduced with

https://cs.android.com/androidx/platform/frameworks/support/+/9fc6ccd6e1759d75a8b72f49cedd359e87ba2f99

screen-20220113-175001.mp4

19 MB

Download

NavigationAdvancedSample.zip

366 KB

Download

Comments

jb...@google.com <jb...@google.com> Jan 21, 2022 01:23AM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Jan 25, 2022 09:19PM

since these are in public API (:/) we need to do this in 1.2

jb...@google.com <jb...@google.com> #3Jan 25, 2022 09:20PM

Marked as fixed.

since it is already marked as deprecated, we can probably do it by now.

wb...@gmail.com <wb...@gmail.com> #4Feb 2, 2022 09:13AM

Opening diff shortly

jb...@google.com <jb...@google.com> #5Feb 2, 2022 04:59PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

wb...@gmail.com <wb...@gmail.com> #6Feb 3, 2022 07:40AM

Here are my observations with 2.5.0-SNAPSHOT (build id: 8144622)

-

example.com/user/{userName}/details takes me to userProfile (correct)
- backbutton: takes me back to other app (correct)
- up button: takes me back to exampleFragment, then Leaderboard (correct, intermediate start destinations are present)

Issue 214383060