Status Update
No update yet.
Comments
th...@gmail.com
We have got to get a better way to handle deprecations. This is awful.
il...@google.com
ap...@google.com
Branch: androidx-main
commit 387ce59c6290b334c790f270d98f1b1dde5d3391
Author: Alan Viverette <alanv@google.com>
Date: Wed Nov 29 11:26:23 2023
Clean up obsolete compat methods in ViewCompat and usages in core
Doesn't update lint baseline yet because there are lots of unrelated
changes there. We'll handle the baseline after we clean up the rest of
core.
Doesn't update usages outside of core or core-ktx. These should be
handled by individual library owners.
Bug: 313834577
Test: ViewCompatTest
Relnote: Deprecated obsolete compat methods in ViewCompat
Change-Id: I0bfc2cd15dc681ba0c09f795d25622f2ade004d6
M core/core-ktx/src/main/java/androidx/core/view/View.kt
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/view/ViewCompat.java
M development/build_log_simplifier/messages.ignore
ap...@google.com
Holding off until Sergey is done to avoid conflicts. He's way ahead of me on minSdk cleanup.
ap...@google.com
Sergey, do you want to use this bug for your minSdk-related CLs and then reassign to me when you're done? Or just reassign to me when you're done.
mg...@google.com
ap...@google.com
I think I'm done with removing RequiresApi-s.
ap...@google.com
Create an autofix for this.
ap...@google.com
Bugjuggler:
ap...@google.com
Need a new AGP / Lint so that we get bug fixes.
ap...@google.com
Bugjuggler:
ap...@google.com
Core moved to beta, so now we need to wait a few weeks until it moves back to alpha and we can make API changes again.
Bugjuggler: wait until 2024-03-15
ap...@google.com
ap...@google.com
Branch: androidx-main
commit 7b0e5e3b9e416fbd201fbee4fd9ba1667912b130
Author: Alan Viverette <alanv@google.com>
Date: Tue Mar 26 16:10:04 2024
Move androidx.core:core back to alpha for API changes
Bug: 313834577
Test: ./gradlew :core:core:checkApi
Change-Id: I9974f318bd30daee4baa216485e22a7edf7be7d8
Merged-In: I6236caf2327095763ea82b3661dd1d64c5f91c94
M libraryversions.toml
ap...@google.com
ap...@google.com
Branch: androidx-main
commit 6604eaf83fbfe432168c242c69fb4d709c8a1283
Author: Alan Viverette <alanv@google.com>
Date: Tue Mar 26 16:11:11 2024
Apply auto-fixes from ObsoleteCompatMethod in androidx.core:core
Bumps annotation dependency to latest for @ReplaceWith.
Relnote: Deprecated obsolete compat methods
Bug: 313834577
Test: ./gradlew :core:core:checkApi
Change-Id: I01d9076d4ef7b12614b233f8b0b3e147e97b8221
M activity/integration-tests/testapp/build.gradle
M appcompat/integration-tests/receive-content-testapp/build.gradle
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/build.gradle
M core/core/src/main/java/androidx/core/accessibilityservice/AccessibilityServiceInfoCompat.java
M core/core/src/main/java/androidx/core/app/ActivityManagerCompat.java
M core/core/src/main/java/androidx/core/app/AlarmManagerCompat.java
M core/core/src/main/java/androidx/core/app/BundleCompat.java
M core/core/src/main/java/androidx/core/app/NavUtils.java
M core/core/src/main/java/androidx/core/app/NotificationCompat.java
M core/core/src/main/java/androidx/core/content/ContextCompat.java
M core/core/src/main/java/androidx/core/graphics/BitmapCompat.java
M core/core/src/main/java/androidx/core/graphics/drawable/DrawableCompat.java
M core/core/src/main/java/androidx/core/location/LocationCompat.java
M core/core/src/main/java/androidx/core/net/ConnectivityManagerCompat.java
M core/core/src/main/java/androidx/core/os/BundleCompat.java
M core/core/src/main/java/androidx/core/os/ParcelCompat.java
M core/core/src/main/java/androidx/core/view/MarginLayoutParamsCompat.java
M core/core/src/main/java/androidx/core/view/MenuCompat.java
M core/core/src/main/java/androidx/core/view/MotionEventCompat.java
M core/core/src/main/java/androidx/core/view/ScaleGestureDetectorCompat.java
M core/core/src/main/java/androidx/core/view/VelocityTrackerCompat.java
M core/core/src/main/java/androidx/core/view/ViewCompat.java
M core/core/src/main/java/androidx/core/view/ViewConfigurationCompat.java
M core/core/src/main/java/androidx/core/view/ViewGroupCompat.java
M core/core/src/main/java/androidx/core/view/ViewParentCompat.java
M core/core/src/main/java/androidx/core/view/accessibility/AccessibilityEventCompat.java
M core/core/src/main/java/androidx/core/view/accessibility/AccessibilityRecordCompat.java
M core/core/src/main/java/androidx/core/widget/CheckedTextViewCompat.java
M core/core/src/main/java/androidx/core/widget/ListPopupWindowCompat.java
M core/core/src/main/java/androidx/core/widget/ListViewCompat.java
M core/core/src/main/java/androidx/core/widget/PopupWindowCompat.java
ap...@google.com
Branch: androidx-main
commit ee226e3f129903a29954c39dd49e49ae1f42e320
Author: Alan Viverette <alanv@google.com>
Date: Tue Mar 26 16:30:49 2024
Apply auto-fix for problematic instances of ObsoleteCompatMethod
These didn't apply cleanly and needed some manual work.
Relnote: Deprecate additional obsolete compat methods
Bug: 313834577
Test: ./gradlew :core:core:checkApi :media:media:checkApi
Change-Id: Ie44708f1423037d74b64aadb7418182a6a1dc089
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/view/MenuItemCompat.java
M core/core/src/main/java/androidx/core/view/accessibility/AccessibilityManagerCompat.java
M core/core/src/main/java/androidx/core/widget/TextViewCompat.java
ap...@google.com
Branch: androidx-main
commit 90f97d778b1f3f5e3b0664e0e5df1786f0373c3c
Author: Alan Viverette <alanv@google.com>
Date: Tue Mar 26 16:23:11 2024
Fix ObsoleteCompatDetector auto-fix to remove line breaks
Bug: 313834577
Test: ObsoleteCompatDetectorTest
Change-Id: I1530004a57c019682da7a38a54cadb225753c5fb
A lint-checks/integration-tests/src/main/java/androidx/ObsoleteCompatMethodMissingMultiLineReplaceWith.java
M lint-checks/src/main/java/androidx/build/lint/ObsoleteCompatDetector.kt
M lint-checks/src/test/java/androidx/build/lint/ObsoleteCompatDetectorTest.kt
ap...@google.com
We still have some constants that warrant deprecation and a handful of methods outside of core, but I think this is sufficient for now.
ap...@google.com
I see that LocationCompat.isMock was deprecated as part of this effort. This looks like a mistake: Location.isMockProvider was added in API 18, but deprecated in API 31, at which point Location.isMock was added. So there remains a need for this compatibility method.
I hope you can revert this one as part of this issue without requiring a separate issue for every single thing that may have gone wrong.
ap...@google.com
LocationCompat.isMock() calls directly through to the deprecated Location.isFromMockProvider() regardless of SDK level, which was a bad implementation to begin with.
ap...@google.com
Branch: androidx-main
commit 3b9df12d74b961741050fe589aae8003532ec248
Author: Alan Viverette <alanv@google.com>
Date: Wed Jun 12 17:01:10 2024
Undeprecate LocationCompat.isMock, fix delegation on API 31+
Relnote: """Reverts deprecation of LocationCompat.isMock and delegates
to the platform API on API level 31 and above."""
Fixes: 313834577
Test: LocationCompatTest
Change-Id: I559407ae8f2cce149cd2802322485f1b80cb85c9
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/location/LocationCompat.java
eg...@gmail.com
Thanks for the fix! I just noticed another one:
ParcelCompat.writeBoolean was deprecated with instructions to use Parcel.writeInt directly with a value of 0 or 1. This does not make sense. The point of ParcelCompat.writeBoolean was to complement Parcel.writeBoolean, which was introduced in API 29. Doesn't make sense to take it away now.
mg...@google.com
mg...@google.com
Likely, but I don't think we would have caught either of these during manual review. They were technically correct since the implementations were single-line and inlineable, so applying the replacement would still have the same runtime behavior (and bytecode if running an optimizer).
We'd need to go back through and audit methods that were originally written without a proper SDK_INT check.
mg...@google.com
pr...@google.com
Branch: androidx-main
commit 2d316160b6048996e91929c28ec33d91603900bb
Author: Alan Viverette <alanv@google.com>
Date: Thu Jun 13 14:10:24 2024
Undeprecate ParcelCompat.writeBoolean, fix delegation on API 29+
Relnote: """Reverts deprecation of ParcelCompat.writeBoolean and delegates
to the platform API on API level 29 and above."""
Bug: 313834577
Test: ParcelCompatTest
Change-Id: I9d2436d90f3cbe3bf22e2a3c97171f39b53cf040
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/os/ParcelCompat.java
ap...@google.com
Closing this out. There may still be one-offs, but let's use new bug reports for those.
ap...@google.com
Branch: androidx-main
commit bfa95f2a028916a70b45114cc3c32b42da8b9a7e
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Mar 28 15:18:59 2024
Align multiplatform `lock` with `synchronized` semantics in `viewmodel`
* Replaces `Lock` usage in `viewmodel` with `synchronized` semantics to reduce confusion with `ReentrantLock` and provide a more intuitive behaviour.
* Adopts the structure of `SynchronizedObject`, `synchronized`, and `synchronizedImpl` from `kotlin.coroutines.internal` to maintain consistency.
* Implements a workaround for the Kotlin issue KT-29963 (
Test: `lifecycle-viewmodel` tests
Bug: 214568825
Change-Id: I43c7a0dd4d6b5eac0e273f62b6d462188f96a0c2
M lifecycle/lifecycle-viewmodel/build.gradle
M lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/ViewModel.kt
D lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/Lock.kt
A lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/SynchronizedObject.kt
M lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/ViewModelImpl.kt
M lifecycle/lifecycle-viewmodel/src/jvmMain/kotlin/androidx/lifecycle/viewmodel/internal/SynchronizedObject.jvm.kt
M lifecycle/lifecycle-viewmodel/src/nativeMain/kotlin/androidx/lifecycle/viewmodel/internal/SynchronizedObject.native.kt
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.lifecycle:lifecycle-viewmodel:2.8.0-beta01androidx.lifecycle:lifecycle-viewmodel-android:2.8.0-beta01androidx.lifecycle:lifecycle-viewmodel-desktop:2.8.0-beta01androidx.lifecycle:lifecycle-viewmodel-iosarm64:2.8.0-beta01androidx.lifecycle:lifecycle-viewmodel-iossimulatorarm64:2.8.0-beta01androidx.lifecycle:lifecycle-viewmodel-iosx64:2.8.0-beta01androidx.lifecycle:lifecycle-viewmodel-linuxx64:2.8.0-beta01androidx.lifecycle:lifecycle-viewmodel-macosarm64:2.8.0-beta01androidx.lifecycle:lifecycle-viewmodel-macosx64:2.8.0-beta01
pa...@gmail.com
I couldn't find if there is a separate issue for this, but we should probably also port lifecycle-viewmodel-kts to KMP.
In the current 2.8.0-beta01, it's still defined only as an android library only:
Let me know if we need a new issue ticket for this piece of work :)
il...@google.com
Re -ktx modules are empty. You should just use the base artifacts.
Description
I am using compose-jb to make my app multiplatform, but I can't use ViewModel in my desktop app, I am trying to keep the same code for both platforms, but ViewModel is not available.
Going through the code, most of the classes can be easily made multiplatform.
ViewModelStore and ViewModel can be used very easy in desktop+android because of JVM.
Right now I have to create my own library that uses expect in the common module and copy paste the code from the source file to actual JVM implementation.