Fixed
Status Update
Comments
pb...@google.com <pb...@google.com> #2
See also
to...@gmail.com <to...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 1a48f33d2d01d135a0d647f83b1baaac10499ef0
Author: Chris Craik <ccraik@google.com>
Date: Tue Jan 25 12:35:23 2022
Clarify FrameTimingMetric names
Fixes: 216337830
Relnote: "Renamed FrameCpuTime -> FrameDurationCpu, FrameUiTime -> FrameDurationUi to clarify these are durations, not timestamps, and to match prefixes."
Test: ./gradlew benchmark:benchmark-common:cC
Test: TrivialListScrollBenchmark
Change-Id: I0eba35542431905ab926f5dc7db4ab6e292fde69
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/FrameTimingQuery.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/FrameTimingQueryTest.kt
https://android-review.googlesource.com/1960660
Branch: androidx-main
commit 1a48f33d2d01d135a0d647f83b1baaac10499ef0
Author: Chris Craik <ccraik@google.com>
Date: Tue Jan 25 12:35:23 2022
Clarify FrameTimingMetric names
Fixes: 216337830
Relnote: "Renamed FrameCpuTime -> FrameDurationCpu, FrameUiTime -> FrameDurationUi to clarify these are durations, not timestamps, and to match prefixes."
Test: ./gradlew benchmark:benchmark-common:cC
Test: TrivialListScrollBenchmark
Change-Id: I0eba35542431905ab926f5dc7db4ab6e292fde69
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/FrameTimingQuery.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/FrameTimingQueryTest.kt
za...@google.com <za...@google.com> #4
Willie to look if there is an easy way to expose the provider.
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit 025ca1611036a7ca409b6cf951b1a31ca0ebadc9
Author: Willie Koomson <wvk@google.com>
Date: Mon Mar 14 19:36:00 2022
Add ColorProvider.resolve()
This change adds a resolve() function to the ColorProvider interface,
which returns what color the provider will use in the given context.
Bug: 214733442
Test: ColorProviderTest
Relnote: Add ColorProvider.resolve()
Change-Id: Ife532c3a9d5093c727a979e56847915fe36a83ca
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/unit/ColorProviderTest.kt
M glance/glance-appwidget/src/test/res/values/colors.xml
M glance/glance/src/androidMain/kotlin/androidx/glance/unit/ColorProvider.kt
M glance/glance-wear-tiles/src/androidMain/kotlin/androidx/glance/wear/tiles/WearCompositionTranslator.kt
M glance/glance/api/current.txt
M glance/glance/api/public_plus_experimental_current.txt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/translators/TextTranslator.kt
M glance/glance/api/restricted_current.txt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/unit/ColorProvider.kt
https://android-review.googlesource.com/2025248
Branch: androidx-main
commit 025ca1611036a7ca409b6cf951b1a31ca0ebadc9
Author: Willie Koomson <wvk@google.com>
Date: Mon Mar 14 19:36:00 2022
Add ColorProvider.resolve()
This change adds a resolve() function to the ColorProvider interface,
which returns what color the provider will use in the given context.
Bug: 214733442
Test: ColorProviderTest
Relnote: Add ColorProvider.resolve()
Change-Id: Ife532c3a9d5093c727a979e56847915fe36a83ca
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/unit/ColorProviderTest.kt
M glance/glance-appwidget/src/test/res/values/colors.xml
M glance/glance/src/androidMain/kotlin/androidx/glance/unit/ColorProvider.kt
M glance/glance-wear-tiles/src/androidMain/kotlin/androidx/glance/wear/tiles/WearCompositionTranslator.kt
M glance/glance/api/current.txt
M glance/glance/api/public_plus_experimental_current.txt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/translators/TextTranslator.kt
M glance/glance/api/restricted_current.txt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/unit/ColorProvider.kt
Description
Component used: glance-appwidget Version used: 1.0 alpha1
It would be nice to be able to manually resolve ColorProvider to avoid code duplication. It's currently not possible as the DayNight provider is internal.
This is useful to modify the colors to add alpha (like disabled status) or manually apply tint since the API does not yet support it.