In an A -> B -> C navigation graph, 'exitAnim' transition from B -> C actually uses 'exitAnim' transition from A -> B if 'popUpTo="A"' is used. [214835303]

Fixed

Bug

Status Update

No update yet.

Description

pa...@bancointer.com.br

created issue #1

Jan 18, 2022 11:54AM

Component used: Fragment

Version used: 1.3.0, 1.4.0. Does not reproduce on 1.2.5.

Devices/Android versions reproduced on: Android Emulator.

Issue description

Given the following navigation graph:

<?xml version="1.0" encoding="utf-8"?>
<navigation xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:id="@+id/nav_graph"
    app:startDestination="@id/AFragment">

    <fragment
        android:id="@+id/AFragment"
        android:name="com.example.navigationanimationtest.AFragment"
        tools:layout="@layout/fragment_a">

        <action
            android:id="@+id/action_fragmentA_to_fragmentB"
            app:enterAnim="@anim/slide_in_from_right"
            app:exitAnim="@anim/slide_out_to_left"
            app:destination="@id/BFragment" />

    </fragment>

    <fragment
        android:id="@+id/BFragment"
        android:name="com.example.navigationanimationtest.BFragment"
        tools:layout="@layout/fragment_b">

        <action
            android:id="@+id/action_fragmentB_to_fragmentC"
            app:enterAnim="@anim/fadein"
            app:exitAnim="@anim/fadeout"
            app:destination="@id/CFragment"
            app:popUpTo="@id/AFragment" />

    </fragment>

    <fragment
        android:id="@+id/CFragment"
        android:name="com.example.navigationanimationtest.CFragment"
        tools:layout="@layout/fragment_c" />

</navigation>

Expected result:

I expect the following transition for the action action_fragmentB_to_fragmentC:

B exists with @anim/fadeout
C enters with @anim/fadein

See expected.mp4 attachment.

This is what actually happens with fragment:1.2.5, but is broken in 1.3.0 and 1.4.0.

Actual result

From fragment:1.3.0 onwards, what happens is that, when app:popUpTo="A" is used, and while A is in the backstack, the transition for the action action_fragmentB_to_fragmentC is different:

B exists with @anim/slide_out_to_left - Unexpected!
C enters with @anim/fadein

It seems that the navigation component uses the exitAnim transition from the previously executed action, @id/action_fragmentA_to_fragmentB.

Removing app:popUpTo="A" from the action resolves the issue.

See actual.mp4 attachment.

Reproducer

Attached minimal reproducer project: NavigationAnimationTest.zip.

For swapping fragment versions, comment/uncomment the following app/build.gradle lines:

configurations.all {
    resolutionStrategy {
//        force 'androidx.fragment:fragment:1.2.5' // -- works
        force 'androidx.fragment:fragment:1.4.0' // -- broken
    }
}

expected.mp4

158 KB

Download

actual.mp4

269 KB

Download

NavigationAnimationTest.zip

458 KB

Download

Comments

il...@google.com <il...@google.com> Jan 25, 2022 08:49PM

Assigned to jb...@google.com.

ro...@sparkistic.com <ro...@sparkistic.com> #2Mar 25, 2022 01:30AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

cu...@pocketprep.com <cu...@pocketprep.com> #3Jun 15, 2022 07:09PM

Ran into the same issue today with Fragment version 1.4.1.

al...@gmail.com <al...@gmail.com> #4Jul 9, 2022 01:26PM

Using androidx.navigation:navigation-fragment-ktx:2.5.0 and running into the same issue, please provide a workaround

al...@gmail.com <al...@gmail.com> #5Jul 9, 2022 01:49PM

Comment has been deleted.

Message last modified on Jul 9, 2022 01:51PM

ap...@google.com <ap...@google.com> #6Jul 27, 2022 04:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 937fa523a427c942b00b9dcb5f056b5d03454160
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Jul 20 16:56:50 2022

Move all Fragment animations in the same direction

Say you have 3 fragments, A, B, and C. If you add A and B with one set
of entering and exiting animations. And then pop B, before adding C with
an different set of entering and exiting animations while using the
recommended setReorderingAllowed=true flag on your fragment
transactions, it is possible to get in a scenario where the visible
exiting fragment, B, uses the animations from the popping opertion to A
instead of the adding operation with C.

The reason for this is that the animations for B are set during the
first operation with the pop from B to A. The system is then
techinically doing a replace operation from A to C, since B has already
been popped, so it sets the proper animations on A and leaves B
untouched. This causes B to run the stale animations from the pop
instead of the current animations from the replace.

We should ensure that we always run the animations from the operation
that determines what will be visible to user on the screen.

RelNote: "Fragments will now run the proper animations when mixing pop
and replace operations."
Test: added FragmentAnimationTest
Bug: 214835303

Change-Id: Ib1c07bd0e05c0c1a3d785e29456bad9afb183e2d

M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentAnimationTest.kt

https://android-review.googlesource.com/2161123

de...@gmail.com <de...@gmail.com> #7Aug 6, 2022 09:23PM

Good day, was this solved with the latest version or by changing the code itself?

de...@gmail.com <de...@gmail.com> #8Aug 6, 2022 09:39PM

I am still experiencing `exitAnim` not working when using `popUpTo` with the latest fragment-ktx:1.6.0 and navigation-fragment-ktx:2.5.1

jb...@google.com <jb...@google.com> #9Aug 8, 2022 07:06PM

Marked as fixed.

This has been fixed internally and will be available in the Fragment 1.5.2 release.

de...@gmail.com <de...@gmail.com> #10Aug 10, 2022 08:24PM

How about for fragment-ktx:1.6.0 ?

Issue 214835303

Description

Issue summary

Comments

il...@google.com <il...@google.com> Jan 25, 2022 08:49PM

ro...@sparkistic.com <ro...@sparkistic.com> #2Mar 25, 2022 01:30AM

cu...@pocketprep.com <cu...@pocketprep.com> #3Jun 15, 2022 07:09PM

al...@gmail.com <al...@gmail.com> #4Jul 9, 2022 01:26PM

al...@gmail.com <al...@gmail.com> #5Jul 9, 2022 01:49PM

ap...@google.com <ap...@google.com> #6Jul 27, 2022 04:27PM

de...@gmail.com <de...@gmail.com> #7Aug 6, 2022 09:23PM

de...@gmail.com <de...@gmail.com> #8Aug 6, 2022 09:39PM

jb...@google.com <jb...@google.com> #9Aug 8, 2022 07:06PM

de...@gmail.com <de...@gmail.com> #10Aug 10, 2022 08:24PM

Add comment

Issue metadata