Fixed
Status Update
No update yet.
Comments
jn...@google.com
Regression appears to have been caused by aosp/2758367
jn...@google.com
We should probably update the benchmark to use the new flags to turn off the animations.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 136cfb249a9623d712b82db6b0832ccd63e3e582
Author: mkulaha <mkulaha@google.com>
Date: Wed Oct 04 08:05:18 2023
Possible fix for performance drop in PositionIndicator. Additional microbenchmark tests were added.
We saw some performance drops in PositionIndicator, that might happen due to chained snapshotFlow, which slows down the `firstPixel` benchmark.
Extra tests were added to separately check animated and non-animated PositionIndicator
Doc with benchmark results go/position-indicator-aosp_2770702
Bug: 302399827
Test: PositionIndicatorBenchmark.kt
Relnote: "Fixed performance issues in PositionIndicator"
Change-Id: I1c6546abc834f718c9d8f11d756262d507590acc
M wear/compose/compose-material/benchmark/src/androidTest/java/androidx/wear/compose/material/benchmark/PositionIndicatorBenchmark.kt
M wear/compose/compose-material/src/main/java/androidx/wear/compose/material/PositionIndicator.kt
https://android-review.googlesource.com/2770702
Branch: androidx-main
commit 136cfb249a9623d712b82db6b0832ccd63e3e582
Author: mkulaha <mkulaha@google.com>
Date: Wed Oct 04 08:05:18 2023
Possible fix for performance drop in PositionIndicator. Additional microbenchmark tests were added.
We saw some performance drops in PositionIndicator, that might happen due to chained snapshotFlow, which slows down the `firstPixel` benchmark.
Extra tests were added to separately check animated and non-animated PositionIndicator
Doc with benchmark results go/position-indicator-aosp_2770702
Bug: 302399827
Test: PositionIndicatorBenchmark.kt
Relnote: "Fixed performance issues in PositionIndicator"
Change-Id: I1c6546abc834f718c9d8f11d756262d507590acc
M wear/compose/compose-material/benchmark/src/androidTest/java/androidx/wear/compose/material/benchmark/PositionIndicatorBenchmark.kt
M wear/compose/compose-material/src/main/java/androidx/wear/compose/material/PositionIndicator.kt
Description
Based on feedback from developers there is a need to provide support to make it easy to ensure that all list items can be placed in the center of a ScalingLazyColumn viewport. That is that if they have an offset of 0 they would be placed centrally without the developer needing to try and work out how much vertical contentPadding to provide.