[M2] BottomSheetScaffold sheetGestures disabled but gestures still works when child component is scrollable [215403277]

Fixed

Bug

Status Update

No update yet.

Description

gu...@googlemail.com

created issue #1

Jan 20, 2022 11:12AM

Jetpack Compose release version: 1.1.0-rc01
Android Studio Build: Android Studio Arctic Fox | 2020.3.1 Patch 4
Kotlin version: 1.6.10

Steps to Reproduce

Implemented a BottomSheetScaffold with sheetGesturesEnabled set to false like the following:

 BottomSheetScaffold(
        sheetGesturesEnabled = false,
        sheetContent = { MyContent() },
        scaffoldState = bottomSheetScaffoldState,
    ) {
        ..
    }

Add a scrollable composable to the MyContent() like LazyColumn with a Modifier set to .fillMaxSize()

Expectation

The BottomSheet swipe to close gesture of the BottomSheet should be disabled but I should still be able to scroll inside the scrollable content.

Actual

I can still close the bottom sheet via swipe to close or to be more specific via swiping down the bottom sheet. However, the content inside is also scrollable as expected.

Further thoughts

It seems like that a scrollable component as content for the bottom sheet overrides the sheetGesturesEnabled setting.

Comments

ma...@google.com <ma...@google.com> Jan 20, 2022 03:32PM

Assigned to ma...@google.com.

sh...@gmail.com <sh...@gmail.com> #2Jun 13, 2022 02:33PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ma...@google.com <ma...@google.com> #3Jun 13, 2022 02:43PM

Reassigned to jo...@google.com.

Hello. No updated to share yet, sorry

[Deleted User] <[Deleted User]> #4Oct 11, 2022 09:19AM

Hello, is it fixed in some new compose versions ? Thanks a lot

li...@gmail.com <li...@gmail.com> #5Dec 13, 2022 07:50AM

Hello, is it fixed in some new compose versions ? Thanks a lot

li...@gmail.com <li...@gmail.com> #6Dec 13, 2022 07:55AM

val sheetState = rememberBottomSheetState(
initialValue = BottomSheetValue.Collapsed,
confirmStateChange = {
it != BottomSheetValue.Collapsed
})
val sheetScaffoldState = rememberBottomSheetScaffoldState(
bottomSheetState = sheetState
)

jo...@google.com <jo...@google.com> #7Dec 28, 2022 01:58PM

Hi, nothing to share yet. We will update this issue when we get to it!

be...@gmail.com <be...@gmail.com> #8Feb 11, 2023 03:45AM

Thank you...hoping this will get fixed soon

jo...@ifood.com.br <jo...@ifood.com.br> #9Mar 13, 2023 06:02PM

Do we have any updates for this bug? or some "workaround" to solve the problem?

[Deleted User] <[Deleted User]> #10Mar 14, 2023 04:39AM

Hello, is it fixed in some new compose versions ? Thanks a lot

wk...@gmail.com <wk...@gmail.com> #11Mar 31, 2023 06:43AM

hello. I solved the problem and want to share it with a comment. The cause of the problem is that swipeable and nestedScroll are used at the same time in BottomSheetScaffold. Even if sheetGesturesEnabled param is passed to swipeable, gestures are operated by nestedScroll. So anyway, if sheetGesturesEnabled is false, nestedScroll is a meaningless modifier, so it doesn't have to be included in the modifier tree.

The problem was solved by forking BottomSheetScaffold and using nestedScroll as follows. It would be nice to refer to it from the google team.

private fun Modifier.nestedScrollIfSheetGesturesEnabled(
     connection: NestedScrollConnection,
     dispatcher: NestedScrollDispatcher? = null,
     sheetGesturesEnabled: Boolean = true;
): Modifier {
     return this.let {
         if (sheetGesturesEnabled) {
             it.nestedScroll(connection, dispatcher)
         } else {
             it
         }
     }
}

Message last modified on Mar 31, 2023 06:45AM

ap...@google.com <ap...@google.com> #12Mar 31, 2023 03:21PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 7c9f451aeab809245bc55678568421e12c857ca9
Author: Jossi Wolf <jossiwolf@google.com>
Date: Fri Mar 31 09:32:55 2023

[M2] Disable BottomSheetScaffold nested scroll when gesturesDisabled

Test: bottomSheetScaffold_gesturesDisabled_doesNotParticipateInNestedScroll
Relnote: `BottomSheetScaffold` will not participate in nested scroll anymore when `gesturesEnabled` is set to `false`.
Fixes: 215403277
Change-Id: I634f33bf0d7e6b4dea5d2225c8e7561b74a42d40

M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomSheetScaffoldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt

https://android-review.googlesource.com/2517195

jo...@google.com <jo...@google.com> #13Mar 31, 2023 03:24PM

Thanks! Had this locally for a few months but never got around to writing the test. This should be included in one or two releases from now.

qd...@gmail.com <qd...@gmail.com> #14Apr 18, 2023 01:13PM

When can I upload the production environment

pr...@google.com <pr...@google.com> #15Apr 19, 2023 06:12PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.5.0-alpha03

de...@gmail.com <de...@gmail.com> #16Sep 23, 2023 05:31PM

material3 had same issue

ya...@gmail.com <ya...@gmail.com> #17Jan 18, 2024 11:10PM

The similar issue exists in material3 modal BottomSheet, there should be a functionality where swiping down of bottomsheet should be disabled but it should be allowed to dismiss it by clicking outside or by back button.

Message last modified on Jan 18, 2024 11:12PM

jo...@gmail.com <jo...@gmail.com> #18Jan 31, 2024 11:49PM

Yes, a bottom sheet modal with an ability for no swipe away is a necessity in app development. A back button can send the sheet away. This is common functionality in mobile apps.

Only commenting because this issue still exists.

Message last modified on Jan 31, 2024 11:50PM

jo...@toyrocketscience.com <jo...@toyrocketscience.com> #19Feb 21, 2024 08:57AM

The similar issue exists in material3 modal BottomSheet, there should be a functionality where swiping down of bottomsheet should be disabled but it should be allowed to dismiss it by clicking outside or by back button.

+1 I also stumbled over this. Is there a place where we can add this as a feature request?

be...@gmail.com <be...@gmail.com> #20Apr 15, 2024 07:09AM

I am too impacted by this, Having BottomSheetScaffold with sheetSwipeEnabled set to false. The Lazy Column scroll in the sheetContent still causing the bottom sheet to drag and close.

og...@gmail.com <og...@gmail.com> #21Apr 21, 2024 06:42PM

2024 still bug. Everyone using material3. And most common component in mobile apps still have bug even a lot people open issue. SHIT SHOW.

EDIT:: OOOOOOOO IM SO SORRY. I DIDN'T SEE @OptIn(ExperimentalMaterial3Api::class).
LOOKS LIKE A SIMPLE COMPONENT WILL BE RELEASE IN 2030 or 2050 ???? . Sorry MY BAD !!

Message last modified on Apr 21, 2024 06:47PM

de...@gmail.com <de...@gmail.com> #22Apr 25, 2024 07:40PM

I have the same problem, using the latest BOM as of now (androidx.compose:compose-bom:2024.04.01 - despite disabling gestures I can swill swipe down the bottom sheet inside the bottom sheet content area. Why is this issue still open after 2 years?

kr...@gmail.com <kr...@gmail.com> #23Jun 16, 2024 10:45AM

I have the same issue... I tried to make that functionality look good, but I cannot because of it...

an...@minglr.eu <an...@minglr.eu> #24Jun 20, 2024 02:58PM

I have the same issue using material3!

hl...@jaguarlandrover.com <hl...@jaguarlandrover.com> #25Sep 25, 2024 12:26PM

The issue is still remaining, currently i see there is a space for dragHandle on the top of BottomSheet ui, is there anyway to disable drag action inside content of the sheet?

Issue 215403277

Description

Steps to Reproduce

Expectation

Actual

Further thoughts

Issue summary

Comments

ma...@google.com <ma...@google.com> Jan 20, 2022 03:32PM

sh...@gmail.com <sh...@gmail.com> #2Jun 13, 2022 02:33PM

ma...@google.com <ma...@google.com> #3Jun 13, 2022 02:43PM

[Deleted User] <[Deleted User]> #4Oct 11, 2022 09:19AM

li...@gmail.com <li...@gmail.com> #5Dec 13, 2022 07:50AM

li...@gmail.com <li...@gmail.com> #6Dec 13, 2022 07:55AM

jo...@google.com <jo...@google.com> #7Dec 28, 2022 01:58PM

be...@gmail.com <be...@gmail.com> #8Feb 11, 2023 03:45AM

jo...@ifood.com.br <jo...@ifood.com.br> #9Mar 13, 2023 06:02PM

[Deleted User] <[Deleted User]> #10Mar 14, 2023 04:39AM

wk...@gmail.com <wk...@gmail.com> #11Mar 31, 2023 06:43AM

ap...@google.com <ap...@google.com> #12Mar 31, 2023 03:21PM

jo...@google.com <jo...@google.com> #13Mar 31, 2023 03:24PM

qd...@gmail.com <qd...@gmail.com> #14Apr 18, 2023 01:13PM

pr...@google.com <pr...@google.com> #15Apr 19, 2023 06:12PM

de...@gmail.com <de...@gmail.com> #16Sep 23, 2023 05:31PM

ya...@gmail.com <ya...@gmail.com> #17Jan 18, 2024 11:10PM

jo...@gmail.com <jo...@gmail.com> #18Jan 31, 2024 11:49PM

jo...@toyrocketscience.com <jo...@toyrocketscience.com> #19Feb 21, 2024 08:57AM

be...@gmail.com <be...@gmail.com> #20Apr 15, 2024 07:09AM

og...@gmail.com <og...@gmail.com> #21Apr 21, 2024 06:42PM

de...@gmail.com <de...@gmail.com> #22Apr 25, 2024 07:40PM

kr...@gmail.com <kr...@gmail.com> #23Jun 16, 2024 10:45AM

an...@minglr.eu <an...@minglr.eu> #24Jun 20, 2024 02:58PM

hl...@jaguarlandrover.com <hl...@jaguarlandrover.com> #25Sep 25, 2024 12:26PM

Add comment

Issue metadata