[M2] BottomSheetScaffold sheetGestures disabled but gestures still works when child component is scrollable [215403277]

Fixed

Bug

Status Update

No update yet.

Description

gu...@googlemail.com

created issue #1

Jan 20, 2022 11:12AM

Jetpack Compose release version: 1.1.0-rc01
Android Studio Build: Android Studio Arctic Fox | 2020.3.1 Patch 4
Kotlin version: 1.6.10

Steps to Reproduce

Implemented a BottomSheetScaffold with sheetGesturesEnabled set to false like the following:

 BottomSheetScaffold(
        sheetGesturesEnabled = false,
        sheetContent = { MyContent() },
        scaffoldState = bottomSheetScaffoldState,
    ) {
        ..
    }

Add a scrollable composable to the MyContent() like LazyColumn with a Modifier set to .fillMaxSize()

Expectation

The BottomSheet swipe to close gesture of the BottomSheet should be disabled but I should still be able to scroll inside the scrollable content.

Actual

I can still close the bottom sheet via swipe to close or to be more specific via swiping down the bottom sheet. However, the content inside is also scrollable as expected.

Further thoughts

It seems like that a scrollable component as content for the bottom sheet overrides the sheetGesturesEnabled setting.

Comments

ma...@google.com <ma...@google.com> Jan 20, 2022 03:32PM

Assigned to ma...@google.com.

sh...@gmail.com <sh...@gmail.com> #2Jun 13, 2022 02:33PM

Hey Jose, do we have any plans to support this? Feel free to assign back if this should be a new feature request.

ma...@google.com <ma...@google.com> #3Jun 13, 2022 02:43PM

Reassigned to jo...@google.com.

Is this meant to be material or material3 bottom sheets, and for bottomsheetscaffold, modalbottomsheet, or both?

[Deleted User] <[Deleted User]> #4Oct 11, 2022 09:19AM

Assigning to Clara who has pending CL's open on this topic

li...@gmail.com <li...@gmail.com> #5Dec 13, 2022 07:50AM

This is meant for the BottomSheet that is integrated with androidx.navigation. So it is just for material for now.

li...@gmail.com <li...@gmail.com> #6Dec 13, 2022 07:55AM

Can you please share estimated timeline for this feature?

jo...@google.com <jo...@google.com> #7Dec 28, 2022 01:58PM

Project: platform/frameworks/support
Branch: androidx-main

commit 00c37d0b6949835a7e8a2f68eb037c57bfc727fe
Author: Clara Fok <clarafok@google.com>
Date: Mon Jul 22 18:20:05 2024

Add bottomSheet constructor with safe args

Add NavGraphBuilder.bottomSheet builder to create a bottomSheet with safe args.

Test: ./gradlew compose:material:material-navigation:cC
Bug: 351858980
Relnote: "Added new NavGraphBuilder.bottomSheet builder to create a bottomSheet with safe args"
Change-Id: I28589fd1d67de6a23167e6a7648f15d95ed4beb3

M compose/material/material-navigation/api/current.txt
M compose/material/material-navigation/api/restricted_current.txt
M compose/material/material-navigation/build.gradle
M compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/NavGraphBuilderTest.kt
M compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheetNavigatorDestinationBuilder.kt
M compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/NavGraphBuilder.kt

https://android-review.googlesource.com/3188302

be...@gmail.com <be...@gmail.com> #8Feb 11, 2023 03:45AM

Project: platform/frameworks/support
Branch: androidx-main

commit fcc5e50056fef5c3a8e6e5ca6672117d58685520
Author: Clara Fok <clarafok@google.com>
Date: Mon Jul 22 17:38:13 2024

Add BottomSheetNavigatorDestinationBuilder

Refactor BottomSheet to use NavDestinationBuilder so that we can leverage existing infrastrcuture to create type-safe BottomSheet in a follow-up CL.

Test: existing tests
Bug: 351858980
Relnote: "Added new BottomSheetNavigatorDestinationBuilder to create a BottomSheetNavigator.Destination with Kotlin DSL"
Change-Id: I777dbf640b83cd3428fd37c4ff5a8065f9ff856e

M compose/material/material-navigation/api/current.txt
M compose/material/material-navigation/api/restricted_current.txt
M compose/material/material-navigation/build.gradle
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheetNavigatorDestinationBuilder.kt
M compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/NavGraphBuilder.kt

https://android-review.googlesource.com/3188301

jo...@ifood.com.br <jo...@ifood.com.br> #9Mar 13, 2023 06:02PM

Public release date TBD but in the meantime, this new feature can be accessed through public snapshot builds.

[Deleted User] <[Deleted User]> #10Mar 14, 2023 04:39AM

Passing to Jose regarding release

wk...@gmail.com <wk...@gmail.com> #11Mar 31, 2023 06:43AM

Any update on the release date please?

Message last modified on Mar 31, 2023 06:45AM

ap...@google.com <ap...@google.com> #12Mar 31, 2023 03:21PM

Marked as fixed.

I ma still waiting for the release. I have tried the SNAPSHOT version but that also requires androidCompileSdkVersion = 35, which is inconvenient with all the edge-to-edge changes. Is it possible to have the release and not require androidCompileSdkVersion 35?

jo...@google.com <jo...@google.com> #13Mar 31, 2023 03:24PM

It was merged only to material, not material3...

https://developer.android.com/jetpack/androidx/releases/compose-material

But Material3 still missing this feature:

https://developer.android.com/jetpack/androidx/releases/compose-material3 so when you are using only material3 (as we do), we are still missing it.

qd...@gmail.com <qd...@gmail.com> #14Apr 18, 2023 01:13PM

When navigating to a destination created with NavGraphBuilder.bottomsheet(), backstack entry is now created BUT nothing is displayed on the screen. When navigating to the same .bottomSheet() destination again, it is just adding a new backstack entry again and again and again, but nothing is displayed on the screen.

pr...@google.com <pr...@google.com> #15Apr 19, 2023 06:12PM

Any updates? Will M3 be able to access NavGraphBuilder.bottomSheet on the next stable release? Regular material has this planned according to: https://issuetracker.google.com/issues/376169507

de...@gmail.com <de...@gmail.com> #16Sep 23, 2023 05:31PM

material3 had same issue

ya...@gmail.com <ya...@gmail.com> #17Jan 18, 2024 11:10PM

The similar issue exists in material3 modal BottomSheet, there should be a functionality where swiping down of bottomsheet should be disabled but it should be allowed to dismiss it by clicking outside or by back button.

Message last modified on Jan 18, 2024 11:12PM

jo...@gmail.com <jo...@gmail.com> #18Jan 31, 2024 11:49PM

Yes, a bottom sheet modal with an ability for no swipe away is a necessity in app development. A back button can send the sheet away. This is common functionality in mobile apps.

Only commenting because this issue still exists.

Message last modified on Jan 31, 2024 11:50PM

jo...@toyrocketscience.com <jo...@toyrocketscience.com> #19Feb 21, 2024 08:57AM

The similar issue exists in material3 modal BottomSheet, there should be a functionality where swiping down of bottomsheet should be disabled but it should be allowed to dismiss it by clicking outside or by back button.

+1 I also stumbled over this. Is there a place where we can add this as a feature request?

be...@gmail.com <be...@gmail.com> #20Apr 15, 2024 07:09AM

I am too impacted by this, Having BottomSheetScaffold with sheetSwipeEnabled set to false. The Lazy Column scroll in the sheetContent still causing the bottom sheet to drag and close.

og...@gmail.com <og...@gmail.com> #21Apr 21, 2024 06:42PM

2024 still bug. Everyone using material3. And most common component in mobile apps still have bug even a lot people open issue. SHIT SHOW.

EDIT:: OOOOOOOO IM SO SORRY. I DIDN'T SEE @OptIn(ExperimentalMaterial3Api::class).
LOOKS LIKE A SIMPLE COMPONENT WILL BE RELEASE IN 2030 or 2050 ???? . Sorry MY BAD !!

Message last modified on Apr 21, 2024 06:47PM

de...@gmail.com <de...@gmail.com> #22Apr 25, 2024 07:40PM

I have the same problem, using the latest BOM as of now (androidx.compose:compose-bom:2024.04.01 - despite disabling gestures I can swill swipe down the bottom sheet inside the bottom sheet content area. Why is this issue still open after 2 years?

kr...@gmail.com <kr...@gmail.com> #23Jun 16, 2024 10:45AM

I have the same issue... I tried to make that functionality look good, but I cannot because of it...

an...@minglr.eu <an...@minglr.eu> #24Jun 20, 2024 02:58PM

I have the same issue using material3!

hl...@jaguarlandrover.com <hl...@jaguarlandrover.com> #25Sep 25, 2024 12:26PM

The issue is still remaining, currently i see there is a space for dragHandle on the top of BottomSheet ui, is there anyway to disable drag action inside content of the sheet?