Macrobench metric support for multiprocess apps [215988434]

Fixed

Bug

Status Update

No update yet.

Description

wu...@gmail.com

created issue #1

Jan 24, 2022 03:12AM

Component used:StartupTimingMetric
Version used:1.1.0-alpha13
Devices/Android versions reproduced on:R

测试工程说明：
测试项目为多进程项目，包名com.example.demo, 但是应用的所有UI界面实现在com.example.demo:ui进程。

问题原因分析：
getMetrics方法中调用StartupTimingQuery.getFrameSubMetrics 参数传入的是PackageName，参数来源是
Marcobenchmark.kt
val iterationResult = userspaceTrace("extract metrics") {
metrics
// capture list of Map<String,Long> per metric
.map { it.getMetrics(Metric.CaptureInfo(
targetPackageName = packageName,
testPackageName = macrobenchPackageName,
startupMode = startupModeMetricHint,
apiLevel = Build.VERSION.SDK_INT
), tracePath) }
// merge into one map
.reduce { sum, element -> sum + element }
}
查询语句：val queryResult = PerfettoTraceProcessor.rawQuery(
absoluteTracePath = absoluteTracePath,
query = getFullQuery(
testProcessName = testPackageName,
targetProcessName = targetPackageName
)
)

private fun getFullQuery(testProcessName: String, targetProcessName: String) = """
------ Select all startup-relevant slices from slice table
SELECT

slice.name as name,
slice.ts as ts,
slice.dur as dur
FROM slice
INNER JOIN thread_track on slice.track_id =

thread_track.id
INNER JOIN thread USING(utid)
INNER JOIN process USING(upid)
WHERE (
(

process.name LIKE "$testProcessName" AND

slice.name LIKE "startActivityAndWait") OR
(

process.name LIKE "$targetProcessName" AND (
(

slice.name LIKE "activityResume" AND process.pid LIKE thread.tid) OR
(

slice.name LIKE "Choreographer#doFrame%" AND process.pid LIKE thread.tid) OR
(

slice.name LIKE "reportFullyDrawn() for %" AND process.pid LIKE thread.tid) OR
(

slice.name LIKE "DrawFrame%" AND

thread.name LIKE "RenderThread")
)
) OR
(
-- Signals beginning of launch event, only present in API 29+

process.name LIKE "system_server" AND

slice.name LIKE "MetricsLogger:launchObserverNotifyIntentStarted"
)
)
------ Add in async slices
UNION
SELECT

slice.name as name,
slice.ts as ts,
slice.dur as dur
FROM slice
INNER JOIN process_track on slice.track_id =

process_track.id
INNER JOIN process USING(upid)
WHERE (
-- API 23+: "launching: <target>"
-- API 19-22: "launching"

slice.name LIKE "launching%" AND

process.name LIKE "system_server"
)
ORDER BY ts ASC
""".trimIndent()

会将packagename 作为限制条件，导致查询不到结果。

对于用户，不能修改这个参数，来达到查询正确进程的目的。

修改建议：
（1）对于Metric 对象是特定进程的时候，开放参数传入指定进程名（默认值是包名）。比如：FrameTimingGfxInfoMetric，FrameTimingMetric，StartupTimingMetric。

（2）目前Metric 是sealed的，建议开放给用户，给用户更多自定义Metric 的空间。

Comments

ra...@google.com <ra...@google.com> #2Jan 24, 2022 08:02PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

cc...@google.com <cc...@google.com> #3Jan 25, 2022 01:01AM

Would the following change to app process.name matching work for your scenario, to make it match your :ui process?

(process.name LIKE "$targetProcessName") OR (process.name LIKE "$targetProcessName:%") (I should probably also rename that variable targetPackageName since it's not process name).

I'd like to avoid adding an API for this if we can, so it will simply work for multiprocess apps.

We do plan to open up other means of constructing your own metric, but are focusing on getting to a stable release first.

wu...@gmail.com <wu...@gmail.com> #4Feb 8, 2022 08:00AM

通过包名与进程名间的模糊匹配是可以解决绝大部分的多进程问题的。

通过一段时间对Macrobench的使用，发现他是一个很好的工具，也希望稳定版本能够尽早推出。

ap...@google.com <ap...@google.com> #5Feb 16, 2022 03:22AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 7f32b0df3abea8533bd1d926dd3058fe961e113e
Author: Chris Craik <ccraik@google.com>
Date: Mon Feb 14 17:19:06 2022

Support metrics from named UI subprocesses in multi-process apps

Fixes: 215988434
Relnote: Support metrics from named UI subprocesses in multi-process apps
Test: SeparateProcessBenchmark

Change-Id: Ice6c0360953f464641774b0a1056af7015ecf8de

M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/FrameTimingQuery.kt
A benchmark/integration-tests/macrobenchmark-target/src/main/java/androidx/benchmark/integration/macrobenchmark/target/SeparateProcessActivity.kt
A benchmark/integration-tests/macrobenchmark/src/androidTest/java/androidx/benchmark/integration/macrobenchmark/SeparateProcessBenchmark.kt
M benchmark/integration-tests/macrobenchmark-target/src/main/AndroidManifest.xml
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoTraceProcessor.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/StartupTimingQuery.kt

https://android-review.googlesource.com/1986569

cc...@google.com <cc...@google.com> #6Feb 16, 2022 03:38AM

Re #comment4 - thanks, fuzzy matching just landed above, please try it out (should be available in next beta 04) and let us know if that works for you. We're working through bugs to get to stable, hopefully fairly soon.

To your earlier point, about opening up the metrics APIs, I agree, and we'll be looking into that for 1.2 - b/219851406

Thanks for the bug report!

Message last modified on Feb 16, 2022 03:39AM

Issue 215988434