Baseline profiles generated with a test flagged as syntactically incorrect during next builds [216508418]

Fixed

Feature Request

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Jan 26, 2022 09:52PM

Hello, I've followed

the tutorials outlined here:

to generate and then use profiles for my app startup scenario.

Generation of the profiles went as planned - with baseline-prof generated on the emulator. When I copied the file to my app though, and tried to build it and run the tests that would measure the efficiency of those profiles, gradle complained about several syntax errors in the generated profiles (idk if they really are syntax errors).

The errors looked like this:

//    > A failure occurred while executing com.android.build.gradle.internal.tasks.CompileArtProfileTask$CompileArtProfileWorkAction
//    > Error parsing baseline-prof.txt : baseline-prof.txt:4833:97 error: Unexpected text:"+]Lcom/google/android/gms/measurement/internal/zzee;megamorphic_types" after the rule.
//    HSPLcom/google/android/gms/measurement/internal/zzeg;->zza(Ljava/lang/Object;)Ljava/lang/Object;+]Lcom/google/android/gms/measurement/internal/zzee;megamorphic_types

iirc, errors were also detected along the lines that started with '[', like this one: [Landroidx/appcompat/app/AppCompatDelegateImpl$PanelFeatureState;

I eventually went ahead and removed all patterns that resembled the failing ones (maybe removing too much), and the diff results were (unmodified profile diffed against one I edited manually:

576c576
< HSPLandroidx/constraintlayout/solver/ArrayLinkedVariables;->put(Landroidx/constraintlayout/solver/SolverVariable;F)V+]Landroidx/constraintlayout/solver/SolverVariable;Landroidx/constraintlayout/solver/SolverVariable;
---
> HSPLandroidx/constraintlayout/solver/ArrayLinkedVariables;->put(Landroidx/constraintlayout/solver/SolverVariable;F)V+]Landroidx/constraintlayout/solver/SolverVariable;
4833c4833
< HSPLcom/google/android/gms/measurement/internal/zzeg;->zza(Ljava/lang/Object;)Ljava/lang/Object;+]Lcom/google/android/gms/measurement/internal/zzee;megamorphic_types
---
> HSPLcom/google/android/gms/measurement/internal/zzeg;->zza(Ljava/lang/Object;)Ljava/lang/Object;
7322c7322
< HSPLcom/google/gson/internal/bind/TypeAdapters$7;->read(Lcom/google/gson/stream/JsonReader;)Ljava/lang/Number;+]Lcom/google/gson/stream/JsonReader;Lcom/google/gson/stream/JsonReader;
---
> HSPLcom/google/gson/internal/bind/TypeAdapters$7;->read(Lcom/google/gson/stream/JsonReader;)Ljava/lang/Number;
15176c15176
< HSPLtv/twitch/android/shared/experiments/MiniExperimentFetcher;->parseMiniExperimentModel(Ljava/lang/String;Lorg/json/JSONObject;)Ltv/twitch/android/provider/experiments/MiniExperimentModel;+]Lcom/google/gson/Gson;Lcom/google/gson/Gson;
---
> HSPLtv/twitch/android/shared/experiments/MiniExperimentFetcher;->parseMiniExperimentModel(Ljava/lang/String;Lorg/json/JSONObject;)Ltv/twitch/android/provider/experiments/MiniExperimentModel;
21921,22086c21921,22086
< [Landroidx/appcompat/app/AppCompatDelegateImpl$PanelFeatureState;
< [Landroidx/constraintlayout/solver/ArrayRow;
< [Landroidx/constraintlayout/solver/SolverVariable$Type;
< [Landroidx/constraintlayout/solver/SolverVariable;
(lot of lines starting with `[` - I just removed the initial `[`)

We'd really love to use the new baseline profiling feature - let me know if there's more I can share to confirm where the issue might be.

Component used/Version used: in the tests that generated the profile:

androidx.benchmark:benchmark-macro-junit4:1.1.0-beta01 in the app
androidx.profileinstaller:profileinstaller:1.2.0-alpha01"

Devices/Android versions reproduced on:

Gradle build using Gradle 7.3, AGP 7.1

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue.
A screenrecord or screenshots showing the issue (if UI related).

Comments

cc...@google.com <cc...@google.com> Jan 26, 2022 10:23PM

Reassigned to ra...@google.com.

[Deleted User] <[Deleted User]> #2Jan 27, 2022 05:09PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ra...@google.com <ra...@google.com> #3Jan 27, 2022 05:50PM

[ is an array specifier. This is unsupported. This is why the baseline profile compilation step fails.

Removing [ specifiers and keeping the rest of the rule should work. So you can turn [Landroidx/appcompat/app/AppCompatDelegateImpl$PanelFeatureState; to Landroidx/appcompat/app/AppCompatDelegateImpl$PanelFeatureState;

Let me look into this further, to see if there might be some post-processing that we might need.

Thanks for the bug report.

ra...@google.com <ra...@google.com> #4Jan 28, 2022 08:45PM

Looks like we support [ qualified rules, to optimize for things like indexed access, and properties like .length on the underlying type. This was added in Android S.

ART profiles on P don't support this. We could have the Baseline Profile Compiler ignore this rule, because we can't really take advantage of this. In the meantime, you can generate Baseline Profiles on an emulator running Android P -> R.

Message last modified on Jan 28, 2022 08:51PM

[Deleted User] <[Deleted User]> #5Jan 28, 2022 08:48PM

on an emulator running Android P -> R.

Thanks, so it should be running P, R, or either one is fine? Does minSdk/targetSdk of the app being profiled matter?

ra...@google.com <ra...@google.com> #6Jan 28, 2022 08:52PM

No, it does not. We transcode the profile to the right targetSdkVersion.

cc...@google.com <cc...@google.com> #7Feb 1, 2022 09:51PM

Adding to benchmark 1.1 hotlist so we can workaround this by filtering these rules out until AGP profgen can handle them.

ra...@google.com <ra...@google.com> Feb 10, 2022 07:31PM

Accepted by ra...@google.com.

ap...@google.com <ap...@google.com> #8Feb 11, 2022 06:08PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit b2a48d1f792432a647e9a5ef15dd9fce4bb12a1f
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Thu Feb 10 11:23:02 2022

Filter profile rules to target Android P.

Test: Ran intergration tests on device running Android S.
Fixes:

b/216508418

Change-Id: I09d70fa23febd55a97217d01c5000c88b08edd41

M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/BaselineProfiles.kt
A benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/BaselineProfilesTest.kt

https://android-review.googlesource.com/1980331