Fixed
Status Update
Comments
cc...@google.com <cc...@google.com>
[Deleted User] <[Deleted User]> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit c9e90d1e5671b7e6a8880aecbe32bb13f4b37560
Author: Siyamed Sinir <siyamed@google.com>
Date: Thu Oct 31 11:30:30 2019
Remove font related TODOs
- Ability to read font weight from the font b/143700963
- Support for font collections b/122476423
- Support for variable fonts b/143703328
- support for multiple font family b/127483182
- BaselineShift.lerp b/143699225
Test: ./gradlew ui:ui-text:test
Test: ./gradlew ui:ui-text:connectedAndroidTest
Bug: 141645236
Bug: 143700963
Bug: 122476423
Bug: 143703328
Bug: 127483182
Bug: 143699225
Change-Id: I4ff001fd1e0fff4cd3aa0c64efae929057e8d5de
M ui/ui-text/api/0.1.0-dev03.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev03.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev03.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/main/java/androidx/ui/text/font/Font.kt
M ui/ui-text/src/main/java/androidx/ui/text/platform/AndroidParagraphHelper.kt
M ui/ui-text/src/main/java/androidx/ui/text/platform/TypefaceAdapter.kt
M ui/ui-text/src/main/java/androidx/ui/text/style/BaselineShift.kt
M ui/ui-text/src/test/java/androidx/ui/text/font/FontFamilyTest.kt
M ui/ui-text/src/test/java/androidx/ui/text/font/FontTest.kt
https://android-review.googlesource.com/1156568
https://goto.google.com/android-sha1/c9e90d1e5671b7e6a8880aecbe32bb13f4b37560
Branch: androidx-master-dev
commit c9e90d1e5671b7e6a8880aecbe32bb13f4b37560
Author: Siyamed Sinir <siyamed@google.com>
Date: Thu Oct 31 11:30:30 2019
Remove font related TODOs
- Ability to read font weight from the font
- Support for font collections
- Support for variable fonts
- support for multiple font family
- BaselineShift.lerp
Test: ./gradlew ui:ui-text:test
Test: ./gradlew ui:ui-text:connectedAndroidTest
Bug: 141645236
Bug: 143700963
Bug: 122476423
Bug: 143703328
Bug: 127483182
Bug: 143699225
Change-Id: I4ff001fd1e0fff4cd3aa0c64efae929057e8d5de
M ui/ui-text/api/0.1.0-dev03.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev03.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev03.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/main/java/androidx/ui/text/font/Font.kt
M ui/ui-text/src/main/java/androidx/ui/text/platform/AndroidParagraphHelper.kt
M ui/ui-text/src/main/java/androidx/ui/text/platform/TypefaceAdapter.kt
M ui/ui-text/src/main/java/androidx/ui/text/style/BaselineShift.kt
M ui/ui-text/src/test/java/androidx/ui/text/font/FontFamilyTest.kt
M ui/ui-text/src/test/java/androidx/ui/text/font/FontTest.kt
ra...@google.com <ra...@google.com> #3
from dupped ticket
"CSS has font-variation-settings attribute
Also check if there are commonly used settings that we can add to the API.
Note:
Tracking ticket based on
https://docs.google.com/document/d/1MzK83egP-Jghc2ZW8IcIcJkud_vMM7jgDClCv4CkO_c/edit#bookmark=id.nyju92hr2ygw "
"CSS has font-variation-settings attribute
Also check if there are commonly used settings that we can add to the API.
Note:
Tracking ticket based on
ra...@google.com <ra...@google.com> #4
bulk comment, fyi: we have added icebox to all the tickets because it was suggested by blintz in order to prevent auto-close tickets. we want to keep our Compose tickets to remain opened.
see b/123001228#comment6
see
[Deleted User] <[Deleted User]> #5
discussion from aosp/1672420
variable font settings can be included during font creation (for Font() functions.)
there are two parts of the story:
- This font is weight X
- I want to render the text in weight Y (regardless of the font weight)
ra...@google.com <ra...@google.com> #6
important for Material.
cc...@google.com <cc...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit 8766bf0012613dfa48fdc969d03bd64217a4460c
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 13:17:37 2022
Add font variations to Android font constructors
On O+ this will allow configuring font variation settings.
Bug: b/143703328
Test: ./gradle :compose:ui:ui-text:cAT
Relnote: "Font constructors now accept a list of FontVariation.Setting for configuring variable fonts on O+ devices."
Change-Id: I11a9d69d73429e9a875fd7096a00981a0cbd8a47
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/testutils/AsyncTestFonts.kt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/AndroidFontTest.kt
A compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidLoadableFonts.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
A testutils/testutils-fonts/src/androidMain/assets/subdirectory/asset_variable_font.ttf
A testutils/testutils-fonts/src/font_ttx/variable_font.ttx
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFont.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/FontFamilyResolverImplTest.kt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/AndroidVariableFontTest.kt
A testutils/testutils-fonts/src/commonMain/resources/font/variable_font.ttf
https://android-review.googlesource.com/2162835
Branch: androidx-main
commit 8766bf0012613dfa48fdc969d03bd64217a4460c
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 13:17:37 2022
Add font variations to Android font constructors
On O+ this will allow configuring font variation settings.
Bug:
Test: ./gradle :compose:ui:ui-text:cAT
Relnote: "Font constructors now accept a list of FontVariation.Setting for configuring variable fonts on O+ devices."
Change-Id: I11a9d69d73429e9a875fd7096a00981a0cbd8a47
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/testutils/AsyncTestFonts.kt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/AndroidFontTest.kt
A compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidLoadableFonts.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
A testutils/testutils-fonts/src/androidMain/assets/subdirectory/asset_variable_font.ttf
A testutils/testutils-fonts/src/font_ttx/variable_font.ttx
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFont.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/FontFamilyResolverImplTest.kt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/AndroidVariableFontTest.kt
A testutils/testutils-fonts/src/commonMain/resources/font/variable_font.ttf
ra...@google.com <ra...@google.com>
ap...@google.com <ap...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
commit ef1fff276087529659dc11ae29b219fcc2e5c790
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 13:14:04 2022
FontVariation definition
Bug: b/143703328
Relnote: "Add FontVariation API for defining and using variable fonts."
Test: ./gradlew :compose:ui:ui-text:test
Change-Id: I3c40c6c8b4cee02cacda9482955ec16587ae62a5
M compose/ui/ui-text/lint-baseline.xml
A compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontVariation.kt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/font/FontVariationTest.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
https://android-review.googlesource.com/2161039
Branch: androidx-main
commit ef1fff276087529659dc11ae29b219fcc2e5c790
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 13:14:04 2022
FontVariation definition
Bug:
Relnote: "Add FontVariation API for defining and using variable fonts."
Test: ./gradlew :compose:ui:ui-text:test
Change-Id: I3c40c6c8b4cee02cacda9482955ec16587ae62a5
M compose/ui/ui-text/lint-baseline.xml
A compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontVariation.kt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/font/FontVariationTest.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
Description
Hello, I've followed
the tutorials outlined here:
to generate and then use profiles for my app startup scenario.
Generation of the profiles went as planned - with baseline-prof generated on the emulator. When I copied the file to my app though, and tried to build it and run the tests that would measure the efficiency of those profiles, gradle complained about several syntax errors in the generated profiles (idk if they really are syntax errors).
The errors looked like this:
iirc, errors were also detected along the lines that started with '[', like this one:
[Landroidx/appcompat/app/AppCompatDelegateImpl$PanelFeatureState;
I eventually went ahead and removed all patterns that resembled the failing ones (maybe removing too much), and the diff results were (unmodified profile diffed against one I edited manually:
We'd really love to use the new baseline profiling feature - let me know if there's more I can share to confirm where the issue might be.
Component used/Version used: in the tests that generated the profile:
Devices/Android versions reproduced on:
If this is a bug in the library, we would appreciate if you could attach: