`Modifier.draggable` is reporting wrong fling velocity if the component is moving [216582726]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Jan 27, 2022 12:27PM

Issue

TLDR; watch the attached video.

Was trying to make a free flowing bottom sheet like view, that allows for the sheet content to also be scrollable.

Was able to create this using .draggable() and a nested scroll connection. Code

Drags are working fine. But flings aren't, when the sheet is still moving. Because the fling velocity being reported in NestedScrollConnection.onPreFling() is wrong. Sometimes even in the opposite direction, if not the wrong magnitude.

Root Cause

I suspect this is because the velocity calculation is based on touch position relative to the component handling the pointer input.

Documentation of PointerInputChange states

position - The Offset of the current pointer event, relative to the containing element

Modifier.draggable which is also used in Modifier.scrollable effectively uses VelocityTracker.addPointerInputChange()

fun VelocityTracker.addPointerInputChange(event: PointerInputChange) {
    @OptIn(ExperimentalComposeUiApi::class)
    event.historical.fastForEach {
        addPosition(it.uptimeMillis, it.position)
    }
    addPosition(event.uptimeMillis, event.position)
}

Source: cs.android.com/VelocityTracker.kt

Potential Fix

If PointerInputChange also had absolutePosition which is relative to the window/screen, and the above function is modified to use absolutePosition instead of position(relative), then we will see the right velocity being calculated when drag has stopped

val event = if (isDragSuccessful) {
  val velocity =
    velocityTracker.calculateVelocity().toFloat(orientation)
  DragStopped(velocity * if (reverseDirection) -1 else 1)
}

Source: cs.android.com/Draggable.kt

I am not sure if we will need relative velocity of the user's fling to the component anywhere. It should be safe to move the implementation VelocityTracker.addPointerInputChange() to use absolutePosition always.

Other components that are affected (currently working around it)

Because of this issue, even Swipeable.kt doesn't use fling velocity to infer the direction of swipe, instead uses the diff of current offset and last offset - Swipeable.kt

Attachments

Code for reproducing the issue: okmanideep/flingvelocityissue
PFA video explaining the issue

draggable-fling-velocity-issue-demo.mp4

24 MB

Download

Comments

ma...@google.com <ma...@google.com> #2Jan 31, 2022 12:19PM

Reassigned to mo...@google.com.

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

mo...@google.com <mo...@google.com> #3Jan 31, 2022 07:34PM

Reassigned to ma...@google.com.

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

mo...@google.com <mo...@google.com> #4Jan 31, 2022 07:38PM

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

Message last modified on Jan 31, 2022 07:38PM

ma...@google.com <ma...@google.com> #5Feb 1, 2022 09:47AM

Reassigned to le...@google.com.

deleted

st...@google.com <st...@google.com> #6May 5, 2022 03:12PM

Facing the same issue here, Google autofill service seems to work. Zero documentation on adding support for Autofill framework on jetpack compose.

le...@google.com <le...@google.com> #7May 5, 2022 03:16PM

Hello, I am trying to implement the same thing - it seems like there's no way for current password managers like 1Password or Bitwarden, to automatically pick up the fields. Is there a possible solution?

ap...@google.com <ap...@google.com> #8May 19, 2022 03:44PM

Marked as fixed.

I setup this modifier:

@OptIn(ExperimentalComposeUiApi::class)
fun Modifier.autofill(
    autofillTypes: List<AutofillType>,
    onFill: ((String) -> Unit),
) = composed {
    val autofill = LocalAutofill.current
    val autofillNode = AutofillNode(onFill = onFill, autofillTypes = autofillTypes)
    LocalAutofillTree.current += autofillNode

    this.onGloballyPositioned {
        autofillNode.boundingBox = it.boundsInWindow()
    }.onFocusChanged { focusState ->
        autofill?.run {
            if (focusState.isFocused) {
                requestAutofillForNode(autofillNode)
            } else {
                cancelAutofillForNode(autofillNode)
            }
        }
    }
}

And use it like this:

val emailState = remember { EmailState() }
Email(
    modifier = Modifier.autofill(
        autofillTypes = listOf(
            AutofillType.Username,
            AutofillType.EmailAddress
        ),
        onFill = { emailState.text = it },
    ),
    emailState = emailState,
    onImeAction = { onForgotPasswordSubmitted(emailState.text) }
)

With these steps, autofill works for me.

le...@google.com <le...@google.com> May 29, 2022 10:42AM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #9Jun 8, 2022 09:03AM

Marked as fixed.

@lo...@gmail.com comment#8

what version of compose are you using? I'm using latest alpha and the above doesn't work for me. 😭

do...@gmail.com <do...@gmail.com> #10Jun 28, 2022 04:17PM

Works perfectly fine on the latest stable and alpha versions. Did you check in my second comment if you enabled everything?

le...@google.com <le...@google.com> Jun 28, 2022 04:18PM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #11Jun 28, 2022 07:29PM

Marked as fixed.

I believe so?

I copied the modifier and then used

modifier = Modifier.autofill(
        autofillTypes = listOf(
            AutofillType.Username,
            AutofillType.EmailAddress
        ),
        onFill = { emailState.text = it },
    )

on my text field.

to...@undo.app <to...@undo.app> #12Jul 15, 2022 09:13AM

The auto-filling works for me with the latest alpha version, but I'm never presented with the save dialog though.

Message last modified on Jul 15, 2022 09:14AM

le...@google.com <le...@google.com> #13Jul 15, 2022 09:21AM

The auto-filling works for me with the latest alpha version, but I'm never presented with the save dialog though.

I am having exactly same problem. Autofill works, but the Save dialog is never shown...

to...@undo.app <to...@undo.app> #14Jul 15, 2022 09:30AM

Any updates on this? I can't get LastPass to display at all. I can ONLY get the Google Auto-fill service to work

le...@google.com <le...@google.com> #15Aug 17, 2022 01:37PM

Same here, autofill in Jetpack Compose only works with the Google auto-fill service. When picking 1Password as the Auto-fill service in Settings, the debug log prints out:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

to...@undo.app <to...@undo.app> #16Aug 24, 2022 02:54PM

Is there a roadmap for autofill support in Compose? It's worrying I cannot find any meaningful information about this issue online. Will the autofill API remain as experimental?

le...@google.com <le...@google.com> #17Aug 24, 2022 03:53PM

is this issue still not resolved in compose 1.2.1???

Issue 216582726

Description

Issue

Root Cause

Potential Fix

Other components that are affected (currently working around it)

Attachments

Issue summary

Comments

ma...@google.com <ma...@google.com> #2Jan 31, 2022 12:19PM

mo...@google.com <mo...@google.com> #3Jan 31, 2022 07:34PM

mo...@google.com <mo...@google.com> #4Jan 31, 2022 07:38PM

ma...@google.com <ma...@google.com> #5Feb 1, 2022 09:47AM

st...@google.com <st...@google.com> #6May 5, 2022 03:12PM

le...@google.com <le...@google.com> #7May 5, 2022 03:16PM

ap...@google.com <ap...@google.com> #8May 19, 2022 03:44PM

le...@google.com <le...@google.com> May 29, 2022 10:42AM

ap...@google.com <ap...@google.com> #9Jun 8, 2022 09:03AM

do...@gmail.com <do...@gmail.com> #10Jun 28, 2022 04:17PM

le...@google.com <le...@google.com> Jun 28, 2022 04:18PM

ap...@google.com <ap...@google.com> #11Jun 28, 2022 07:29PM

to...@undo.app <to...@undo.app> #12Jul 15, 2022 09:13AM

le...@google.com <le...@google.com> #13Jul 15, 2022 09:21AM

to...@undo.app <to...@undo.app> #14Jul 15, 2022 09:30AM

le...@google.com <le...@google.com> #15Aug 17, 2022 01:37PM

to...@undo.app <to...@undo.app> #16Aug 24, 2022 02:54PM

le...@google.com <le...@google.com> #17Aug 24, 2022 03:53PM

Add comment

Issue metadata