RenderNodeApi23.discardDisplayList throws noSuchMethodError [216660268]

Fixed

Bug

Status Update

No update yet.

Description

cc...@google.com

created issue #1

Jan 27, 2022 08:37PM

I was looking at API 23 failures in benchmark (b/173743418), and fixed an issue where one failed test brought down the entire suite. In so doing, I noticed a similar pattern in compose tests. Roughly 58 tests out of the 186 in compose.ui aren't actually running, they're just bypassed.

Example failure - Instrumentation run failed due to 'java.lang.NoSuchMethodError'

Translation - process crash skipped a lot of tests.

Sample failure log snippet:

07-29 01:28:59.587 29748 29748 D MonitoringInstr: java.lang.NoSuchMethodError: No virtual method discardDisplayList()V in class Landroid/view/RenderNode; or its super classes (declaration of 'android.view.RenderNode' appears in /system/framework/framework.jar)
07-29 01:28:59.587 29748 29748 D MonitoringInstr: 	at androidx.compose.ui.platform.RenderNodeApi23.<init>(RenderNodeApi23.android.kt:68)
07-29 01:28:59.587 29748 29748 D MonitoringInstr: 	at androidx.compose.ui.AndroidLayoutDrawTest.verifyRenderNode23CameraDistance(AndroidLayoutDrawTest.kt:233)
07-29 01:28:59.587 29748 29748 D MonitoringInstr: 	at androidx.compose.ui.AndroidLayoutDrawTest.testLayerCameraDistance$lambda-0(AndroidLayoutDrawTest.kt:210)
07-29 01:28:59.587 29748 29748 D MonitoringInstr: 	at androidx.compose.ui.AndroidLayoutDrawTest.$r8$lambda$KWT53q-UCvVQPgaJ_g_F61u95jM(AndroidLayoutDrawTest.kt)
07-29 01:28:59.587 29748 29748 D MonitoringInstr: 	at androidx.compose.ui.AndroidLayoutDrawTest$$ExternalSyntheticLambda29.run(D8$$SyntheticClass)

Looking at compose code, RenderNodeApi23 calls RenderNode.discardDisplayList()

But in API 23 that method was called RenderNode.destroyDisplayListData(). It was only changed to discardDisplayList in API 24.

Comments

ap...@google.com <ap...@google.com> #2Feb 1, 2022 10:00PM

Marked as fixed.

First of all thanks for this detailed issue.

This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.

The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.

Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.

Issue 216660268

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Feb 1, 2022 10:00PM

Add comment

Issue metadata