Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit c8fd260a6e243363a3d37d02ff2111b1c6ec0027
Author: Nader Jawad <njawad@google.com>
Date: Fri Jan 28 14:46:33 2022
Fixed mis-named method call on RenderNode
Added stub method destroyDisplayListData which
was the original name for discardDisplayList
on Android versions M and below.
This fixes the NoSuchMethodFound exception that
was thrown when attempting to call discardDisplayList
on older Android levels
Relnote: "Introduced destroyDisplayListData
method on RenderNode stub class"
Fixes: 216660268
Test: Re-ran AndroidLayoutDrawTest#testCameraDistance
Change-Id: I1e6593d802a1e3eb01ff4f0c6f530b016929cf18
M compose/ui/ui-android-stubs/api/restricted_current.txt
M compose/ui/ui-android-stubs/src/main/java/android/view/RenderNode.java
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeApi23.android.kt
M compose/ui/ui-android-stubs/api/public_plus_experimental_current.txt
M compose/ui/ui-android-stubs/api/current.txt
https://android-review.googlesource.com/1965457
Branch: androidx-main
commit c8fd260a6e243363a3d37d02ff2111b1c6ec0027
Author: Nader Jawad <njawad@google.com>
Date: Fri Jan 28 14:46:33 2022
Fixed mis-named method call on RenderNode
Added stub method destroyDisplayListData which
was the original name for discardDisplayList
on Android versions M and below.
This fixes the NoSuchMethodFound exception that
was thrown when attempting to call discardDisplayList
on older Android levels
Relnote: "Introduced destroyDisplayListData
method on RenderNode stub class"
Fixes: 216660268
Test: Re-ran AndroidLayoutDrawTest#testCameraDistance
Change-Id: I1e6593d802a1e3eb01ff4f0c6f530b016929cf18
M compose/ui/ui-android-stubs/api/restricted_current.txt
M compose/ui/ui-android-stubs/src/main/java/android/view/RenderNode.java
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeApi23.android.kt
M compose/ui/ui-android-stubs/api/public_plus_experimental_current.txt
M compose/ui/ui-android-stubs/api/current.txt
Description
I was looking at API 23 failures in benchmark ( b/173743418 ), and fixed an issue where one failed test brought down the entire suite. In so doing, I noticed a similar pattern in compose tests . Roughly 58 tests out of the 186 in compose.ui aren't actually running, they're just bypassed.
Translation - process crash skipped a lot of tests.
Sample failure log snippet:
Looking at compose code, RenderNodeApi23 calls RenderNode.discardDisplayList()
But in API 23 that method was called RenderNode.destroyDisplayListData() . It was only changed to discardDisplayList in API 24 .