Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
A couple of questions:
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
jb...@google.com <jb...@google.com> #3
Tested on Android 12 Emulator with custom executor, but cannot repro this issue.
br...@gmail.com <br...@gmail.com> #4
-
Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
-
Dynamic features are not used in the application.
As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.
Description
Now that we have CreationExtras for creating ViewModels via a ViewModelProvider, it would be nice if we could simplify the use of it even further particular for simple cases.
The creation extra has all of the information needed to make a ViewModel and by providing arguments to through extras you can instantiate ViewModels with specified values.
We can create a simple factory that associates a ViewModel class with a lambda and leverages CreationExtras to easily instantiate the class appropriately.