Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 8d3029a3cc3eadac51003e4a76207cf5638c26b6
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Jan 28 12:07:09 2022
Integrate CreationExtras into Compose
Add a parameter that takes CreationExtras to
lifecycle-viewmodel-compose.
RelNote: "You can now create a `ViewModel` with CreationExtras via
`lifecycle-viewmodel-compose`."
Test: ViewModelTest
Bug: 216688927
Change-Id: I08887cf8df03ade08dceeb84bccbe3fd9748186e
M lifecycle/lifecycle-viewmodel-compose/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-compose/integration-tests/lifecycle-viewmodel-demos/build.gradle
M lifecycle/lifecycle-viewmodel-compose/src/androidTest/java/androidx/lifecycle/viewmodel/compose/ViewModelTest.kt
M lifecycle/lifecycle-viewmodel-compose/samples/build.gradle
M lifecycle/lifecycle-viewmodel-compose/api/current.txt
M lifecycle/lifecycle-viewmodel-compose/api/public_plus_experimental_current.txt
A lifecycle/lifecycle-viewmodel-compose/api/restricted_current.ignore
A lifecycle/lifecycle-viewmodel-compose/samples/src/main/java/androidx/lifecycle/viewmodel/compose/samples/LifecycleViewModelSamples.kt
M lifecycle/lifecycle-viewmodel-compose/src/main/java/androidx/lifecycle/viewmodel/compose/ViewModel.kt
A lifecycle/lifecycle-viewmodel-compose/api/current.ignore
https://android-review.googlesource.com/1965663
Branch: androidx-main
commit 8d3029a3cc3eadac51003e4a76207cf5638c26b6
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Jan 28 12:07:09 2022
Integrate CreationExtras into Compose
Add a parameter that takes CreationExtras to
lifecycle-viewmodel-compose.
RelNote: "You can now create a `ViewModel` with CreationExtras via
`lifecycle-viewmodel-compose`."
Test: ViewModelTest
Bug: 216688927
Change-Id: I08887cf8df03ade08dceeb84bccbe3fd9748186e
M lifecycle/lifecycle-viewmodel-compose/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-compose/integration-tests/lifecycle-viewmodel-demos/build.gradle
M lifecycle/lifecycle-viewmodel-compose/src/androidTest/java/androidx/lifecycle/viewmodel/compose/ViewModelTest.kt
M lifecycle/lifecycle-viewmodel-compose/samples/build.gradle
M lifecycle/lifecycle-viewmodel-compose/api/current.txt
M lifecycle/lifecycle-viewmodel-compose/api/public_plus_experimental_current.txt
A lifecycle/lifecycle-viewmodel-compose/api/restricted_current.ignore
A lifecycle/lifecycle-viewmodel-compose/samples/src/main/java/androidx/lifecycle/viewmodel/compose/samples/LifecycleViewModelSamples.kt
M lifecycle/lifecycle-viewmodel-compose/src/main/java/androidx/lifecycle/viewmodel/compose/ViewModel.kt
A lifecycle/lifecycle-viewmodel-compose/api/current.ignore
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 4b9ac362ff7a4106416b3dfff89bcd51b8c339a2
Author: Yigit Boyar <yboyar@gmail.com>
Date: Fri Feb 11 01:31:59 2022
[GH] need new prebuilts for lifecycle, disabling until then
https://android-review.googlesource.com/c/platform/frameworks/support/+/1965663
Test: n/a
Bug: 216688927
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/329 .
Resolves #329
Github-Pr-Head-Sha: 02305d0dc822413720387b409452ee0ffd0f7bf6
GitOrigin-RevId: a32b14fb87193f186539c02fcde2ffdb5ab14ff8
Change-Id: I3b3caef3a9e23e7684d82630312c113e177204b1
M .github/ci-control/ci-config.json
https://android-review.googlesource.com/1981347
Branch: androidx-main
commit 4b9ac362ff7a4106416b3dfff89bcd51b8c339a2
Author: Yigit Boyar <yboyar@gmail.com>
Date: Fri Feb 11 01:31:59 2022
[GH] need new prebuilts for lifecycle, disabling until then
Test: n/a
Bug: 216688927
This is an imported pull request from
Resolves #329
Github-Pr-Head-Sha: 02305d0dc822413720387b409452ee0ffd0f7bf6
GitOrigin-RevId: a32b14fb87193f186539c02fcde2ffdb5ab14ff8
Change-Id: I3b3caef3a9e23e7684d82630312c113e177204b1
M .github/ci-control/ci-config.json
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit b0176546054f2db3fb766a49fb48ccee2e1bd133
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Feb 03 15:55:43 2022
Add compose CreationExtras initializer integration
Adding a viewModel APIs that takes a lambda that initializes a factory
using CreationExtras.
RelNote: "`lifecycle-viewmodel-compose` now offers a `viewModel()` API that
takes a lambda factory for creating a `ViewModel` instance without
requiring the creation of a custom `ViewModelProvider.Factory`."
Test: ViewModelTest
Bug: 216688927
Change-Id: I97fbb96b6426eed4805feffe249220a783ec8999
M lifecycle/lifecycle-viewmodel-compose/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-compose/src/androidTest/java/androidx/lifecycle/viewmodel/compose/ViewModelTest.kt
M lifecycle/lifecycle-viewmodel-compose/api/current.txt
M lifecycle/lifecycle-viewmodel-compose/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-viewmodel-compose/samples/src/main/java/androidx/lifecycle/viewmodel/compose/samples/LifecycleViewModelSamples.kt
M lifecycle/lifecycle-viewmodel-compose/src/main/java/androidx/lifecycle/viewmodel/compose/ViewModel.kt
https://android-review.googlesource.com/1972159
Branch: androidx-main
commit b0176546054f2db3fb766a49fb48ccee2e1bd133
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Feb 03 15:55:43 2022
Add compose CreationExtras initializer integration
Adding a viewModel APIs that takes a lambda that initializes a factory
using CreationExtras.
RelNote: "`lifecycle-viewmodel-compose` now offers a `viewModel()` API that
takes a lambda factory for creating a `ViewModel` instance without
requiring the creation of a custom `ViewModelProvider.Factory`."
Test: ViewModelTest
Bug: 216688927
Change-Id: I97fbb96b6426eed4805feffe249220a783ec8999
M lifecycle/lifecycle-viewmodel-compose/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-compose/src/androidTest/java/androidx/lifecycle/viewmodel/compose/ViewModelTest.kt
M lifecycle/lifecycle-viewmodel-compose/api/current.txt
M lifecycle/lifecycle-viewmodel-compose/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-viewmodel-compose/samples/src/main/java/androidx/lifecycle/viewmodel/compose/samples/LifecycleViewModelSamples.kt
M lifecycle/lifecycle-viewmodel-compose/src/main/java/androidx/lifecycle/viewmodel/compose/ViewModel.kt
jb...@google.com <jb...@google.com> #5
This has been fixed internally and will be available in the Lifecycle 2.5.0-alpha03
release.
Description
ViewModel added new CreationExtras APIs for providing information from
ViewModelStoreOwner
s to ViewModel factories. This should be integrated intolifecycle-viewmodel-compose
so that ViewModel can easily be created from CreationExtras.