Emoji: IndexOutOfBoundsException [216891011]

Fixed

Bug

Status Update

No update yet.

Description

ma...@bokhorst.biz

created issue #1

Jan 30, 2022 03:00PM

Component used: androidx.emoji2:emoji2

Version used: 1.0.1

Devices/Android versions reproduced on: Huawei BAH2-W19 and probably others

java.lang.IndexOutOfBoundsException: 247, -245
    at android.text.PackedIntVector.deleteAt(PackedIntVector.java:222)
    at android.text.DynamicLayout.reflow(DynamicLayout.java:317)
    at android.text.DynamicLayout.-wrap0(Unknown Source:0)
    at android.text.DynamicLayout$ChangeWatcher.reflow(DynamicLayout.java:750)
    at android.text.DynamicLayout$ChangeWatcher.onSpanChanged(DynamicLayout.java:779)
    at androidx.emoji2.text.SpannableBuilder$WatcherWrapper.onSpanChanged(SourceFile:2)
    at android.text.SpannableStringBuilder.sendSpanChanged(SpannableStringBuilder.java:1296)
    at android.text.SpannableStringBuilder.sendToSpanWatchers(SpannableStringBuilder.java:651)
    at android.text.SpannableStringBuilder.replace(SpannableStringBuilder.java:581)
    at androidx.emoji2.text.SpannableBuilder.replace(SourceFile:7)
    at android.text.SpannableStringBuilder.replace(SpannableStringBuilder.java:504)
    at androidx.emoji2.text.SpannableBuilder.replace(SourceFile:4)
    at androidx.emoji2.text.SpannableBuilder.replace(SourceFile:1)
    at android.view.inputmethod.BaseInputConnection.replaceText(BaseInputConnection.java:848)
    at android.view.inputmethod.BaseInputConnection.commitText(BaseInputConnection.java:197)
    at com.android.internal.widget.EditableInputConnection.commitText(EditableInputConnection.java:183)
    at android.view.inputmethod.InputConnectionWrapper.commitText(InputConnectionWrapper.java:158)
    at android.view.inputmethod.InputConnectionWrapper.commitText(InputConnectionWrapper.java:158)
    at com.android.internal.view.IInputConnectionWrapper.executeMessage(IInputConnectionWrapper.java:344)
    at com.android.internal.view.IInputConnectionWrapper$MyHandler.handleMessage(IInputConnectionWrapper.java:85)
    at android.os.Handler.dispatchMessage(Handler.java:108)
    at android.os.Looper.loop(Looper.java:166)
    at android.app.ActivityThread.main(ActivityThread.java:7529)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:245)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:921)

Comments

se...@google.com <se...@google.com> #2Jan 31, 2022 06:20PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

ma...@bokhorst.biz <ma...@bokhorst.biz> #3Jan 31, 2022 06:23PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

se...@google.com <se...@google.com> #4Jan 31, 2022 06:25PM

deleted

ma...@bokhorst.biz <ma...@bokhorst.biz> #5Jan 31, 2022 06:28PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

se...@google.com <se...@google.com> #6Jan 31, 2022 06:36PM

Thanks for the info! Will take a look.

se...@google.com <se...@google.com> Feb 1, 2022 12:57AM

Reassigned to se...@google.com.

ma...@bokhorst.biz <ma...@bokhorst.biz> #7Feb 1, 2022 06:12AM

This crash is taking apps down (not mine anymore, which was confirmed by the reporter of the crash). So, I think this issue deserves at least some attention.

se...@google.com <se...@google.com> #8Mar 8, 2022 06:41PM

Related b/67926915

se...@google.com <se...@google.com> #9Mar 8, 2022 07:26PM

Test case that reproduces crash prior to P

    @Test
    //@SdkSuppress(maxSdkVersion = 27) /* this is for testing before P crash */
    public void testSpanRangeOldValueCalculation() throws Exception {
        // this test is ported from CTS
        // DynamicLayoutTest.testReflow_afterSpanChangedShouldNotThrowException
        String className = "android.text.DynamicLayout$ChangeWatcher";
        Class<?> watcherClass = Class.forName(className, false,
                getClass().getClassLoader());
        SpannableBuilder builder = new SpannableBuilder(watcherClass, "crash crash crash!!");

        TypefaceSpan span = mock(TypefaceSpan.class);
        builder.setSpan(span, 1, 4, SPAN_EXCLUSIVE_EXCLUSIVE);

        // this DynamicLayout causes the replace/insert before position 1 below to crash prior to P
        new DynamicLayout(builder, new TextPaint(), Integer.MAX_VALUE,
                Layout.Alignment.ALIGN_NORMAL, 1.0f, 1.0f, true);
        try {
            builder.replace(1, 1, "Hello there\n\n");
        } catch (Throwable e) {
            throw new RuntimeException("Inserting text into DynamicLayout should not crash", e);
        }
    }

ma...@bokhorst.biz <ma...@bokhorst.biz> #10Mar 8, 2022 07:29PM

I see good progress here ;-)

se...@google.com <se...@google.com> #11Mar 8, 2022 09:27PM

Fix coming in the next release.

It's a platform DynamicLayout bug, but since it's running through emoji2 we have an opportunity to backport it prior to P :party:.

ap...@google.com <ap...@google.com> #12Mar 8, 2022 10:30PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 96445c4b96e57ac060ea06c88e477622f28a2e00
Author: Sean McQuillan <seanmcq@google.com>
Date: Tue Mar 08 12:35:32 2022

Backport platform DynamicLayout crashfix to emoji2

Backport of Android P crashfix (

b/67926915

) to emoji2.

This causes insert and replace calls to not crash when they happen
adjacent to spans that are EXCLUSIVE_EXCLUSIVE.

Previously, the range would be negative which would cause incorrect
integer math inside of DynamicLayout. The new behavior is to never pass
negative ranges by ressetting start to 0 before passing to DynamicLayout
which causes more reflow and avoids a crash.

This was previously fixed on platform and is covered by CTS test
DynamicLayoutTest#testReflow_afterSpanChangedShouldNotThrowException()

Fixes:

b/216891011

Test: ./gradlew :e2:e2:cAT
Relnote: "Backport editor crash fix from Android P to EditText that is
configured to use emoji2 (platform bug