Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
the same issue for SmallTopAppBar:
jb...@google.com <jb...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 46c69840b7e4462f71a2289213f2771ae7702c9f
Author: Shalom Gibly <sgibly@google.com>
Date: Wed Oct 12 16:05:59 2022
Updates medium and large top app bar background
Updates to apply the same background color to both part of the Medium or
Large top app bar.
This change also allows such a top app bar to be made transparent.
Bug: 249688556
Bug: 250838918
Test: AppBarTest passing
Relnote: "Updates Material3 Medium and Large top app bars to apply the
same background color across their entire surface, and to allow setting
overriding the default colors with transparent color values."
Change-Id: I67659d8754b953165a5b2fa3c7a5720a0976665e
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt
https://android-review.googlesource.com/2253154
Branch: androidx-main
commit 46c69840b7e4462f71a2289213f2771ae7702c9f
Author: Shalom Gibly <sgibly@google.com>
Date: Wed Oct 12 16:05:59 2022
Updates medium and large top app bar background
Updates to apply the same background color to both part of the Medium or
Large top app bar.
This change also allows such a top app bar to be made transparent.
Bug: 249688556
Bug: 250838918
Test: AppBarTest passing
Relnote: "Updates Material3 Medium and Large top app bars to apply the
same background color across their entire surface, and to allow setting
overriding the default colors with transparent color values."
Change-Id: I67659d8754b953165a5b2fa3c7a5720a0976665e
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt
Description
When adding the stateless aosp/1859226 it used the
SavedStateViewModelFactory
constructor inAndroidViewModelFactory
under the hood, which meant that when using the statelessSavedStateViewModelFactory
and creating aViewModel
viaCreationExtras
, it required anApplication
to be set.Having an
Application
should not be a requirement for creating aViewModel
using theSavedStateViewModelFactory
or theAndroidViewModelFactory
. We should fix the behavior of theAndroidViewModelFactory
to rely on theNewInstanceFactory
when no application is available, just like theSavedStateViewModelFactory
used to.