Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e9b8f3833bd179a1f97c659585cf8ac93c1e5e71
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Jan 31 17:31:06 2022
Allow AndroidViewModelFactory to create basic view models
When the stateless SavedStateViewModelFactory was added in aosp/1859226,
it unintentionally made it so that when using CreationExtras an
application was required to create a view model. That is not a hard
requirement of SavedStateViewModelFactory and this was caused by it
using AndroidViewModelFactory by default and that should also not be a
constraint there.
When creating a view model via AndroidViewModelFactory when using
CreationExtras, we should not require an application, and should instead
fall back to the NewInstanceFactory behavior.
RelNote: "`AndroidViewModelFactory` will not longer require an
application to be set when creating a view model via `CreationExtras`."
Test: AndroidViewModelFactoryTest
Bug: 217271656
Change-Id: I6ebefdf40940a08576a92ee4fb2dcc2b561d781d
M lifecycle/lifecycle-viewmodel/src/androidTest/java/androidx/lifecycle/AndroidViewModelFactoryTest.kt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelProvider.kt
https://android-review.googlesource.com/1967008
Branch: androidx-main
commit e9b8f3833bd179a1f97c659585cf8ac93c1e5e71
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Jan 31 17:31:06 2022
Allow AndroidViewModelFactory to create basic view models
When the stateless SavedStateViewModelFactory was added in aosp/1859226,
it unintentionally made it so that when using CreationExtras an
application was required to create a view model. That is not a hard
requirement of SavedStateViewModelFactory and this was caused by it
using AndroidViewModelFactory by default and that should also not be a
constraint there.
When creating a view model via AndroidViewModelFactory when using
CreationExtras, we should not require an application, and should instead
fall back to the NewInstanceFactory behavior.
RelNote: "`AndroidViewModelFactory` will not longer require an
application to be set when creating a view model via `CreationExtras`."
Test: AndroidViewModelFactoryTest
Bug: 217271656
Change-Id: I6ebefdf40940a08576a92ee4fb2dcc2b561d781d
M lifecycle/lifecycle-viewmodel/src/androidTest/java/androidx/lifecycle/AndroidViewModelFactoryTest.kt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelProvider.kt
jb...@google.com
This has been fixed internally and will be available in the Lifecycle 2.5.0-alpha02 release.
Description
When adding the stateless
SavedStateViewModelFactoryconstructor inAndroidViewModelFactoryunder the hood, which meant that when using the statelessSavedStateViewModelFactoryand creating aViewModelviaCreationExtras, it required anApplicationto be set.Having an
Applicationshould not be a requirement for creating aViewModelusing theSavedStateViewModelFactoryor theAndroidViewModelFactory. We should fix the behavior of theAndroidViewModelFactoryto rely on theNewInstanceFactorywhen no application is available, just like theSavedStateViewModelFactoryused to.