Status Update
No update yet.
Comments
jb...@google.com
I don't think this is enough cause we don't know how it is being produced. If you could create a project that recreates this that would be great, if not please provide us with the steps and we can see if that helps.
li...@gmail.com
It looks like we were using a CopyOnWriteArrayList in the Java version of NavController, which was resilient to removing an OnDestinationChangedListener as part of the dispatch i.e.,
addOnDestinationChangedListener(object : OnDestinationChangedListener {
override fun onDestinationChanged(
controller: NavController,
destination: NavDestination,
arguments: Bundle?
) {
removeOnDestinationChangedListener(this)
}
})
// Note, you need to have at least one other OnDestinationChangedListener
// that is added after the one that is removed to duplicate this error
We lost that resiliency when we converted over to Kotlin, hence this error. We need to switch back.
jb...@google.com
sv...@whisp.de
We get this crash as well. I have a simple sample project where it can't be reproduced so it could be due to our nested graphs.
Kinda tl;dr scenario where it happens Graph 1 > Graph 2 (Graph 2 has bottom hav) - Navigate to dynamic feature module and click back - Navigate with BottomNavigationView.
I've spent some time trying to get a sample project which recreates the crash without success as the request in #2. Is that still needed after
ap...@google.com
Branch: androidx-main
commit cb7bd694963278c03e987603f51953f0b89d3f1c
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri May 21 14:03:22 2021
Fix ConcurrentModificationException on the OnDestinationChangedListener
Go back to using the CopyOnWriteArrayList to ensure that
modifying the list of OnDestinationChangedListeners is safe.
RelNote: "You will no longer get a ConcurrentModificationException when
using OnDestinationChangedListeners."
Test: NavControllerTest
Bug: 188860458
Change-Id: Ib17074c773ed9462c6a69ad384c23e28fa8abaf6
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
jb...@google.com
This has been fixed internally and will be available in the Navigation 2.4.0-alpha02 release.
hn...@formerstudents.ucdavis.edu
sp...@google.com
Re: #7, you might be hitting an error if your applicationId is different than your namespace because the navigation-safe-args-gradle-plugin is incorrectly using the applicationId instead of the namespace to namespace the R class. There's an internal bug tracking this (
sv...@whisp.de
Can you please post a comment on this issue so that everyone subscribed here will be notified when the internal bug has been fixed and the fix has been shipped? Thanks in advance!
sp...@google.com
Re #9,
sv...@whisp.de
Neat, many thanks!
Description
Component used: Navigation SafeArgs Kotlin Plugin
Version used: 2.3.5, 2.5.0-alpha01
Reproduced on: Build step
My problem is that the plugin generates classes using the package field from the manifest and substitutes in the path to import the R class.
If you remove the name package field from the manifest and move it to gradle script namespace(AGP 7.1.0). The plugin will generate Directions files with this R import:
import RAnd I receive
Unresolved reference: RTherefore will not find the required ActionId from xml When I ran into returning package in the manifest file, it generated the correct R class imports
import com.example.app.R