Safeargs kotlin plugin using manifest package id for generating Directions class [217414933]

Fixed

Feature Request

Status Update

No update yet.

Description

li...@gmail.com

created issue #1

Feb 2, 2022 01:45PM

Component used: Navigation SafeArgs Kotlin Plugin

Version used: 2.3.5, 2.5.0-alpha01

Reproduced on: Build step

My problem is that the plugin generates classes using the package field from the manifest and substitutes in the path to import the R class.

If you remove the name package field from the manifest and move it to gradle script namespace(AGP 7.1.0). The plugin will generate Directions files with this R import:

import R

And I receive Unresolved reference: R

Therefore will not find the required ActionId from xml When I ran into returning package in the manifest file, it generated the correct R class imports

import com.example.app.R

Comments

jb...@google.com <jb...@google.com> #2Feb 2, 2022 04:55PM

since these are in public API (:/) we need to do this in 1.2

li...@gmail.com <li...@gmail.com> #3Feb 3, 2022 02:47PM

since it is already marked as deprecated, we can probably do it by now.

jb...@google.com <jb...@google.com> Feb 10, 2022 10:28PM

Assigned to jb...@google.com.

sv...@whisp.de <sv...@whisp.de> #4Feb 16, 2022 02:40PM

Opening diff shortly

ap...@google.com <ap...@google.com> #5Feb 16, 2022 10:23PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

jb...@google.com <jb...@google.com> #6Feb 16, 2022 10:24PM

Marked as fixed.

This has been fixed internally and will be available in the Navigation 2.4.2 and 2.5.0-alpha03 releases.

hn...@formerstudents.ucdavis.edu <hn...@formerstudents.ucdavis.edu> #7May 10, 2022 01:51AM

This issue is not fixed in `2.4.2`

Mon May 09 2022 18:50:48 GMT-0700 (Pacific Daylight Time).png

238 KB

View

Download

sp...@google.com <sp...@google.com> #8May 10, 2022 03:37PM

Re: #7, you might be hitting an error if your applicationId is different than your namespace because the navigation-safe-args-gradle-plugin is incorrectly using the applicationId instead of the namespace to namespace the R class. There's an internal bug tracking this (Issue 230786658)

sv...@whisp.de <sv...@whisp.de> #9May 10, 2022 05:52PM

Can you please post a comment on this issue so that everyone subscribed here will be notified when the internal bug has been fixed and the fix has been shipped? Thanks in advance!

sp...@google.com <sp...@google.com> #10May 11, 2022 03:47PM

Re #9, Issue 232107688 is a public bug tracking the same issue.

sv...@whisp.de <sv...@whisp.de> #11May 11, 2022 04:07PM

Neat, many thanks!