Assigned
Status Update
Comments
ml...@google.com <ml...@google.com> #2
It's not triggering on Pixel 3 Android 12, but every time on the Pixel 6.
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 2ae6b97cc071130e4903b58bda454bcf29bb8e15
Author: Chris Craik <ccraik@google.com>
Date: Thu Feb 10 16:51:02 2022
Use PowerManager for throttle detection when available
Bug: 217497678
Fixes: 131755853
Test: ThrottleDetectorTest - wrapped Pixel 2 in a jacket until it started throttling
Relnote: "Use PowerManager for thermal throttling detection on Q (API
29) and higher. This significantly reduces frequency of false
positives in thermal throttling detection (benchmark retry after 90
second cooldown), and speeds up benchmarks significantly on user
builds. It also provides throttle detection even when clocks are
locked (if they're locked too high for the device's physical
environment)."
Change-Id: I9c02781c91bb1f646f98d1c84f44fa16c6e5e7ba
M benchmark/benchmark-common/src/main/java/androidx/benchmark/BenchmarkState.kt
A benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/ThrottleDetectorTest.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/ThrottleDetector.kt
https://android-review.googlesource.com/1981246
Branch: androidx-main
commit 2ae6b97cc071130e4903b58bda454bcf29bb8e15
Author: Chris Craik <ccraik@google.com>
Date: Thu Feb 10 16:51:02 2022
Use PowerManager for throttle detection when available
Bug: 217497678
Fixes: 131755853
Test: ThrottleDetectorTest - wrapped Pixel 2 in a jacket until it started throttling
Relnote: "Use PowerManager for thermal throttling detection on Q (API
29) and higher. This significantly reduces frequency of false
positives in thermal throttling detection (benchmark retry after 90
second cooldown), and speeds up benchmarks significantly on user
builds. It also provides throttle detection even when clocks are
locked (if they're locked too high for the device's physical
environment)."
Change-Id: I9c02781c91bb1f646f98d1c84f44fa16c6e5e7ba
M benchmark/benchmark-common/src/main/java/androidx/benchmark/BenchmarkState.kt
A benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/ThrottleDetectorTest.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/ThrottleDetector.kt
cc...@google.com <cc...@google.com> #4
Punting additional work here, since CL above is expected to fix 29+.
Description
Version used: 1.1.0-beta01
Devices/Android versions reproduced on: Pixel 6 Android 12
RecyclerViewBenchmark#scroll()
withMethodTracing
is triggering thermal throttling, even though the device is not even warm.