Fixed
Status Update
No update yet.
Comments
ra...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e7b4b06e67951ab47157d06ff314a5c8b2e8fdc6
Author: Andrei Shikov <ashikov@google.com>
Date: Mon Jan 08 15:54:51 2024
Count recursive local declarations as captures
Local declarations were already counted as captures for composable lambdas before, but the traversal ordering missed the recursive captures, converting some of them into singletons.
Test: Compiler test
Fixes: 318745941
Change-Id: I9097d1be71fb67b73e5027f723fd187c4272f6b4
M compose/compiler/compiler-hosted/integration-tests/src/androidUnitTest/kotlin/androidx/compose/compiler/plugins/kotlin/ComposeBytecodeCodegenTest.kt
M compose/compiler/compiler-hosted/integration-tests/src/jvmTest/kotlin/androidx/compose/compiler/plugins/kotlin/AbstractCodegenTest.kt
M compose/compiler/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/ComposerLambdaMemoization.kt
https://android-review.googlesource.com/2900890
Branch: androidx-main
commit e7b4b06e67951ab47157d06ff314a5c8b2e8fdc6
Author: Andrei Shikov <ashikov@google.com>
Date: Mon Jan 08 15:54:51 2024
Count recursive local declarations as captures
Local declarations were already counted as captures for composable lambdas before, but the traversal ordering missed the recursive captures, converting some of them into singletons.
Test: Compiler test
Fixes: 318745941
Change-Id: I9097d1be71fb67b73e5027f723fd187c4272f6b4
M compose/compiler/compiler-hosted/integration-tests/src/androidUnitTest/kotlin/androidx/compose/compiler/plugins/kotlin/ComposeBytecodeCodegenTest.kt
M compose/compiler/compiler-hosted/integration-tests/src/jvmTest/kotlin/androidx/compose/compiler/plugins/kotlin/AbstractCodegenTest.kt
M compose/compiler/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/ComposerLambdaMemoization.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit d6b85108200266bb6a5e963c284fc0d7b13255bd
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Wed Feb 09 10:01:14 2022
Profile Installer now throws a helpful error when trying to use Metadata 001 for V015 profiles.
Test: Added unit tests.
Bug:
Change-Id: I72b22f0cb091c8b07aae42d333cbda0d9e8cee9f
M profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/DeviceProfileWriter.java
M profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/ProfileTranscoder.java
M profileinstaller/profileinstaller/src/test/java/androidx/profileinstaller/ProfileTranscoderTests.java
https://android-review.googlesource.com/1978526
Branch: androidx-main
commit d6b85108200266bb6a5e963c284fc0d7b13255bd
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Wed Feb 09 10:01:14 2022
Profile Installer now throws a helpful error when trying to use Metadata 001 for V015 profiles.
Test: Added unit tests.
Bug:
Change-Id: I72b22f0cb091c8b07aae42d333cbda0d9e8cee9f
M profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/DeviceProfileWriter.java
M profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/ProfileTranscoder.java
M profileinstaller/profileinstaller/src/test/java/androidx/profileinstaller/ProfileTranscoderTests.java
Description
Version used: 1.1.0-beta01
Devices/Android versions reproduced on: Android 12 (any)
CompilationMode.Partialfails (even withBaselineProfilesMode.Disabled) when ProfileInstaller is added to the dependencies.Currently the exception says
Baseline profiles aren't supported on this device versionwhich is not true.Better error message would be handy to guide developers to add newer version of
ProfileInstaller, because a library may add it silently which may be confusing (compose.ui has it in dependencies).