ProfileInstaller failed better error message [217502387]

Fixed

Bug

Status Update

No update yet.

Description

ml...@google.com

created issue #1

Feb 2, 2022 10:01AM

Version used: 1.1.0-beta01

Devices/Android versions reproduced on: Android 12 (any)

CompilationMode.Partial fails (even with BaselineProfilesMode.Disabled) when ProfileInstaller is added to the dependencies.

Currently the exception says Baseline profiles aren't supported on this device version which is not true.

Better error message would be handy to guide developers to add newer version of ProfileInstaller, because a library may add it silently which may be confusing (compose.ui has it in dependencies).

Comments

cc...@google.com <cc...@google.com> #2Feb 3, 2022 05:59PM

Reassigned to ra...@google.com.

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

ra...@google.com <ra...@google.com> #3Feb 3, 2022 06:37PM

Great! Thanks a lot, I'll look for the live updates soon!

ap...@google.com <ap...@google.com> #4Feb 9, 2022 06:41PM

Project: platform/frameworks/support
Branch: androidx-main

commit d6b85108200266bb6a5e963c284fc0d7b13255bd
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Wed Feb 09 10:01:14 2022

Profile Installer now throws a helpful error when trying to use Metadata 001 for V015 profiles.

Test: Added unit tests.
Bug:

b/217502387

Change-Id: I72b22f0cb091c8b07aae42d333cbda0d9e8cee9f

M profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/DeviceProfileWriter.java
M profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/ProfileTranscoder.java
M profileinstaller/profileinstaller/src/test/java/androidx/profileinstaller/ProfileTranscoderTests.java

https://android-review.googlesource.com/1978526

ra...@google.com <ra...@google.com> Feb 10, 2022 07:31PM

Accepted by ra...@google.com.

ra...@google.com <ra...@google.com> Feb 16, 2022 04:29PM

Marked as fixed.

Issue 217502387